From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eddie Cai <eddie.cai.linux@gmail.com>
Date: Tue, 2 May 2017 18:37:49 +0800
Subject: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support
 on rk3288 based device
In-Reply-To: <CAPnjgZ1a_FTOYkGx3TGgQ6OY8Fr1-6i=HVZ7z0YWApBR7PNDTQ@mail.gmail.com>
References: <1489564565-20856-1-git-send-email-eddie.cai.linux@gmail.com>
 <1489564565-20856-4-git-send-email-eddie.cai.linux@gmail.com>
 <CAPnjgZ1a_FTOYkGx3TGgQ6OY8Fr1-6i=HVZ7z0YWApBR7PNDTQ@mail.gmail.com>
Message-ID: <CAJrj+DMWHM7vvC7BkoioKk--jV6muurAh1rUkwqCi7NRte-DDQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon
2017-03-20 10:30 GMT+08:00 Simon Glass <sjg@chromium.org>:
> Hi Eddie.
>
> On 15 March 2017 at 01:56, Eddie Cai <eddie.cai.linux@gmail.com> wrote:
>> this patch enable rockusb support on rk3288 based device.
>>
>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> ---
>>  include/configs/rk3288_common.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>
> I think this should be done in Kconfig.
since rockusb used so widely on rockchip soc based devices. every
rockchip soc based
device should support it. So I would like to put it in rk3288_common.h
or even rockchip-common.h.
what do you think?
>
>>
>> diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
>> index b5606d4..b19a34d 100644
>> --- a/include/configs/rk3288_common.h
>> +++ b/include/configs/rk3288_common.h
>> @@ -74,6 +74,10 @@
>>  #define CONFIG_FASTBOOT_BUF_ADDR       CONFIG_SYS_LOAD_ADDR
>>  #define CONFIG_FASTBOOT_BUF_SIZE       0x08000000
>>
>> +/* rockusb  */
>> +#define CONFIG_CMD_ROCKUSB
>> +#define CONFIG_USB_FUNCTION_ROCKUSB
>> +
>>  /* usb mass storage */
>>  #define CONFIG_USB_FUNCTION_MASS_STORAGE
>>  #define CONFIG_CMD_USB_MASS_STORAGE
>> --
>> 2.7.4
>>
>
> Regards,
> Simon