From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <746291609.ssvjv54Vin@phil> References: <20170418121527.3155-1-eddie.cai.linux@gmail.com> <746291609.ssvjv54Vin@phil> From: Eddie Cai Date: Wed, 19 Apr 2017 08:40:42 +0800 Message-ID: Subject: Re: [PATCH] ARM: dts: rockchip: reuse firefly dtsi Content-Type: multipart/alternative; boundary=001a11430eaa3d4d2f054d7a4643 To: Heiko Stuebner Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: --001a11430eaa3d4d2f054d7a4643 Content-Type: text/plain; charset=UTF-8 2017-04-19 6:20 GMT+08:00 Heiko Stuebner : > Hi Eddie, > > Am Dienstag, 18. April 2017, 20:15:27 CEST schrieb Eddie Cai: > > firefly reload is very similar with firefly board, so reuse firefly dtsi > > > > Signed-off-by: Eddie Cai > > --- > > arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 310 > ------------------ > > arch/arm/boot/dts/rk3288-firefly-reload.dts | 368 > ++-------------------- > > I would disagree and remember having a similar discussion when the reload- > support was initially submitted. Please keep in mind that the firefly- > reload is a som+baseboard combination, so somebody could (or maybe > already has) create a completely different baseboard for the som that > does not have any similarities with the original firefly. > The previous firefly being a real single board. > We also don't combine rock2 and firefly and other boards following the > general rk3288 design guidelines :-) and the original firefly and reload > are > very different boards if you look at them. > OK, i think the real similar part is the core board and firefly. how about reuse the firefly code in the core board? > > > Heiko > > --001a11430eaa3d4d2f054d7a4643 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

2017-04-19 6:20 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:

Hi Eddie,

Am Dienstag, 18. April 2017, 20:15:27 CEST schrieb Eddie Cai:
> firefly reload is very similar with firefly board, so reuse firefly dt= si
>
> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> ---
>=C2=A0 arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 310 ---= ---------------
>=C2=A0 arch/arm/boot/dts/rk3288-firefly-reload.dts=C2=A0 =C2=A0 = =C2=A0 =C2=A0| 368 ++--------------------

I would disagree and remember having a similar discussion when the r= eload-
support was initially submitted. Please keep in mind that the firefly-
reload is a som+baseboard combination, so somebody could (or maybe
already has) create a completely different baseboard for the som that
does not have any similarities with the original firefly.
The previous firefly being a real single board.

We also don't combine rock2 and firefly and other boards following the<= br> general rk3288 design guidelines :-) and the original firefly and reload ar= e
very different boards if you look at them.

OK, i think= the real similar part is the core board and firefly. how about reuse the= =C2=A0

firefly code in the core board?

Heiko

--001a11430eaa3d4d2f054d7a4643--