From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B288C4321E for ; Sun, 4 Dec 2022 14:38:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C09F760BAB; Sun, 4 Dec 2022 14:38:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C09F760BAB Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=solid-run-com.20210112.gappssmtp.com header.i=@solid-run-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=pPGEMfey X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1FFNTtWvL6Mh; Sun, 4 Dec 2022 14:38:08 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 40B0460AC1; Sun, 4 Dec 2022 14:38:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 40B0460AC1 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1D725C0033; Sun, 4 Dec 2022 14:38:07 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id DE4E7C002D for ; Sun, 4 Dec 2022 14:38:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B8E8C8176F for ; Sun, 4 Dec 2022 14:38:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B8E8C8176F Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=solid-run-com.20210112.gappssmtp.com header.i=@solid-run-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=pPGEMfey X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vs0SquDTZQzb for ; Sun, 4 Dec 2022 14:38:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ED9108176D Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by smtp1.osuosl.org (Postfix) with ESMTPS id ED9108176D for ; Sun, 4 Dec 2022 14:38:04 +0000 (UTC) Received: by mail-il1-x136.google.com with SMTP id g7so4074771ile.0 for ; Sun, 04 Dec 2022 06:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3ht+PFif9npJV8ar+ODGKMWqVb38BYWmSXzGf8Bql7o=; b=pPGEMfeyBvZrG0hTpf1s6ITxgBrJospjOIzVZS5Z/h73xQKsco6dl+e1LC/hk03vfg CYMZxfE+3i2HYg/abEcBi2PWlF7XDK8DOVG7k7EdL6qjfyAm5Znslvf4lHpOH9jKTW57 4vZZ6gPdX56jhSX4Gu6+SkV6nSsQ2S1nEsh7GrRV/p97qZm/RRYR3eHrmS5BH/gujndy caS/Eyd0Xucm3FfoYcUw90BMOP+4uhhcZXFn1hufxpDbvRlfh3eNeOUS3aX1yA9825DE QQF1WULRaAwsgIWCCyBlC9A3jF8g7B6FZGdqeqsphLggrHQ3LlIxvdENwYy2oCk8NntE WfSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3ht+PFif9npJV8ar+ODGKMWqVb38BYWmSXzGf8Bql7o=; b=LBnTKQXVF+JGFYXsfd4D1z1txD0lGg/8e3B7UixVdAuWISrOjS8sXlxHAD+XqC8xnD BJS2kB8q756MRRjhAloN5sL+6gM279QQ59yvb0HgLOHUs2wT7CWcQWedD3QvrMXz4sXL hfamycWUoKA23N51wZu/z5tEfbvSVkiBmVJE4afPNj5QDld4nJvXzwwSGXRIWRzlG25w TXMNlrLCHR9lRax9pZH/RhlQ7xv+KIiZ4FKjKAgcGQ0Ejz9ogwKk1TJHfgdj/0lbcEtj /8GegtlKlQNj7RAsYZg6ZvEBNNBA8cXRlrJExGlXiwiwU5goGE8IDqefbY/JAsu8ml8L +QPA== X-Gm-Message-State: ANoB5pn1t06pFJCfIFnnx0BwBFdos/Q0lJu/ha9eWffCcdfo1Gw/pDRO oA7Q3DCdyxmqF3blsTDmabIKsXXEcrweHznFNW8puA== X-Google-Smtp-Source: AA0mqf6U6+Jlzl442PaUjNl6FqidwJuqolKD1dsRvBbSalz+iI+E0a5nBfwTUdXpiGNKivAXiZDkBqyKcdYosPR+9s8= X-Received: by 2002:a92:dc8b:0:b0:302:4c01:2d2b with SMTP id c11-20020a92dc8b000000b003024c012d2bmr24967282iln.2.1670164683859; Sun, 04 Dec 2022 06:38:03 -0800 (PST) MIME-Version: 1.0 References: <20221124013830-mutt-send-email-mst@kernel.org> <20221129001239-mutt-send-email-mst@kernel.org> <20221204055044-mutt-send-email-mst@kernel.org> <20221204072703-mutt-send-email-mst@kernel.org> In-Reply-To: <20221204072703-mutt-send-email-mst@kernel.org> From: Alvaro Karsz Date: Sun, 4 Dec 2022 16:37:28 +0200 Message-ID: Subject: Re: [PATCH v2] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support To: "Michael S. Tsirkin" Cc: Jens Axboe , Paolo Bonzini , Chaitanya Kulkarni , Stefan Hajnoczi , "virtualization@lists.linux-foundation.org" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" > And now is this generic enough to disconnect from virtio and > make it a generic blk thing? It could be generic enough if we drop the virtio structs and pass single fields as elements. The point is, we can easily make it generic enough, do we want to? At the moment, there is at least 1 existing device-specific ioctl to retrieve lifetime info (that I'm aware of), MMC_IOC_CMD for a MMC device with MMC_SEND_EXT_CSD opcode. So we will have duplication for MMC devices (for some of the lifetime fields). Do you want it to be blk generic? Alvaro _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization