From: Alvaro Karsz <alvaro.karsz@solid-run.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtio-comment@lists.oasis-open.org,
Rabeeh Khoury <rabeeh@solid-run.com>
Subject: Re: [virtio-comment] [PATCH v3] Introduction of Virtio Network device notifications coalescing feature.
Date: Thu, 26 May 2022 17:47:45 +0300 [thread overview]
Message-ID: <CAJs=3_BX+AEdOxNYD=KGHWHn11G=a6+_40Rk6CJnFk1fJAnyMQ@mail.gmail.com> (raw)
In-Reply-To: <CAJs=3_Bd8GZt1X4bjFnqT_c=cG6s0bg-prbtj0NZoMKAARDttw@mail.gmail.com>
After some more thought, I'm not sure that the notifications
coalescing feature can work if VIRTIO_F_EVENT_IDX is negotiated.
Quoting Virtio Spec:
> Note: For example, if used_event is 0, then a device using VIRTIO_F_EVENT_IDX would send a used buffer notification to the driver after the first buffer is used (and again after the 65536th buffer, etc).
So, if the driver sets the event index to #X and doesn't change the
value after receiving the notification, it is meaningless to use the
interrupt coalescing parameters. since it will anyway receive a
notification every 65536 packets (uint16_t overflow).
I'm thinking of adding a constraint that the driver MUST NOT accept
this feature if VIRTIO_F_EVENT_IDX is offered by the device.
What do you think?
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2022-05-26 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 8:45 [virtio-comment] [PATCH v3] Introduction of Virtio Network device notifications coalescing feature Alvaro Karsz
2022-05-22 9:03 ` [virtio-comment] " Alvaro Karsz
2022-05-26 9:36 ` [virtio-comment] " Jason Wang
2022-05-26 14:16 ` Alvaro Karsz
2022-05-26 14:47 ` Alvaro Karsz [this message]
2022-05-30 3:37 ` Jason Wang
2022-05-30 7:21 ` Alvaro Karsz
2022-05-31 4:35 ` Jason Wang
2022-05-31 7:01 ` Alvaro Karsz
2022-06-01 3:19 ` Jason Wang
2022-06-01 5:57 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJs=3_BX+AEdOxNYD=KGHWHn11G=a6+_40Rk6CJnFk1fJAnyMQ@mail.gmail.com' \
--to=alvaro.karsz@solid-run.com \
--cc=jasowang@redhat.com \
--cc=rabeeh@solid-run.com \
--cc=virtio-comment@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.