From: Alvaro Karsz <alvaro.karsz@solid-run.com>
To: Hannes Reinecke <hare@suse.de>
Cc: virtualization <virtualization@lists.linux-foundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: Virtio-net - add timeouts to control commands
Date: Wed, 24 Aug 2022 13:31:48 +0300 [thread overview]
Message-ID: <CAJs=3_BghDrTikawORaSwoJZYq_E-39zBqzuLEP2LTYaSWsKWw@mail.gmail.com> (raw)
In-Reply-To: <f0406458-319d-129b-655f-11343d99743d@suse.de>
> No. The server may only assume that the command failed until it gets the
> response for the abort command.
> Before that the state of the command is undefined, and the server may
> not assume anything here.
You're right, but the device will think that the command succeeded, so
it may send packets in a queue that is not expected by the server.
I'm referring to the VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET command.
Don't you think that as a quick fix, adding a big enough timeout is an
adequate solution (for virtio net control commands)?
The big timeout ensures that when the control command is not answered,
it is because of some crash/bug in the network device (which acts as
the hypervisor).
This way, we can detect the crash/bug and reset/remove the device.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-08-24 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 7:51 Virtio-net - add timeouts to control commands Alvaro Karsz
2022-08-24 9:06 ` Jason Wang
2022-08-24 9:16 ` Alvaro Karsz
2022-08-24 9:24 ` Hannes Reinecke
2022-08-24 9:48 ` Alvaro Karsz
2022-08-25 2:27 ` Jason Wang
2022-08-24 9:21 ` Hannes Reinecke
2022-08-24 9:42 ` Alvaro Karsz
2022-08-24 10:19 ` Hannes Reinecke
2022-08-24 10:31 ` Alvaro Karsz [this message]
2022-08-25 3:01 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJs=3_BghDrTikawORaSwoJZYq_E-39zBqzuLEP2LTYaSWsKWw@mail.gmail.com' \
--to=alvaro.karsz@solid-run.com \
--cc=hare@suse.de \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.