From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB137C433FE for ; Wed, 5 Oct 2022 04:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229379AbiJEECW (ORCPT ); Wed, 5 Oct 2022 00:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiJEECV (ORCPT ); Wed, 5 Oct 2022 00:02:21 -0400 Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D0D738A15; Tue, 4 Oct 2022 21:02:20 -0700 (PDT) Received: by mail-oo1-xc2b.google.com with SMTP id r15-20020a4abf0f000000b004761c7e6be1so10079242oop.9; Tue, 04 Oct 2022 21:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=4Na1g4Yf3ptBeqMqg3ahTZjpb1WV+bqLk+OAmb33/RI=; b=RCoMsZgqwdFRC4RVrJW+5m+g48ojGbp+nif+fIy1rNtt9aJ7Vnb4OkgyYF18jPoHh6 o6D+zUFj9s7wkuUP6Y0wJvEC1573HqpcBpPEPnVU32qh/rYFo5cgeJrZ0Y0/LQ7OlHrA P7k+sQMlx7v73QzDwFCoI9cxp94DmHZN8ac9y6pFF3sNqRP38JABiGVn7a+QJPPvSYOk iRk/pFTdnevdsvSI1L+ZBRTWRORHozzNo+RUS4Lo5w97X6wCX98/809AW1qaG0OWgwc+ CDQstMDuSWBBAMuKvyPx9gQ9mlJORPeNzrYZIY2Pceuiv0lbSV6HqiLwZPWQnDFRxLuF jVkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=4Na1g4Yf3ptBeqMqg3ahTZjpb1WV+bqLk+OAmb33/RI=; b=E714Mt8KZS7HEoWn4QmCeUL4VDrPa/9rHTAQu+9gsl7RMlljZxRSG5kgnXNkfSNiw3 t9KVV9U7Ttmk1OXPuBnX2Od4TkJnVps0xW6YQKd4SnTPPl6gg5+8A/4hos7dcNNZKx7P dHX7E7p1yzwXryo+QiSVca8BTYkxHKdSGvZylkUhad6TBJ5f0vUZeIEhLjqQtDOSZix9 MdG8lhHdqSVt1dD/go1j8U3pbZdxb6dqD8zB9ZuAuvlOtCQuJyegorZNjyMpqauXMdVH GJ03GFIuJD8sYNoBo0SJyS8Otq2J4MfKST7H0QcLQjU7Is6Kje/E3Z4EOrQnYI00ZBZc I0KA== X-Gm-Message-State: ACrzQf1N4vvZnTTHE84dWXen2e4NMd2QxtUru6Kq7uZQnv23EKxqaU4q /yQAAB5joCR/sQuGMjY58UG2KgnfB3FUtLlQdWA= X-Google-Smtp-Source: AMsMyM5RFvMMV8el79b9Zf5X69Z9wmc0C3+OXWwbIPrvCWAdz1rgMCIG1AQ8BqNMPN1quoS9GpMCwwkTCVQSA6nkcD4= X-Received: by 2002:a05:6820:1888:b0:476:1d00:9d8f with SMTP id bm8-20020a056820188800b004761d009d8fmr10519131oob.98.1664942539962; Tue, 04 Oct 2022 21:02:19 -0700 (PDT) MIME-Version: 1.0 References: <20221004103341.12646-1-jirislaby@kernel.org> In-Reply-To: From: Chuanhong Guo Date: Wed, 5 Oct 2022 12:02:08 +0800 Message-ID: Subject: Re: [PATCH 1/2] ACPI: resource: do IRQ override on LENOVO IdeaPad To: "Limonciello, Mario" Cc: "Jiri Slaby (SUSE)" , "rafael.j.wysocki@intel.com" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , Len Brown , "linux-acpi@vger.kernel.org" , Tighe Donnelly , Fridrich Strba Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi! On Wed, Oct 5, 2022 at 5:02 AM Limonciello, Mario wrote: > [...] > > > > White-list this specific model in the override_table. > > > > For this to work, the ZEN test needs to be put below the table walk. > > Unfortunately this is the second case that popped up very recently. > Another one is listed here: > https://bugzilla.kernel.org/show_bug.cgi?id=216552 Now I'm really curious how Windows is able to handle all these vendor crap... > I don't think we have a good solution to cover the intersection of these bugs. The > existing heuristic to look at legacy syntax and the IOAPIC doesn't work properly > on all the Lenovo and ASUS Ryzen 6000 systems, but it does on these other two. These legacy IRQ declarations are obsolete, but they aren't really wrong. Meanwhile the two devices popped up until now both got IRQ declarations which don't match the actual device configuration. > We're going to be adding more to this table either way. I /suspect/ the better solution > is to revert 37c81d9f1d1b and add to the table all those that are broken. I think we should have a list of only the wrong IRQ declaration and apply the fix just for them, instead of applying the fix to all devices and skip it for selected devices the fix breaks. -- Regards, Chuanhong Guo