From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F00E1C7619D for ; Wed, 19 Feb 2020 23:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3180206A5 for ; Wed, 19 Feb 2020 23:58:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KU1uqUYV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbgBSX6T (ORCPT ); Wed, 19 Feb 2020 18:58:19 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:40141 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbgBSX6T (ORCPT ); Wed, 19 Feb 2020 18:58:19 -0500 Received: by mail-oi1-f195.google.com with SMTP id a142so25705086oii.7; Wed, 19 Feb 2020 15:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=KU1uqUYVxkoQfS26YEi+ztZu7uQD6NmCYAjnD4WbMrS3FbUgBPMQxL4cToOQRD6Uov nHqZX7QwUxnmIRKEcKaP8NEsh/58I2e78+wWxDrpu1BXApMDiJMolk2hwg9CzqcOf9sW YE4tYRCZaEyh/x1674lcZY1l/H0F0ArPvwmZIxON3DfEjagSV1uN/AxJKPXKBeA241xL WqwyGwfYPVg0aO9XUojnJGQxro+u25NEoqXrbNR09NiA6eBYzNO4I80Q2dLPiRbdLZkb 04tkTaqeTm6+rrMCyLbyFF+HCBtuFvxa0v0YSX5dAdbBWko9TEenvJpgjmfSY9CevQ+/ hitw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=M/VKtYr5IUMKwGD5odp0XvHvaoe8o3lESFzKYG/iV6lwy8S7p3dq+jrdlt5Ef71VT9 yMuM7Xb683bDcg6i+VnR+pfPJfXq391UVdiZQDnjn+/MRArlIdLJeh6qErvA3983LPud vBcz4FDJLqP7zmqb6r6U18o05NFCtlX3MVMjxWEv+bS/8L+dvZFkvQOJgzugwOjMhA3V gXJxcZRcHmcozN/9D9WxHlsvo0H2Tsy8nF5Dqa0A2qftHA7KNgVPsarsX9PV0RBt/mW5 yWF7eNPP9kEGjwWyTWqlMQtWcB3ulG3cV1AeKpX82boBIyxTjGU56HohsLBZN59iWIsd pA3g== X-Gm-Message-State: APjAAAVAGhtbVde3ljRursK6Ova5VxM0tbgd8SJAuYAz++mPCDY0s0Wo 6avAN6w5llkezO2tQg7Rin2FwtNnZ2fTi4GHEM4= X-Google-Smtp-Source: APXvYqwRxzwlvasanDAZCzqmiAcIi+8du+kTb0XmBWuXgm+lcYoRDBqJdLFMRLpwiKeOks5taARgUtmAle4aHBvqjI0= X-Received: by 2002:aca:ddc2:: with SMTP id u185mr185041oig.24.1582156697455; Wed, 19 Feb 2020 15:58:17 -0800 (PST) MIME-Version: 1.0 References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> In-Reply-To: <20200218125557.GD4232@sirena.org.uk> From: Chuanhong Guo Date: Thu, 20 Feb 2020 07:58:06 +0800 Message-ID: Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem To: Mark Brown Cc: linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Mark Rutland , Matthias Brugger , linux-arm-kernel@lists.infradead.org, open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > This is an ABI break so you shouldn't be doing this, if the existing > binding works it should continue to work. The missing spi-max-frequency is the only part preventing old device tree to work with this driver. If the goal is to make existing dt binding work, I could patch dt using of_add_property in v2. I saw similar device tree patching for legacy bindings in pinctrl-single driver. > > > 3. removing the old driver. I'll create this commit after 1 and 2 are > > applied to avoid possible rebasing due to any changes in the old > > driver. > > This isn't great as it means we have a period with two drivers for the > same thing in tree which is at best going to be confusing. There's no > advantage to splitting this out. Got it. I'll add this patch in v2. -- Regards, Chuanhong Guo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chuanhong Guo Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Date: Thu, 20 Feb 2020 07:58:06 +0800 Message-ID: References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Mark Rutland , Matthias Brugger , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, open list To: Mark Brown Return-path: In-Reply-To: <20200218125557.GD4232-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi! On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > This is an ABI break so you shouldn't be doing this, if the existing > binding works it should continue to work. The missing spi-max-frequency is the only part preventing old device tree to work with this driver. If the goal is to make existing dt binding work, I could patch dt using of_add_property in v2. I saw similar device tree patching for legacy bindings in pinctrl-single driver. > > > 3. removing the old driver. I'll create this commit after 1 and 2 are > > applied to avoid possible rebasing due to any changes in the old > > driver. > > This isn't great as it means we have a period with two drivers for the > same thing in tree which is at best going to be confusing. There's no > advantage to splitting this out. Got it. I'll add this patch in v2. -- Regards, Chuanhong Guo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23858C5ACC4 for ; Wed, 19 Feb 2020 23:58:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E679B206A5 for ; Wed, 19 Feb 2020 23:58:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KJagZT4d"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KU1uqUYV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E679B206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=byfrId2CcrP71Vg8KSW0VPKWbvWi7QtkzD7BUWUcmcE=; b=KJagZT4dYjTC+R pMiw7ufv99XqLgVbkP2yJCvlquphjRF7P6bZ3qbE3uP+CxWNYDLC32HZJD1kc1bpD9Llqcz3IB2uA T7AY5+AYXqlu0CLLg+wP6FYfQlaIr3FqsbKvAKfSc3Rvfh40dGg5X6NbtYE9Q52T4L5TkPortToIw jxWnAoIbX5Hzc15XvI0HKwsM28+z45FYqYRWkRmdjZm6UxOxjqFv6LOvIan9Qwq1GskJ71vDir15U HcSrd9Pq1vqGD2km7yGdGh9X3pNMKFRdHY/kSvs3Cq2TBYgPZhC9VfDcjbwR+6ou/ebPxkRtcWcAZ JZhC+UjrkT5/eiAlySlw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4ZEU-0004vZ-D4; Wed, 19 Feb 2020 23:58:22 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4ZER-0004uF-5F; Wed, 19 Feb 2020 23:58:20 +0000 Received: by mail-oi1-x241.google.com with SMTP id c16so25737794oic.3; Wed, 19 Feb 2020 15:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=KU1uqUYVxkoQfS26YEi+ztZu7uQD6NmCYAjnD4WbMrS3FbUgBPMQxL4cToOQRD6Uov nHqZX7QwUxnmIRKEcKaP8NEsh/58I2e78+wWxDrpu1BXApMDiJMolk2hwg9CzqcOf9sW YE4tYRCZaEyh/x1674lcZY1l/H0F0ArPvwmZIxON3DfEjagSV1uN/AxJKPXKBeA241xL WqwyGwfYPVg0aO9XUojnJGQxro+u25NEoqXrbNR09NiA6eBYzNO4I80Q2dLPiRbdLZkb 04tkTaqeTm6+rrMCyLbyFF+HCBtuFvxa0v0YSX5dAdbBWko9TEenvJpgjmfSY9CevQ+/ hitw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=uaHmbNI+fHWgYYRGZ/vrLituSI6l2iSFLq4EwM5G1NMTrrH1o0mvO2mn5kyOzE/26h 1J27xxEyThzRnUzlbkn4d8+E2m6Tj53sidS9dT6hbWkX+FdLdgYsVbPXC5MysvkFZ9aZ +8fYXM7BnfrvGduD7cv4qkePBj4f4dLngNssUGMA5cf1EHc7WEzPCqCqzFmrG7dVOe56 VMKT+LyXLd+mcrrlLG3ZdQIewwmNC0XniR3l2CNav2mj72a+7rEON7OtBmu/3rxsTTYt blkEoQhwNF9hNiKUnHWTQhAK1VVpiWIMaML6KrD5xfzOhcd8zYu75IZEiH5qckVCrY5Q /Z+w== X-Gm-Message-State: APjAAAXQrA9GZR/2Bt6syu/PJkJRc0Za0Mpjrg9s9S6IPUtdZCHiv54w VWpoHI0CACsZBK5hLhvt1FZBQoPQZOfCEss5N1w= X-Google-Smtp-Source: APXvYqwRxzwlvasanDAZCzqmiAcIi+8du+kTb0XmBWuXgm+lcYoRDBqJdLFMRLpwiKeOks5taARgUtmAle4aHBvqjI0= X-Received: by 2002:aca:ddc2:: with SMTP id u185mr185041oig.24.1582156697455; Wed, 19 Feb 2020 15:58:17 -0800 (PST) MIME-Version: 1.0 References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> In-Reply-To: <20200218125557.GD4232@sirena.org.uk> From: Chuanhong Guo Date: Thu, 20 Feb 2020 07:58:06 +0800 Message-ID: Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_155819_225081_D5BA6EAD X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Vignesh Raghavendra , Richard Weinberger , open list , linux-spi@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi! On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > This is an ABI break so you shouldn't be doing this, if the existing > binding works it should continue to work. The missing spi-max-frequency is the only part preventing old device tree to work with this driver. If the goal is to make existing dt binding work, I could patch dt using of_add_property in v2. I saw similar device tree patching for legacy bindings in pinctrl-single driver. > > > 3. removing the old driver. I'll create this commit after 1 and 2 are > > applied to avoid possible rebasing due to any changes in the old > > driver. > > This isn't great as it means we have a period with two drivers for the > same thing in tree which is at best going to be confusing. There's no > advantage to splitting this out. Got it. I'll add this patch in v2. -- Regards, Chuanhong Guo ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80E9C7619D for ; Wed, 19 Feb 2020 23:58:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DD6B24656 for ; Wed, 19 Feb 2020 23:58:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KuT5s1ci"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KU1uqUYV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DD6B24656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oIvxcDICY/z6IvD68s4jl+wzn0BQgVSLRy+OxJRgrnM=; b=KuT5s1ci1wWpdZ YaH1vqDPC6hpHws7pX7KMG7dB5VibOKc9h6Jayx1mPAPV6afoBwR4U7/rCI8VMUh+amXXTdySNOqa EKnzVEo8qB5957TFyOnkvXPzknKdgry3TEFAVeVE7VSg3bbUC14ah+Z7K+QgFFLaVf0vtRRwYiTRC +jJFnuDvMMXt+swr2kBHBcK07WEXbQEvEIDPqAprCwmUGJMSwAMow7tjtRX4pHTiLA0wnWnyDwIrd wvRm1NxnBfNVH5Qs0fRus/Yn4OoAoy1kWq0gLTNEBjTWEv2hFQCr62MlTN5PsOIzxT6E8qg+Hp6XC bWc1y87zQqPvwXWJWASg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4ZET-0004un-MX; Wed, 19 Feb 2020 23:58:21 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4ZER-0004uF-5F; Wed, 19 Feb 2020 23:58:20 +0000 Received: by mail-oi1-x241.google.com with SMTP id c16so25737794oic.3; Wed, 19 Feb 2020 15:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=KU1uqUYVxkoQfS26YEi+ztZu7uQD6NmCYAjnD4WbMrS3FbUgBPMQxL4cToOQRD6Uov nHqZX7QwUxnmIRKEcKaP8NEsh/58I2e78+wWxDrpu1BXApMDiJMolk2hwg9CzqcOf9sW YE4tYRCZaEyh/x1674lcZY1l/H0F0ArPvwmZIxON3DfEjagSV1uN/AxJKPXKBeA241xL WqwyGwfYPVg0aO9XUojnJGQxro+u25NEoqXrbNR09NiA6eBYzNO4I80Q2dLPiRbdLZkb 04tkTaqeTm6+rrMCyLbyFF+HCBtuFvxa0v0YSX5dAdbBWko9TEenvJpgjmfSY9CevQ+/ hitw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=uaHmbNI+fHWgYYRGZ/vrLituSI6l2iSFLq4EwM5G1NMTrrH1o0mvO2mn5kyOzE/26h 1J27xxEyThzRnUzlbkn4d8+E2m6Tj53sidS9dT6hbWkX+FdLdgYsVbPXC5MysvkFZ9aZ +8fYXM7BnfrvGduD7cv4qkePBj4f4dLngNssUGMA5cf1EHc7WEzPCqCqzFmrG7dVOe56 VMKT+LyXLd+mcrrlLG3ZdQIewwmNC0XniR3l2CNav2mj72a+7rEON7OtBmu/3rxsTTYt blkEoQhwNF9hNiKUnHWTQhAK1VVpiWIMaML6KrD5xfzOhcd8zYu75IZEiH5qckVCrY5Q /Z+w== X-Gm-Message-State: APjAAAXQrA9GZR/2Bt6syu/PJkJRc0Za0Mpjrg9s9S6IPUtdZCHiv54w VWpoHI0CACsZBK5hLhvt1FZBQoPQZOfCEss5N1w= X-Google-Smtp-Source: APXvYqwRxzwlvasanDAZCzqmiAcIi+8du+kTb0XmBWuXgm+lcYoRDBqJdLFMRLpwiKeOks5taARgUtmAle4aHBvqjI0= X-Received: by 2002:aca:ddc2:: with SMTP id u185mr185041oig.24.1582156697455; Wed, 19 Feb 2020 15:58:17 -0800 (PST) MIME-Version: 1.0 References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> In-Reply-To: <20200218125557.GD4232@sirena.org.uk> From: Chuanhong Guo Date: Thu, 20 Feb 2020 07:58:06 +0800 Message-ID: Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_155819_225081_D5BA6EAD X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Vignesh Raghavendra , Richard Weinberger , open list , linux-spi@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi! On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > This is an ABI break so you shouldn't be doing this, if the existing > binding works it should continue to work. The missing spi-max-frequency is the only part preventing old device tree to work with this driver. If the goal is to make existing dt binding work, I could patch dt using of_add_property in v2. I saw similar device tree patching for legacy bindings in pinctrl-single driver. > > > 3. removing the old driver. I'll create this commit after 1 and 2 are > > applied to avoid possible rebasing due to any changes in the old > > driver. > > This isn't great as it means we have a period with two drivers for the > same thing in tree which is at best going to be confusing. There's no > advantage to splitting this out. Got it. I'll add this patch in v2. -- Regards, Chuanhong Guo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF2FC7619D for ; Wed, 19 Feb 2020 23:58:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7648206A5 for ; Wed, 19 Feb 2020 23:58:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V+6D1PEK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KU1uqUYV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7648206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7nO3ErE5zW0iDGrXkYA7QnKLOge76rG5LxvgJV0Hrtg=; b=V+6D1PEKDPCUdC d0KMXHfxLbgCJgYQ8y6U0L6V2nnDG3G6ilPcEIufEDyrJBD6ok8pmZLbx+bMPRSqFEwGYqtjENlqa hFzbPDwCuyGRjQYiTGyhChCfBIov0Oc13P5mVYCTZlsd50Mh4RDjy5lfgjMMzBdT99KwJsBIkZ/Qh tkjyxd8qIFYny+vXw30RAytuDyjn+wWBCh96v2FT9xhFHnrGKB6np3uCcNtRrQeKwyPm0fXpGypfU yokj0UREjhKLi720kGOVNQHeC0aeOR7ySKCTfgKEHrA0ICR0Rm11UWiM2zaJ7Gp1sgSKR0qrQFbS3 MfsqSktcjDU/XO48i9aA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4ZEg-00055y-Db; Wed, 19 Feb 2020 23:58:34 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4ZER-0004uF-5F; Wed, 19 Feb 2020 23:58:20 +0000 Received: by mail-oi1-x241.google.com with SMTP id c16so25737794oic.3; Wed, 19 Feb 2020 15:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=KU1uqUYVxkoQfS26YEi+ztZu7uQD6NmCYAjnD4WbMrS3FbUgBPMQxL4cToOQRD6Uov nHqZX7QwUxnmIRKEcKaP8NEsh/58I2e78+wWxDrpu1BXApMDiJMolk2hwg9CzqcOf9sW YE4tYRCZaEyh/x1674lcZY1l/H0F0ArPvwmZIxON3DfEjagSV1uN/AxJKPXKBeA241xL WqwyGwfYPVg0aO9XUojnJGQxro+u25NEoqXrbNR09NiA6eBYzNO4I80Q2dLPiRbdLZkb 04tkTaqeTm6+rrMCyLbyFF+HCBtuFvxa0v0YSX5dAdbBWko9TEenvJpgjmfSY9CevQ+/ hitw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BX9+oiU9NUzGK1+aV9/Uah0G+lhW9/DtCwBAHxWnn3I=; b=uaHmbNI+fHWgYYRGZ/vrLituSI6l2iSFLq4EwM5G1NMTrrH1o0mvO2mn5kyOzE/26h 1J27xxEyThzRnUzlbkn4d8+E2m6Tj53sidS9dT6hbWkX+FdLdgYsVbPXC5MysvkFZ9aZ +8fYXM7BnfrvGduD7cv4qkePBj4f4dLngNssUGMA5cf1EHc7WEzPCqCqzFmrG7dVOe56 VMKT+LyXLd+mcrrlLG3ZdQIewwmNC0XniR3l2CNav2mj72a+7rEON7OtBmu/3rxsTTYt blkEoQhwNF9hNiKUnHWTQhAK1VVpiWIMaML6KrD5xfzOhcd8zYu75IZEiH5qckVCrY5Q /Z+w== X-Gm-Message-State: APjAAAXQrA9GZR/2Bt6syu/PJkJRc0Za0Mpjrg9s9S6IPUtdZCHiv54w VWpoHI0CACsZBK5hLhvt1FZBQoPQZOfCEss5N1w= X-Google-Smtp-Source: APXvYqwRxzwlvasanDAZCzqmiAcIi+8du+kTb0XmBWuXgm+lcYoRDBqJdLFMRLpwiKeOks5taARgUtmAle4aHBvqjI0= X-Received: by 2002:aca:ddc2:: with SMTP id u185mr185041oig.24.1582156697455; Wed, 19 Feb 2020 15:58:17 -0800 (PST) MIME-Version: 1.0 References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> In-Reply-To: <20200218125557.GD4232@sirena.org.uk> From: Chuanhong Guo Date: Thu, 20 Feb 2020 07:58:06 +0800 Message-ID: Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_155819_225081_D5BA6EAD X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Vignesh Raghavendra , Richard Weinberger , open list , linux-spi@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > This is an ABI break so you shouldn't be doing this, if the existing > binding works it should continue to work. The missing spi-max-frequency is the only part preventing old device tree to work with this driver. If the goal is to make existing dt binding work, I could patch dt using of_add_property in v2. I saw similar device tree patching for legacy bindings in pinctrl-single driver. > > > 3. removing the old driver. I'll create this commit after 1 and 2 are > > applied to avoid possible rebasing due to any changes in the old > > driver. > > This isn't great as it means we have a period with two drivers for the > same thing in tree which is at best going to be confusing. There's no > advantage to splitting this out. Got it. I'll add this patch in v2. -- Regards, Chuanhong Guo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel