From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E63C5DF60 for ; Fri, 8 Nov 2019 02:03:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5E0321882 for ; Fri, 8 Nov 2019 02:03:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IgoQ4CLe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbfKHCDf (ORCPT ); Thu, 7 Nov 2019 21:03:35 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:33292 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbfKHCDf (ORCPT ); Thu, 7 Nov 2019 21:03:35 -0500 Received: by mail-il1-f193.google.com with SMTP id m5so3739601ilq.0 for ; Thu, 07 Nov 2019 18:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rb7E4G3AfRv3BBvojQNjoB9UPjH1AyXc4p/SxsSL9W4=; b=IgoQ4CLeR5KSemdl8EH4Mv7SW5YfL/GAg/l1KhpuG8A/axs8uQnarKuxoDx6hd6iQG FsKC8qZR8md/Xc/sMEb0TgU7cYRUSq3Kg1zNXn2/d9L4Nn8slVxXisf0nqJOJxShSe27 9t2/w72HYCsTpM0ziXzT+tLqJOigzV/O34KlU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rb7E4G3AfRv3BBvojQNjoB9UPjH1AyXc4p/SxsSL9W4=; b=NipKBPdNicCGfjevC3TcIODiee5n1kK+4txM830IZ2ND2GUTGLSkmNHgulTSX0HjH0 OA6Zb2JicY1XUcT7mTRSBDx86oKc7Yin0g6sxTXfMDSJRxiSYXRqK2O0k6AuJPN1P1ee XOItkWER9PGlDhHwAnHke7bMZh9Yw+BSKrsYDMObNkXVfvCMZJYgqqroGdXdO+xtiLa+ pQQjKvWi0EQF5BuWqEuDvZqKwKoHtK2hjhzQn15wjWpQNk87dw4oTvW8iEj4AIj+YxjH waNU4MyztFT4bpnMafo1RjvOjl5RPc+nirjnLB8nZOD2pUQ/3DshLzihtCSdUZjCLuWu IVxA== X-Gm-Message-State: APjAAAWIb+Ao+y9Hb4V/c+Anu3HaEyQliB6o4eWUScEIJ4Ti1g/nvniW 35x7WS5WPHccpGw6rj6Y4lrEHpbFLNpP+OUMSW7/Ko1WpKM= X-Google-Smtp-Source: APXvYqwfvE0lbSsmo3rLw5QoJ6zVMyT9Wrt/mQAmklzCszTTgckYnb+UZs7Y5ORM7LCKGmCVLHGnxLClJWkwQGTwBOI= X-Received: by 2002:a92:c9c3:: with SMTP id k3mr9000230ilq.299.1573178614360; Thu, 07 Nov 2019 18:03:34 -0800 (PST) MIME-Version: 1.0 References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> <20191107111019.GA24028@onstation.org> In-Reply-To: From: Rob Clark Date: Thu, 7 Nov 2019 18:03:24 -0800 Message-ID: Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes To: Jeffrey Hugo Cc: Rob Clark , Brian Masney , freedreno , Linux Kernel Mailing List , dri-devel , linux-arm-msm , Sean Paul Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Nov 7, 2019 at 9:40 AM Jeffrey Hugo wrote: > > On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > > > > > On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote: > > > > On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo wrote: > > > > > > > > > > On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrote: > > > > > > > > > > > > On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > > > > > > > > > > > > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > > > > > > > > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > > > > > > > > The 'pp done time out' errors go away if I revert the following three > > > > > > > > > commits: > > > > > > > > > > > > > > > > > > cd6d923167b1 ("drm/msm/dpu: async commit support") > > > > > > > > > d934a712c5e6 ("drm/msm: add atomic traces") > > > > > > > > > 2d99ced787e3 ("drm/msm: async commit support") > > > > > > > > > > > > > > > > > > I reverted the first one to fix a compiler error, and the second one so > > > > > > > > > that the last patch can be reverted without any merge conflicts. > > > > > > > > > > > > > > > > > > I see that crtc_flush() calls mdp5_ctl_commit(). I tried to use > > > > > > > > > crtc_flush_all() in mdp5_flush_commit() and the contents of the frame > > > > > > > > > buffer dance around the screen like its out of sync. I renamed > > > > > > > > > crtc_flush_all() to mdp5_crtc_flush_all() and removed the static > > > > > > > > > declaration. Here's the relevant part of what I tried: > > > > > > > > > > > > > > > > > > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > > > > > > > > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > > > > > > > > @@ -171,7 +171,15 @@ static void mdp5_prepare_commit(struct msm_kms *kms, struct drm_atomic_state *st > > > > > > > > > > > > > > > > > > static void mdp5_flush_commit(struct msm_kms *kms, unsigned crtc_mask) > > > > > > > > > { > > > > > > > > > - /* TODO */ > > > > > > > > > + struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms)); > > > > > > > > > + struct drm_crtc *crtc; > > > > > > > > > + > > > > > > > > > + for_each_crtc_mask(mdp5_kms->dev, crtc, crtc_mask) { > > > > > > > > > + if (!crtc->state->active) > > > > > > > > > + continue; > > > > > > > > > + > > > > > > > > > + mdp5_crtc_flush_all(crtc); > > > > > > > > > + } > > > > > > > > > } > > > > > > > > > > > > > > > > > > Any tips would be appreciated. > > > > > > > > > > > > > > > > > > > > > > > > I think this is along the lines of what we need to enable async commit > > > > > > > > for mdp5 (but also removing the flush from the atomic-commit path).. > > > > > > > > the principle behind the async commit is to do all the atomic state > > > > > > > > commit normally, but defer writing the flush bits. This way, if you > > > > > > > > get another async update before the next vblank, you just apply it > > > > > > > > immediately instead of waiting for vblank. > > > > > > > > > > > > > > > > But I guess you are on a command mode panel, if I remember? Which is > > > > > > > > a case I didn't have a way to test. And I'm not entirely about how > > > > > > > > kms_funcs->vsync_time() should be implemented for cmd mode panels. > > > > > > > > > > > > > > Yes, this is a command-mode panel and there's no hardware frame counter > > > > > > > available. The key to getting the display working on this phone was this > > > > > > > patch: > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bab52af6fe68c43b327a57e5ce5fc10eefdfadf > > > > > > > > > > > > > > > That all said, I think we should first fix what is broken, before > > > > > > > > worrying about extending async commit support to mdp5.. which > > > > > > > > shouldn't hit the async==true path, due to not implementing > > > > > > > > kms_funcs->vsync_time(). > > > > > > > > > > > > > > > > What I think is going on is that, in the cmd mode case, > > > > > > > > mdp5_wait_flush() (indirectly) calls mdp5_crtc_wait_for_pp_done(), > > > > > > > > which waits for a pp-done irq regardless of whether there is a flush > > > > > > > > in progress. Since there is no flush pending, the irq never comes. > > > > > > > > But the expectation is that kms_funcs->wait_flush() returns > > > > > > > > immediately if there is nothing to wait for. > > > > > > > > > > > > > > I don't think that's happening in this case. I added some pr_info() > > > > > > > statements to request_pp_done_pending() and mdp5_crtc_pp_done_irq(). > > > > > > > Here's the first two sets of messages that appear in dmesg: > > > > > > > > > > > > > > [ 14.018907] msm fd900000.mdss: pp done time out, lm=0 > > > > > > > [ 14.018993] request_pp_done_pending: HERE > > > > > > > [ 14.074208] mdp5_crtc_pp_done_irq: HERE > > > > > > > [ 14.074368] Console: switching to colour frame buffer device 135x120 > > > > > > > [ 14.138938] msm fd900000.mdss: pp done time out, lm=0 > > > > > > > [ 14.139021] request_pp_done_pending: HERE > > > > > > > [ 14.158097] mdp5_crtc_pp_done_irq: HERE > > > > > > > > > > > > > > The messages go on like this with the same pattern. > > > > > > > > > > > > > > I tried two different changes: > > > > > > > > > > > > > > 1) I moved the request_pp_done_pending() and corresponding if statement > > > > > > > from mdp5_crtc_atomic_flush() and into mdp5_crtc_atomic_begin(). > > > > > > > > > > > > > > 2) I increased the timeout in wait_for_completion_timeout() by several > > > > > > > increments; all the way to 5 seconds. > > > > > > > > > > > > increasing the timeout won't help, because the pp-done irq has already > > > > > > come at the point where we wait for it.. > > > > > > > > > > > > maybe the easy thing is just add mdp5_crtc->needs_pp, set to true > > > > > > before requesting, and false when we get the irq.. and then > > > > > > mdp5_crtc_wait_for_pp_done() just returns if needs_pp==false.. > > > > > > > > > > On the otherhand, what about trying to make command mode panels > > > > > resemble video mode panels slightly? Video mode panels have a vsync > > > > > counter in hardware, which is missing from command mode - however it > > > > > seems like the driver/drm framework would prefer such a counter. > > > > > Would it be a reasonable idea to make a software counter, and just > > > > > increment it every time the pp_done irq is triggered? > > > > > > > > > > I'm just thinking that we'll avoid issues long term by trying to make > > > > > the code common, rather than diverging it for the two modes. > > > > > > > > > > > > > *possibly*, but I think we want to account somehow periods where > > > > display is not updated. > > > > > > > > fwiw, it isn't that uncommon for userspace to use vblanks to "keep > > > > time" (drive animations for desktop switch, window > > > > maximize/unmaximize, etc).. it could be a surprise when "vblank" is > > > > not periodic. > > > > > > What do you think about using some variation of the current value of > > > jiffies in the kernel + the number of pp_done IRQs as the software > > > counter for command-mode panels? > > > > > > > jiffies is probably too coarse.. but we could use monotonic clock, I guess. > > > > But I suppose even a cmd mode panel has a "vblank", it is just > > internal the panel. Do we get the TE interrupt at regular intervals? > > AFAIU this would be tied to the panel's internal vblank. > > The TE interrupt was first implemented in MDP 1.7.0 (msm8996). 8974 > predates that. > You can get it from the WR_PTR interrupt, but you have to understand > details about your panel to configure that correctly. oh, sad.. I kinda assumed it was a pretty common DSI irq since forever.. I guess the hw is just managing the flow control to prevent tearing? Well, anyways, I guess we could just use a free-running timer based on refresh rate of the panel? BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: drm/msm: 'pp done time out' errors after async commit changes Date: Thu, 7 Nov 2019 18:03:24 -0800 Message-ID: References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> <20191107111019.GA24028@onstation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeffrey Hugo Cc: Sean Paul , linux-arm-msm , Linux Kernel Mailing List , dri-devel , Rob Clark , freedreno , Brian Masney List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgNywgMjAxOSBhdCA5OjQwIEFNIEplZmZyZXkgSHVnbyA8amVmZnJleS5sLmh1 Z29AZ21haWwuY29tPiB3cm90ZToKPgo+IE9uIFRodSwgTm92IDcsIDIwMTkgYXQgOToxNyBBTSBS b2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFRodSwgTm92 IDcsIDIwMTkgYXQgMzoxMCBBTSBCcmlhbiBNYXNuZXkgPG1hc25leWJAb25zdGF0aW9uLm9yZz4g d3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFdlZCwgTm92IDA2LCAyMDE5IGF0IDA4OjU4OjU5QU0gLTA4 MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+ID4gPiBPbiBXZWQsIE5vdiA2LCAyMDE5IGF0IDg6NDcg QU0gSmVmZnJleSBIdWdvIDxqZWZmcmV5LmwuaHVnb0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+ ID4KPiA+ID4gPiA+IE9uIFdlZCwgTm92IDYsIDIwMTkgYXQgOTozMCBBTSBSb2IgQ2xhcmsgPHJv YmRjbGFya0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBPbiBXZWQs IE5vdiA2LCAyMDE5IGF0IDE6MTMgQU0gQnJpYW4gTWFzbmV5IDxtYXNuZXliQG9uc3RhdGlvbi5v cmc+IHdyb3RlOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gT24gVHVlLCBOb3YgMDUsIDIw MTkgYXQgMDg6MjM6MjdBTSAtMDgwMCwgUm9iIENsYXJrIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4g T24gVHVlLCBOb3YgNSwgMjAxOSBhdCAyOjA4IEFNIEJyaWFuIE1hc25leSA8bWFzbmV5YkBvbnN0 YXRpb24ub3JnPiB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ID4gVGhlICdwcCBkb25lIHRpbWUgb3V0 JyBlcnJvcnMgZ28gYXdheSBpZiBJIHJldmVydCB0aGUgZm9sbG93aW5nIHRocmVlCj4gPiA+ID4g PiA+ID4gPiA+IGNvbW1pdHM6Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+IGNk NmQ5MjMxNjdiMSAoImRybS9tc20vZHB1OiBhc3luYyBjb21taXQgc3VwcG9ydCIpCj4gPiA+ID4g PiA+ID4gPiA+IGQ5MzRhNzEyYzVlNiAoImRybS9tc206IGFkZCBhdG9taWMgdHJhY2VzIikKPiA+ ID4gPiA+ID4gPiA+ID4gMmQ5OWNlZDc4N2UzICgiZHJtL21zbTogYXN5bmMgY29tbWl0IHN1cHBv cnQiKQo+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBJIHJldmVydGVkIHRoZSBm aXJzdCBvbmUgdG8gZml4IGEgY29tcGlsZXIgZXJyb3IsIGFuZCB0aGUgc2Vjb25kIG9uZSBzbwo+ ID4gPiA+ID4gPiA+ID4gPiB0aGF0IHRoZSBsYXN0IHBhdGNoIGNhbiBiZSByZXZlcnRlZCB3aXRo b3V0IGFueSBtZXJnZSBjb25mbGljdHMuCj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4g PiA+IEkgc2VlIHRoYXQgY3J0Y19mbHVzaCgpIGNhbGxzIG1kcDVfY3RsX2NvbW1pdCgpLiBJIHRy aWVkIHRvIHVzZQo+ID4gPiA+ID4gPiA+ID4gPiBjcnRjX2ZsdXNoX2FsbCgpIGluIG1kcDVfZmx1 c2hfY29tbWl0KCkgYW5kIHRoZSBjb250ZW50cyBvZiB0aGUgZnJhbWUKPiA+ID4gPiA+ID4gPiA+ ID4gYnVmZmVyIGRhbmNlIGFyb3VuZCB0aGUgc2NyZWVuIGxpa2UgaXRzIG91dCBvZiBzeW5jLiBJ IHJlbmFtZWQKPiA+ID4gPiA+ID4gPiA+ID4gY3J0Y19mbHVzaF9hbGwoKSB0byBtZHA1X2NydGNf Zmx1c2hfYWxsKCkgYW5kIHJlbW92ZWQgdGhlIHN0YXRpYwo+ID4gPiA+ID4gPiA+ID4gPiBkZWNs YXJhdGlvbi4gSGVyZSdzIHRoZSByZWxldmFudCBwYXJ0IG9mIHdoYXQgSSB0cmllZDoKPiA+ID4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9k aXNwL21kcDUvbWRwNV9rbXMuYwo+ID4gPiA+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vbXNtL2Rpc3AvbWRwNS9tZHA1X2ttcy5jCj4gPiA+ID4gPiA+ID4gPiA+IEBAIC0xNzEsNyAr MTcxLDE1IEBAIHN0YXRpYyB2b2lkIG1kcDVfcHJlcGFyZV9jb21taXQoc3RydWN0IG1zbV9rbXMg Kmttcywgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+ID4gPiA+ICBzdGF0aWMgdm9pZCBtZHA1X2ZsdXNoX2NvbW1pdChzdHJ1Y3QgbXNtX2tt cyAqa21zLCB1bnNpZ25lZCBjcnRjX21hc2spCj4gPiA+ID4gPiA+ID4gPiA+ICB7Cj4gPiA+ID4g PiA+ID4gPiA+IC0gICAgICAgLyogVE9ETyAqLwo+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIHN0 cnVjdCBtZHA1X2ttcyAqbWRwNV9rbXMgPSB0b19tZHA1X2ttcyh0b19tZHBfa21zKGttcykpOwo+ ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ID4gPiA+ ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIGZvcl9lYWNoX2NydGNfbWFzayht ZHA1X2ttcy0+ZGV2LCBjcnRjLCBjcnRjX21hc2spIHsKPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAg ICAgICAgICAgIGlmICghY3J0Yy0+c3RhdGUtPmFjdGl2ZSkKPiA+ID4gPiA+ID4gPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4g PiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIG1kcDVfY3J0Y19mbHVzaF9hbGwoY3J0Yyk7Cj4g PiA+ID4gPiA+ID4gPiA+ICsgICAgICAgfQo+ID4gPiA+ID4gPiA+ID4gPiAgfQo+ID4gPiA+ID4g PiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBBbnkgdGlwcyB3b3VsZCBiZSBhcHByZWNpYXRlZC4K PiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gSSB0aGluayB0 aGlzIGlzIGFsb25nIHRoZSBsaW5lcyBvZiB3aGF0IHdlIG5lZWQgdG8gZW5hYmxlIGFzeW5jIGNv bW1pdAo+ID4gPiA+ID4gPiA+ID4gZm9yIG1kcDUgKGJ1dCBhbHNvIHJlbW92aW5nIHRoZSBmbHVz aCBmcm9tIHRoZSBhdG9taWMtY29tbWl0IHBhdGgpLi4KPiA+ID4gPiA+ID4gPiA+IHRoZSBwcmlu Y2lwbGUgYmVoaW5kIHRoZSBhc3luYyBjb21taXQgaXMgdG8gZG8gYWxsIHRoZSBhdG9taWMgc3Rh dGUKPiA+ID4gPiA+ID4gPiA+IGNvbW1pdCBub3JtYWxseSwgYnV0IGRlZmVyIHdyaXRpbmcgdGhl IGZsdXNoIGJpdHMuICBUaGlzIHdheSwgaWYgeW91Cj4gPiA+ID4gPiA+ID4gPiBnZXQgYW5vdGhl ciBhc3luYyB1cGRhdGUgYmVmb3JlIHRoZSBuZXh0IHZibGFuaywgeW91IGp1c3QgYXBwbHkgaXQK PiA+ID4gPiA+ID4gPiA+IGltbWVkaWF0ZWx5IGluc3RlYWQgb2Ygd2FpdGluZyBmb3IgdmJsYW5r Lgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IEJ1dCBJIGd1ZXNzIHlvdSBhcmUgb24g YSBjb21tYW5kIG1vZGUgcGFuZWwsIGlmIEkgcmVtZW1iZXI/ICBXaGljaCBpcwo+ID4gPiA+ID4g PiA+ID4gYSBjYXNlIEkgZGlkbid0IGhhdmUgYSB3YXkgdG8gdGVzdC4gIEFuZCBJJ20gbm90IGVu dGlyZWx5IGFib3V0IGhvdwo+ID4gPiA+ID4gPiA+ID4ga21zX2Z1bmNzLT52c3luY190aW1lKCkg c2hvdWxkIGJlIGltcGxlbWVudGVkIGZvciBjbWQgbW9kZSBwYW5lbHMuCj4gPiA+ID4gPiA+ID4K PiA+ID4gPiA+ID4gPiBZZXMsIHRoaXMgaXMgYSBjb21tYW5kLW1vZGUgcGFuZWwgYW5kIHRoZXJl J3Mgbm8gaGFyZHdhcmUgZnJhbWUgY291bnRlcgo+ID4gPiA+ID4gPiA+IGF2YWlsYWJsZS4gVGhl IGtleSB0byBnZXR0aW5nIHRoZSBkaXNwbGF5IHdvcmtpbmcgb24gdGhpcyBwaG9uZSB3YXMgdGhp cwo+ID4gPiA+ID4gPiA+IHBhdGNoOgo+ID4gPiA+ID4gPiA+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5v cmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC9jb21taXQvP2lk PTJiYWI1MmFmNmZlNjhjNDNiMzI3YTU3ZTVjZTVmYzEwZWVmZGZhZGYKPiA+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiA+ID4gVGhhdCBhbGwgc2FpZCwgSSB0aGluayB3ZSBzaG91bGQgZmlyc3QgZml4 IHdoYXQgaXMgYnJva2VuLCBiZWZvcmUKPiA+ID4gPiA+ID4gPiA+IHdvcnJ5aW5nIGFib3V0IGV4 dGVuZGluZyBhc3luYyBjb21taXQgc3VwcG9ydCB0byBtZHA1Li4gd2hpY2gKPiA+ID4gPiA+ID4g PiA+IHNob3VsZG4ndCBoaXQgdGhlIGFzeW5jPT10cnVlIHBhdGgsIGR1ZSB0byBub3QgaW1wbGVt ZW50aW5nCj4gPiA+ID4gPiA+ID4gPiBrbXNfZnVuY3MtPnZzeW5jX3RpbWUoKS4KPiA+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiBXaGF0IEkgdGhpbmsgaXMgZ29pbmcgb24gaXMgdGhhdCwg aW4gdGhlIGNtZCBtb2RlIGNhc2UsCj4gPiA+ID4gPiA+ID4gPiBtZHA1X3dhaXRfZmx1c2goKSAo aW5kaXJlY3RseSkgY2FsbHMgbWRwNV9jcnRjX3dhaXRfZm9yX3BwX2RvbmUoKSwKPiA+ID4gPiA+ ID4gPiA+IHdoaWNoIHdhaXRzIGZvciBhIHBwLWRvbmUgaXJxIHJlZ2FyZGxlc3Mgb2Ygd2hldGhl ciB0aGVyZSBpcyBhIGZsdXNoCj4gPiA+ID4gPiA+ID4gPiBpbiBwcm9ncmVzcy4gIFNpbmNlIHRo ZXJlIGlzIG5vIGZsdXNoIHBlbmRpbmcsIHRoZSBpcnEgbmV2ZXIgY29tZXMuCj4gPiA+ID4gPiA+ ID4gPiBCdXQgdGhlIGV4cGVjdGF0aW9uIGlzIHRoYXQga21zX2Z1bmNzLT53YWl0X2ZsdXNoKCkg cmV0dXJucwo+ID4gPiA+ID4gPiA+ID4gaW1tZWRpYXRlbHkgaWYgdGhlcmUgaXMgbm90aGluZyB0 byB3YWl0IGZvci4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEkgZG9uJ3QgdGhpbmsgdGhh dCdzIGhhcHBlbmluZyBpbiB0aGlzIGNhc2UuIEkgYWRkZWQgc29tZSBwcl9pbmZvKCkKPiA+ID4g PiA+ID4gPiBzdGF0ZW1lbnRzIHRvIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nKCkgYW5kIG1kcDVf Y3J0Y19wcF9kb25lX2lycSgpLgo+ID4gPiA+ID4gPiA+IEhlcmUncyB0aGUgZmlyc3QgdHdvIHNl dHMgb2YgbWVzc2FnZXMgdGhhdCBhcHBlYXIgaW4gZG1lc2c6Cj4gPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gPiBbICAgMTQuMDE4OTA3XSBtc20gZmQ5MDAwMDAubWRzczogcHAgZG9uZSB0aW1lIG91 dCwgbG09MAo+ID4gPiA+ID4gPiA+IFsgICAxNC4wMTg5OTNdIHJlcXVlc3RfcHBfZG9uZV9wZW5k aW5nOiBIRVJFCj4gPiA+ID4gPiA+ID4gWyAgIDE0LjA3NDIwOF0gbWRwNV9jcnRjX3BwX2RvbmVf aXJxOiBIRVJFCj4gPiA+ID4gPiA+ID4gWyAgIDE0LjA3NDM2OF0gQ29uc29sZTogc3dpdGNoaW5n IHRvIGNvbG91ciBmcmFtZSBidWZmZXIgZGV2aWNlIDEzNXgxMjAKPiA+ID4gPiA+ID4gPiBbICAg MTQuMTM4OTM4XSBtc20gZmQ5MDAwMDAubWRzczogcHAgZG9uZSB0aW1lIG91dCwgbG09MAo+ID4g PiA+ID4gPiA+IFsgICAxNC4xMzkwMjFdIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nOiBIRVJFCj4g PiA+ID4gPiA+ID4gWyAgIDE0LjE1ODA5N10gbWRwNV9jcnRjX3BwX2RvbmVfaXJxOiBIRVJFCj4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBUaGUgbWVzc2FnZXMgZ28gb24gbGlrZSB0aGlzIHdp dGggdGhlIHNhbWUgcGF0dGVybi4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEkgdHJpZWQg dHdvIGRpZmZlcmVudCBjaGFuZ2VzOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gMSkgSSBt b3ZlZCB0aGUgcmVxdWVzdF9wcF9kb25lX3BlbmRpbmcoKSBhbmQgY29ycmVzcG9uZGluZyBpZiBz dGF0ZW1lbnQKPiA+ID4gPiA+ID4gPiAgICBmcm9tIG1kcDVfY3J0Y19hdG9taWNfZmx1c2goKSBh bmQgaW50byBtZHA1X2NydGNfYXRvbWljX2JlZ2luKCkuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPiAyKSBJIGluY3JlYXNlZCB0aGUgdGltZW91dCBpbiB3YWl0X2Zvcl9jb21wbGV0aW9uX3Rp bWVvdXQoKSBieSBzZXZlcmFsCj4gPiA+ID4gPiA+ID4gICAgaW5jcmVtZW50czsgYWxsIHRoZSB3 YXkgdG8gNSBzZWNvbmRzLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBpbmNyZWFzaW5nIHRoZSB0 aW1lb3V0IHdvbid0IGhlbHAsIGJlY2F1c2UgdGhlIHBwLWRvbmUgaXJxIGhhcyBhbHJlYWR5Cj4g PiA+ID4gPiA+IGNvbWUgYXQgdGhlIHBvaW50IHdoZXJlIHdlIHdhaXQgZm9yIGl0Li4KPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gbWF5YmUgdGhlIGVhc3kgdGhpbmcgaXMganVzdCBhZGQgbWRwNV9j cnRjLT5uZWVkc19wcCwgc2V0IHRvIHRydWUKPiA+ID4gPiA+ID4gYmVmb3JlIHJlcXVlc3Rpbmcs IGFuZCBmYWxzZSB3aGVuIHdlIGdldCB0aGUgaXJxLi4gYW5kIHRoZW4KPiA+ID4gPiA+ID4gbWRw NV9jcnRjX3dhaXRfZm9yX3BwX2RvbmUoKSBqdXN0IHJldHVybnMgaWYgbmVlZHNfcHA9PWZhbHNl Li4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBPbiB0aGUgb3RoZXJoYW5kLCB3aGF0IGFib3V0IHRyeWlu ZyB0byBtYWtlIGNvbW1hbmQgbW9kZSBwYW5lbHMKPiA+ID4gPiA+IHJlc2VtYmxlIHZpZGVvIG1v ZGUgcGFuZWxzIHNsaWdodGx5PyAgVmlkZW8gbW9kZSBwYW5lbHMgaGF2ZSBhIHZzeW5jCj4gPiA+ ID4gPiBjb3VudGVyIGluIGhhcmR3YXJlLCB3aGljaCBpcyBtaXNzaW5nIGZyb20gY29tbWFuZCBt b2RlIC0gaG93ZXZlciBpdAo+ID4gPiA+ID4gc2VlbXMgbGlrZSB0aGUgZHJpdmVyL2RybSBmcmFt ZXdvcmsgd291bGQgcHJlZmVyIHN1Y2ggYSBjb3VudGVyLgo+ID4gPiA+ID4gV291bGQgaXQgYmUg YSByZWFzb25hYmxlIGlkZWEgdG8gbWFrZSBhIHNvZnR3YXJlIGNvdW50ZXIsIGFuZCBqdXN0Cj4g PiA+ID4gPiBpbmNyZW1lbnQgaXQgZXZlcnkgdGltZSB0aGUgcHBfZG9uZSBpcnEgaXMgdHJpZ2dl cmVkPwo+ID4gPiA+ID4KPiA+ID4gPiA+IEknbSBqdXN0IHRoaW5raW5nIHRoYXQgd2UnbGwgYXZv aWQgaXNzdWVzIGxvbmcgdGVybSBieSB0cnlpbmcgdG8gbWFrZQo+ID4gPiA+ID4gdGhlIGNvZGUg Y29tbW9uLCByYXRoZXIgdGhhbiBkaXZlcmdpbmcgaXQgZm9yIHRoZSB0d28gbW9kZXMuCj4gPiA+ ID4gPgo+ID4gPiA+Cj4gPiA+ID4gKnBvc3NpYmx5KiwgYnV0IEkgdGhpbmsgd2Ugd2FudCB0byBh Y2NvdW50IHNvbWVob3cgcGVyaW9kcyB3aGVyZQo+ID4gPiA+IGRpc3BsYXkgaXMgbm90IHVwZGF0 ZWQuCj4gPiA+ID4KPiA+ID4gPiBmd2l3LCBpdCBpc24ndCB0aGF0IHVuY29tbW9uIGZvciB1c2Vy c3BhY2UgdG8gdXNlIHZibGFua3MgdG8gImtlZXAKPiA+ID4gPiB0aW1lIiAoZHJpdmUgYW5pbWF0 aW9ucyBmb3IgZGVza3RvcCBzd2l0Y2gsIHdpbmRvdwo+ID4gPiA+IG1heGltaXplL3VubWF4aW1p emUsIGV0YykuLiBpdCBjb3VsZCBiZSBhIHN1cnByaXNlIHdoZW4gInZibGFuayIgaXMKPiA+ID4g PiBub3QgcGVyaW9kaWMuCj4gPiA+Cj4gPiA+IFdoYXQgZG8geW91IHRoaW5rIGFib3V0IHVzaW5n IHNvbWUgdmFyaWF0aW9uIG9mIHRoZSBjdXJyZW50IHZhbHVlIG9mCj4gPiA+IGppZmZpZXMgaW4g dGhlIGtlcm5lbCArIHRoZSBudW1iZXIgb2YgcHBfZG9uZSBJUlFzIGFzIHRoZSBzb2Z0d2FyZQo+ ID4gPiBjb3VudGVyIGZvciBjb21tYW5kLW1vZGUgcGFuZWxzPwo+ID4gPgo+ID4KPiA+IGppZmZp ZXMgaXMgcHJvYmFibHkgdG9vIGNvYXJzZS4uIGJ1dCB3ZSBjb3VsZCB1c2UgbW9ub3RvbmljIGNs b2NrLCBJIGd1ZXNzLgo+ID4KPiA+IEJ1dCBJIHN1cHBvc2UgZXZlbiBhIGNtZCBtb2RlIHBhbmVs IGhhcyBhICJ2YmxhbmsiLCBpdCBpcyBqdXN0Cj4gPiBpbnRlcm5hbCB0aGUgcGFuZWwuICBEbyB3 ZSBnZXQgdGhlIFRFIGludGVycnVwdCBhdCByZWd1bGFyIGludGVydmFscz8KPiA+IEFGQUlVIHRo aXMgd291bGQgYmUgdGllZCB0byB0aGUgcGFuZWwncyBpbnRlcm5hbCB2YmxhbmsuCj4KPiBUaGUg VEUgaW50ZXJydXB0IHdhcyBmaXJzdCBpbXBsZW1lbnRlZCBpbiBNRFAgMS43LjAgKG1zbTg5OTYp LiAgODk3NAo+IHByZWRhdGVzIHRoYXQuCj4gWW91IGNhbiBnZXQgaXQgZnJvbSB0aGUgV1JfUFRS IGludGVycnVwdCwgYnV0IHlvdSBoYXZlIHRvIHVuZGVyc3RhbmQKPiBkZXRhaWxzIGFib3V0IHlv dXIgcGFuZWwgdG8gY29uZmlndXJlIHRoYXQgY29ycmVjdGx5LgoKb2gsIHNhZC4uIEkga2luZGEg YXNzdW1lZCBpdCB3YXMgYSBwcmV0dHkgY29tbW9uIERTSSBpcnEgc2luY2UKZm9yZXZlci4uIEkg Z3Vlc3MgdGhlIGh3IGlzIGp1c3QgbWFuYWdpbmcgdGhlIGZsb3cgY29udHJvbCB0byBwcmV2ZW50 CnRlYXJpbmc/CgpXZWxsLCBhbnl3YXlzLCBJIGd1ZXNzIHdlIGNvdWxkIGp1c3QgdXNlIGEgZnJl ZS1ydW5uaW5nIHRpbWVyIGJhc2VkIG9uCnJlZnJlc2ggcmF0ZSBvZiB0aGUgcGFuZWw/CgpCUiwK LVIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRy ZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5v From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92BFC5DF60 for ; Fri, 8 Nov 2019 08:13:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92E5E21D7B for ; Fri, 8 Nov 2019 08:13:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92E5E21D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DFCE6F88B; Fri, 8 Nov 2019 08:12:59 +0000 (UTC) Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 273FD6F82D for ; Fri, 8 Nov 2019 02:03:35 +0000 (UTC) Received: by mail-il1-x141.google.com with SMTP id q1so3018636ile.13 for ; Thu, 07 Nov 2019 18:03:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rb7E4G3AfRv3BBvojQNjoB9UPjH1AyXc4p/SxsSL9W4=; b=OVNF+6MGo7h/7mhfDNuVR4H6/R1Rolu6bIfhuMEY3cMZdkWjt7KEulLllVg0mfY28o P0oEwlDvwiJUFwKg5nhob2scz7kQssw4jMtuL0zDiljMv4rl60yjSffI3pQtw/WnhPzM HPg8f+tSQ7t9X3FYoMYcCmvcHK/9JiGJuhV1VhdJ6hJ3zM/Q/RNA6b3opTrFKQrfUFli xkT8KA7tkGPYcQZDET57IXKzd1J4j/vNVVHlMPU2mxXv5AHQ8cVMd6So6zEPPW8F2Yrh lxvrQ0xX51AwqdWm3aHAxzOwplLq4CbgguQNvpo71x3K+VCED2CewHr9WCTjOTYxzagj L4PA== X-Gm-Message-State: APjAAAVkpevdT8yLWRm6SitDqq6S2467t/ftcxwS8lf9ck5Ki8Mv9NCk LsrpcvdrEth0hOKlnx/wT2ybIMY3bHCWpkuywEVcMA== X-Google-Smtp-Source: APXvYqwfvE0lbSsmo3rLw5QoJ6zVMyT9Wrt/mQAmklzCszTTgckYnb+UZs7Y5ORM7LCKGmCVLHGnxLClJWkwQGTwBOI= X-Received: by 2002:a92:c9c3:: with SMTP id k3mr9000230ilq.299.1573178614360; Thu, 07 Nov 2019 18:03:34 -0800 (PST) MIME-Version: 1.0 References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> <20191107111019.GA24028@onstation.org> In-Reply-To: From: Rob Clark Date: Thu, 7 Nov 2019 18:03:24 -0800 Message-ID: Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes To: Jeffrey Hugo X-Mailman-Approved-At: Fri, 08 Nov 2019 08:12:31 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rb7E4G3AfRv3BBvojQNjoB9UPjH1AyXc4p/SxsSL9W4=; b=IgoQ4CLeR5KSemdl8EH4Mv7SW5YfL/GAg/l1KhpuG8A/axs8uQnarKuxoDx6hd6iQG FsKC8qZR8md/Xc/sMEb0TgU7cYRUSq3Kg1zNXn2/d9L4Nn8slVxXisf0nqJOJxShSe27 9t2/w72HYCsTpM0ziXzT+tLqJOigzV/O34KlU= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , linux-arm-msm , Linux Kernel Mailing List , dri-devel , freedreno , Brian Masney Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191108020324.IwkM0A9t9TmjOkHk7SwWqrKPXxjJSAu8zuAnmcd1sNc@z> T24gVGh1LCBOb3YgNywgMjAxOSBhdCA5OjQwIEFNIEplZmZyZXkgSHVnbyA8amVmZnJleS5sLmh1 Z29AZ21haWwuY29tPiB3cm90ZToKPgo+IE9uIFRodSwgTm92IDcsIDIwMTkgYXQgOToxNyBBTSBS b2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFRodSwgTm92 IDcsIDIwMTkgYXQgMzoxMCBBTSBCcmlhbiBNYXNuZXkgPG1hc25leWJAb25zdGF0aW9uLm9yZz4g d3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFdlZCwgTm92IDA2LCAyMDE5IGF0IDA4OjU4OjU5QU0gLTA4 MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+ID4gPiBPbiBXZWQsIE5vdiA2LCAyMDE5IGF0IDg6NDcg QU0gSmVmZnJleSBIdWdvIDxqZWZmcmV5LmwuaHVnb0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+ ID4KPiA+ID4gPiA+IE9uIFdlZCwgTm92IDYsIDIwMTkgYXQgOTozMCBBTSBSb2IgQ2xhcmsgPHJv YmRjbGFya0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBPbiBXZWQs IE5vdiA2LCAyMDE5IGF0IDE6MTMgQU0gQnJpYW4gTWFzbmV5IDxtYXNuZXliQG9uc3RhdGlvbi5v cmc+IHdyb3RlOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gT24gVHVlLCBOb3YgMDUsIDIw MTkgYXQgMDg6MjM6MjdBTSAtMDgwMCwgUm9iIENsYXJrIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4g T24gVHVlLCBOb3YgNSwgMjAxOSBhdCAyOjA4IEFNIEJyaWFuIE1hc25leSA8bWFzbmV5YkBvbnN0 YXRpb24ub3JnPiB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ID4gVGhlICdwcCBkb25lIHRpbWUgb3V0 JyBlcnJvcnMgZ28gYXdheSBpZiBJIHJldmVydCB0aGUgZm9sbG93aW5nIHRocmVlCj4gPiA+ID4g PiA+ID4gPiA+IGNvbW1pdHM6Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+IGNk NmQ5MjMxNjdiMSAoImRybS9tc20vZHB1OiBhc3luYyBjb21taXQgc3VwcG9ydCIpCj4gPiA+ID4g PiA+ID4gPiA+IGQ5MzRhNzEyYzVlNiAoImRybS9tc206IGFkZCBhdG9taWMgdHJhY2VzIikKPiA+ ID4gPiA+ID4gPiA+ID4gMmQ5OWNlZDc4N2UzICgiZHJtL21zbTogYXN5bmMgY29tbWl0IHN1cHBv cnQiKQo+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBJIHJldmVydGVkIHRoZSBm aXJzdCBvbmUgdG8gZml4IGEgY29tcGlsZXIgZXJyb3IsIGFuZCB0aGUgc2Vjb25kIG9uZSBzbwo+ ID4gPiA+ID4gPiA+ID4gPiB0aGF0IHRoZSBsYXN0IHBhdGNoIGNhbiBiZSByZXZlcnRlZCB3aXRo b3V0IGFueSBtZXJnZSBjb25mbGljdHMuCj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4g PiA+IEkgc2VlIHRoYXQgY3J0Y19mbHVzaCgpIGNhbGxzIG1kcDVfY3RsX2NvbW1pdCgpLiBJIHRy aWVkIHRvIHVzZQo+ID4gPiA+ID4gPiA+ID4gPiBjcnRjX2ZsdXNoX2FsbCgpIGluIG1kcDVfZmx1 c2hfY29tbWl0KCkgYW5kIHRoZSBjb250ZW50cyBvZiB0aGUgZnJhbWUKPiA+ID4gPiA+ID4gPiA+ ID4gYnVmZmVyIGRhbmNlIGFyb3VuZCB0aGUgc2NyZWVuIGxpa2UgaXRzIG91dCBvZiBzeW5jLiBJ IHJlbmFtZWQKPiA+ID4gPiA+ID4gPiA+ID4gY3J0Y19mbHVzaF9hbGwoKSB0byBtZHA1X2NydGNf Zmx1c2hfYWxsKCkgYW5kIHJlbW92ZWQgdGhlIHN0YXRpYwo+ID4gPiA+ID4gPiA+ID4gPiBkZWNs YXJhdGlvbi4gSGVyZSdzIHRoZSByZWxldmFudCBwYXJ0IG9mIHdoYXQgSSB0cmllZDoKPiA+ID4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9k aXNwL21kcDUvbWRwNV9rbXMuYwo+ID4gPiA+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vbXNtL2Rpc3AvbWRwNS9tZHA1X2ttcy5jCj4gPiA+ID4gPiA+ID4gPiA+IEBAIC0xNzEsNyAr MTcxLDE1IEBAIHN0YXRpYyB2b2lkIG1kcDVfcHJlcGFyZV9jb21taXQoc3RydWN0IG1zbV9rbXMg Kmttcywgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+ID4gPiA+ICBzdGF0aWMgdm9pZCBtZHA1X2ZsdXNoX2NvbW1pdChzdHJ1Y3QgbXNtX2tt cyAqa21zLCB1bnNpZ25lZCBjcnRjX21hc2spCj4gPiA+ID4gPiA+ID4gPiA+ICB7Cj4gPiA+ID4g PiA+ID4gPiA+IC0gICAgICAgLyogVE9ETyAqLwo+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIHN0 cnVjdCBtZHA1X2ttcyAqbWRwNV9rbXMgPSB0b19tZHA1X2ttcyh0b19tZHBfa21zKGttcykpOwo+ ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ID4gPiA+ ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgIGZvcl9lYWNoX2NydGNfbWFzayht ZHA1X2ttcy0+ZGV2LCBjcnRjLCBjcnRjX21hc2spIHsKPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAg ICAgICAgICAgIGlmICghY3J0Yy0+c3RhdGUtPmFjdGl2ZSkKPiA+ID4gPiA+ID4gPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4g PiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIG1kcDVfY3J0Y19mbHVzaF9hbGwoY3J0Yyk7Cj4g PiA+ID4gPiA+ID4gPiA+ICsgICAgICAgfQo+ID4gPiA+ID4gPiA+ID4gPiAgfQo+ID4gPiA+ID4g PiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBBbnkgdGlwcyB3b3VsZCBiZSBhcHByZWNpYXRlZC4K PiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gSSB0aGluayB0 aGlzIGlzIGFsb25nIHRoZSBsaW5lcyBvZiB3aGF0IHdlIG5lZWQgdG8gZW5hYmxlIGFzeW5jIGNv bW1pdAo+ID4gPiA+ID4gPiA+ID4gZm9yIG1kcDUgKGJ1dCBhbHNvIHJlbW92aW5nIHRoZSBmbHVz aCBmcm9tIHRoZSBhdG9taWMtY29tbWl0IHBhdGgpLi4KPiA+ID4gPiA+ID4gPiA+IHRoZSBwcmlu Y2lwbGUgYmVoaW5kIHRoZSBhc3luYyBjb21taXQgaXMgdG8gZG8gYWxsIHRoZSBhdG9taWMgc3Rh dGUKPiA+ID4gPiA+ID4gPiA+IGNvbW1pdCBub3JtYWxseSwgYnV0IGRlZmVyIHdyaXRpbmcgdGhl IGZsdXNoIGJpdHMuICBUaGlzIHdheSwgaWYgeW91Cj4gPiA+ID4gPiA+ID4gPiBnZXQgYW5vdGhl ciBhc3luYyB1cGRhdGUgYmVmb3JlIHRoZSBuZXh0IHZibGFuaywgeW91IGp1c3QgYXBwbHkgaXQK PiA+ID4gPiA+ID4gPiA+IGltbWVkaWF0ZWx5IGluc3RlYWQgb2Ygd2FpdGluZyBmb3IgdmJsYW5r Lgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IEJ1dCBJIGd1ZXNzIHlvdSBhcmUgb24g YSBjb21tYW5kIG1vZGUgcGFuZWwsIGlmIEkgcmVtZW1iZXI/ICBXaGljaCBpcwo+ID4gPiA+ID4g PiA+ID4gYSBjYXNlIEkgZGlkbid0IGhhdmUgYSB3YXkgdG8gdGVzdC4gIEFuZCBJJ20gbm90IGVu dGlyZWx5IGFib3V0IGhvdwo+ID4gPiA+ID4gPiA+ID4ga21zX2Z1bmNzLT52c3luY190aW1lKCkg c2hvdWxkIGJlIGltcGxlbWVudGVkIGZvciBjbWQgbW9kZSBwYW5lbHMuCj4gPiA+ID4gPiA+ID4K PiA+ID4gPiA+ID4gPiBZZXMsIHRoaXMgaXMgYSBjb21tYW5kLW1vZGUgcGFuZWwgYW5kIHRoZXJl J3Mgbm8gaGFyZHdhcmUgZnJhbWUgY291bnRlcgo+ID4gPiA+ID4gPiA+IGF2YWlsYWJsZS4gVGhl IGtleSB0byBnZXR0aW5nIHRoZSBkaXNwbGF5IHdvcmtpbmcgb24gdGhpcyBwaG9uZSB3YXMgdGhp cwo+ID4gPiA+ID4gPiA+IHBhdGNoOgo+ID4gPiA+ID4gPiA+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5v cmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC9jb21taXQvP2lk PTJiYWI1MmFmNmZlNjhjNDNiMzI3YTU3ZTVjZTVmYzEwZWVmZGZhZGYKPiA+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiA+ID4gVGhhdCBhbGwgc2FpZCwgSSB0aGluayB3ZSBzaG91bGQgZmlyc3QgZml4 IHdoYXQgaXMgYnJva2VuLCBiZWZvcmUKPiA+ID4gPiA+ID4gPiA+IHdvcnJ5aW5nIGFib3V0IGV4 dGVuZGluZyBhc3luYyBjb21taXQgc3VwcG9ydCB0byBtZHA1Li4gd2hpY2gKPiA+ID4gPiA+ID4g PiA+IHNob3VsZG4ndCBoaXQgdGhlIGFzeW5jPT10cnVlIHBhdGgsIGR1ZSB0byBub3QgaW1wbGVt ZW50aW5nCj4gPiA+ID4gPiA+ID4gPiBrbXNfZnVuY3MtPnZzeW5jX3RpbWUoKS4KPiA+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiBXaGF0IEkgdGhpbmsgaXMgZ29pbmcgb24gaXMgdGhhdCwg aW4gdGhlIGNtZCBtb2RlIGNhc2UsCj4gPiA+ID4gPiA+ID4gPiBtZHA1X3dhaXRfZmx1c2goKSAo aW5kaXJlY3RseSkgY2FsbHMgbWRwNV9jcnRjX3dhaXRfZm9yX3BwX2RvbmUoKSwKPiA+ID4gPiA+ ID4gPiA+IHdoaWNoIHdhaXRzIGZvciBhIHBwLWRvbmUgaXJxIHJlZ2FyZGxlc3Mgb2Ygd2hldGhl ciB0aGVyZSBpcyBhIGZsdXNoCj4gPiA+ID4gPiA+ID4gPiBpbiBwcm9ncmVzcy4gIFNpbmNlIHRo ZXJlIGlzIG5vIGZsdXNoIHBlbmRpbmcsIHRoZSBpcnEgbmV2ZXIgY29tZXMuCj4gPiA+ID4gPiA+ ID4gPiBCdXQgdGhlIGV4cGVjdGF0aW9uIGlzIHRoYXQga21zX2Z1bmNzLT53YWl0X2ZsdXNoKCkg cmV0dXJucwo+ID4gPiA+ID4gPiA+ID4gaW1tZWRpYXRlbHkgaWYgdGhlcmUgaXMgbm90aGluZyB0 byB3YWl0IGZvci4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEkgZG9uJ3QgdGhpbmsgdGhh dCdzIGhhcHBlbmluZyBpbiB0aGlzIGNhc2UuIEkgYWRkZWQgc29tZSBwcl9pbmZvKCkKPiA+ID4g PiA+ID4gPiBzdGF0ZW1lbnRzIHRvIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nKCkgYW5kIG1kcDVf Y3J0Y19wcF9kb25lX2lycSgpLgo+ID4gPiA+ID4gPiA+IEhlcmUncyB0aGUgZmlyc3QgdHdvIHNl dHMgb2YgbWVzc2FnZXMgdGhhdCBhcHBlYXIgaW4gZG1lc2c6Cj4gPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gPiBbICAgMTQuMDE4OTA3XSBtc20gZmQ5MDAwMDAubWRzczogcHAgZG9uZSB0aW1lIG91 dCwgbG09MAo+ID4gPiA+ID4gPiA+IFsgICAxNC4wMTg5OTNdIHJlcXVlc3RfcHBfZG9uZV9wZW5k aW5nOiBIRVJFCj4gPiA+ID4gPiA+ID4gWyAgIDE0LjA3NDIwOF0gbWRwNV9jcnRjX3BwX2RvbmVf aXJxOiBIRVJFCj4gPiA+ID4gPiA+ID4gWyAgIDE0LjA3NDM2OF0gQ29uc29sZTogc3dpdGNoaW5n IHRvIGNvbG91ciBmcmFtZSBidWZmZXIgZGV2aWNlIDEzNXgxMjAKPiA+ID4gPiA+ID4gPiBbICAg MTQuMTM4OTM4XSBtc20gZmQ5MDAwMDAubWRzczogcHAgZG9uZSB0aW1lIG91dCwgbG09MAo+ID4g PiA+ID4gPiA+IFsgICAxNC4xMzkwMjFdIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nOiBIRVJFCj4g PiA+ID4gPiA+ID4gWyAgIDE0LjE1ODA5N10gbWRwNV9jcnRjX3BwX2RvbmVfaXJxOiBIRVJFCj4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBUaGUgbWVzc2FnZXMgZ28gb24gbGlrZSB0aGlzIHdp dGggdGhlIHNhbWUgcGF0dGVybi4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEkgdHJpZWQg dHdvIGRpZmZlcmVudCBjaGFuZ2VzOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gMSkgSSBt b3ZlZCB0aGUgcmVxdWVzdF9wcF9kb25lX3BlbmRpbmcoKSBhbmQgY29ycmVzcG9uZGluZyBpZiBz dGF0ZW1lbnQKPiA+ID4gPiA+ID4gPiAgICBmcm9tIG1kcDVfY3J0Y19hdG9taWNfZmx1c2goKSBh bmQgaW50byBtZHA1X2NydGNfYXRvbWljX2JlZ2luKCkuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPiAyKSBJIGluY3JlYXNlZCB0aGUgdGltZW91dCBpbiB3YWl0X2Zvcl9jb21wbGV0aW9uX3Rp bWVvdXQoKSBieSBzZXZlcmFsCj4gPiA+ID4gPiA+ID4gICAgaW5jcmVtZW50czsgYWxsIHRoZSB3 YXkgdG8gNSBzZWNvbmRzLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBpbmNyZWFzaW5nIHRoZSB0 aW1lb3V0IHdvbid0IGhlbHAsIGJlY2F1c2UgdGhlIHBwLWRvbmUgaXJxIGhhcyBhbHJlYWR5Cj4g PiA+ID4gPiA+IGNvbWUgYXQgdGhlIHBvaW50IHdoZXJlIHdlIHdhaXQgZm9yIGl0Li4KPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gbWF5YmUgdGhlIGVhc3kgdGhpbmcgaXMganVzdCBhZGQgbWRwNV9j cnRjLT5uZWVkc19wcCwgc2V0IHRvIHRydWUKPiA+ID4gPiA+ID4gYmVmb3JlIHJlcXVlc3Rpbmcs IGFuZCBmYWxzZSB3aGVuIHdlIGdldCB0aGUgaXJxLi4gYW5kIHRoZW4KPiA+ID4gPiA+ID4gbWRw NV9jcnRjX3dhaXRfZm9yX3BwX2RvbmUoKSBqdXN0IHJldHVybnMgaWYgbmVlZHNfcHA9PWZhbHNl Li4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBPbiB0aGUgb3RoZXJoYW5kLCB3aGF0IGFib3V0IHRyeWlu ZyB0byBtYWtlIGNvbW1hbmQgbW9kZSBwYW5lbHMKPiA+ID4gPiA+IHJlc2VtYmxlIHZpZGVvIG1v ZGUgcGFuZWxzIHNsaWdodGx5PyAgVmlkZW8gbW9kZSBwYW5lbHMgaGF2ZSBhIHZzeW5jCj4gPiA+ ID4gPiBjb3VudGVyIGluIGhhcmR3YXJlLCB3aGljaCBpcyBtaXNzaW5nIGZyb20gY29tbWFuZCBt b2RlIC0gaG93ZXZlciBpdAo+ID4gPiA+ID4gc2VlbXMgbGlrZSB0aGUgZHJpdmVyL2RybSBmcmFt ZXdvcmsgd291bGQgcHJlZmVyIHN1Y2ggYSBjb3VudGVyLgo+ID4gPiA+ID4gV291bGQgaXQgYmUg YSByZWFzb25hYmxlIGlkZWEgdG8gbWFrZSBhIHNvZnR3YXJlIGNvdW50ZXIsIGFuZCBqdXN0Cj4g PiA+ID4gPiBpbmNyZW1lbnQgaXQgZXZlcnkgdGltZSB0aGUgcHBfZG9uZSBpcnEgaXMgdHJpZ2dl cmVkPwo+ID4gPiA+ID4KPiA+ID4gPiA+IEknbSBqdXN0IHRoaW5raW5nIHRoYXQgd2UnbGwgYXZv aWQgaXNzdWVzIGxvbmcgdGVybSBieSB0cnlpbmcgdG8gbWFrZQo+ID4gPiA+ID4gdGhlIGNvZGUg Y29tbW9uLCByYXRoZXIgdGhhbiBkaXZlcmdpbmcgaXQgZm9yIHRoZSB0d28gbW9kZXMuCj4gPiA+ ID4gPgo+ID4gPiA+Cj4gPiA+ID4gKnBvc3NpYmx5KiwgYnV0IEkgdGhpbmsgd2Ugd2FudCB0byBh Y2NvdW50IHNvbWVob3cgcGVyaW9kcyB3aGVyZQo+ID4gPiA+IGRpc3BsYXkgaXMgbm90IHVwZGF0 ZWQuCj4gPiA+ID4KPiA+ID4gPiBmd2l3LCBpdCBpc24ndCB0aGF0IHVuY29tbW9uIGZvciB1c2Vy c3BhY2UgdG8gdXNlIHZibGFua3MgdG8gImtlZXAKPiA+ID4gPiB0aW1lIiAoZHJpdmUgYW5pbWF0 aW9ucyBmb3IgZGVza3RvcCBzd2l0Y2gsIHdpbmRvdwo+ID4gPiA+IG1heGltaXplL3VubWF4aW1p emUsIGV0YykuLiBpdCBjb3VsZCBiZSBhIHN1cnByaXNlIHdoZW4gInZibGFuayIgaXMKPiA+ID4g PiBub3QgcGVyaW9kaWMuCj4gPiA+Cj4gPiA+IFdoYXQgZG8geW91IHRoaW5rIGFib3V0IHVzaW5n IHNvbWUgdmFyaWF0aW9uIG9mIHRoZSBjdXJyZW50IHZhbHVlIG9mCj4gPiA+IGppZmZpZXMgaW4g dGhlIGtlcm5lbCArIHRoZSBudW1iZXIgb2YgcHBfZG9uZSBJUlFzIGFzIHRoZSBzb2Z0d2FyZQo+ ID4gPiBjb3VudGVyIGZvciBjb21tYW5kLW1vZGUgcGFuZWxzPwo+ID4gPgo+ID4KPiA+IGppZmZp ZXMgaXMgcHJvYmFibHkgdG9vIGNvYXJzZS4uIGJ1dCB3ZSBjb3VsZCB1c2UgbW9ub3RvbmljIGNs b2NrLCBJIGd1ZXNzLgo+ID4KPiA+IEJ1dCBJIHN1cHBvc2UgZXZlbiBhIGNtZCBtb2RlIHBhbmVs IGhhcyBhICJ2YmxhbmsiLCBpdCBpcyBqdXN0Cj4gPiBpbnRlcm5hbCB0aGUgcGFuZWwuICBEbyB3 ZSBnZXQgdGhlIFRFIGludGVycnVwdCBhdCByZWd1bGFyIGludGVydmFscz8KPiA+IEFGQUlVIHRo aXMgd291bGQgYmUgdGllZCB0byB0aGUgcGFuZWwncyBpbnRlcm5hbCB2YmxhbmsuCj4KPiBUaGUg VEUgaW50ZXJydXB0IHdhcyBmaXJzdCBpbXBsZW1lbnRlZCBpbiBNRFAgMS43LjAgKG1zbTg5OTYp LiAgODk3NAo+IHByZWRhdGVzIHRoYXQuCj4gWW91IGNhbiBnZXQgaXQgZnJvbSB0aGUgV1JfUFRS IGludGVycnVwdCwgYnV0IHlvdSBoYXZlIHRvIHVuZGVyc3RhbmQKPiBkZXRhaWxzIGFib3V0IHlv dXIgcGFuZWwgdG8gY29uZmlndXJlIHRoYXQgY29ycmVjdGx5LgoKb2gsIHNhZC4uIEkga2luZGEg YXNzdW1lZCBpdCB3YXMgYSBwcmV0dHkgY29tbW9uIERTSSBpcnEgc2luY2UKZm9yZXZlci4uIEkg Z3Vlc3MgdGhlIGh3IGlzIGp1c3QgbWFuYWdpbmcgdGhlIGZsb3cgY29udHJvbCB0byBwcmV2ZW50 CnRlYXJpbmc/CgpXZWxsLCBhbnl3YXlzLCBJIGd1ZXNzIHdlIGNvdWxkIGp1c3QgdXNlIGEgZnJl ZS1ydW5uaW5nIHRpbWVyIGJhc2VkIG9uCnJlZnJlc2ggcmF0ZSBvZiB0aGUgcGFuZWw/CgpCUiwK LVIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs