From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754395AbdKANGk (ORCPT ); Wed, 1 Nov 2017 09:06:40 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:55624 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbdKANGi (ORCPT ); Wed, 1 Nov 2017 09:06:38 -0400 X-Google-Smtp-Source: ABhQp+SsTk5FEY/hzEw2QQHWHW2psCpPHiHHTyA+97Iut2NwktByW1V9ixjYDFcqheuQMLL+L7SV0HDcJBkaS9XwcTE= MIME-Version: 1.0 X-Originating-IP: [84.93.92.22] In-Reply-To: <910a98ca-57f6-baca-73ac-f6c8c1ff04db@i2se.com> References: <20171006220504.7776-1-eric@anholt.net> <910a98ca-57f6-baca-73ac-f6c8c1ff04db@i2se.com> From: Matt Hart Date: Wed, 1 Nov 2017 13:06:35 +0000 X-Google-Sender-Auth: onFKANUwAfTTDEU3_wDe7Qat4E8 Message-ID: Subject: Re: [GIT PULL 1/2] bcm2835-dt-fixes-2017-10-06 To: Stefan Wahren Cc: Peter Robinson , Marcel Holtmann , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Loic Poulain , linux-arm-kernel@lists.infradead.org, Eric Anholt Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1 November 2017 at 12:05, Stefan Wahren wrote: > Hi Matt, hi Peter, > > Am 01.11.2017 um 10:37 schrieb Peter Robinson: >> On Tue, Oct 31, 2017 at 5:00 PM, Matt Hart wrote: >>> On 6 October 2017 at 23:14, Florian Fainelli wrote: >>>> On 10/06/2017 03:05 PM, Eric Anholt wrote: >>>>> Hi Florian. Here's a patch that's gone through a couple of revisions >>>>> on the list, that seriously fixes up the default serial behavior -- >>>>> previously, without the right config.txt/cmdline bits, you'd often end >>>>> up with a hang with no output before booting completed. It would be >>>>> great to get it into 4.14. >>>>> >>>>> The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: >>>>> >>>>> Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) >>>>> >>>>> are available in the git repository at: >>>>> >>>>> git://github.com/anholt/linux tags/bcm2835-dt-fixes-2017-10-06 >>>>> >>>>> for you to fetch changes up to f08f58a2bf68900a84e782b8c7ad701c0654173c: >>>>> >>>>> ARM: dts: bcm283x: Fix console path on RPi3 (2017-10-06 13:04:56 -0700) >>>>> >>>>> ---------------------------------------------------------------- >>>>> This pull request brings in a fix for default serial console setup on >>>>> RPi3, so it now comes up with no config.txt/cmdline.txt settings in >>>>> the firmware. >>>>> >>>>> ---------------------------------------------------------------- >>>> Merged, thanks Eric >>>> >>>> -- >>>> Florian >>> Hi all, >>> >>> I realise this patch has been in mainline for a more than a week, but >>> I've only recently had time to bisect broken rpi-3 boots in kernelci >>> and found f08f58a2bf68900a84e782b8c7ad701c0654173c as the cause. >>> >>> Kernelci boots the rpi3 using uboot, with console=ttyS0 in the command >>> line which now fails: >>> https://kernelci.org/boot/id/59f787f059b5147794ef1dcf/ >>> >>> Is there an alias I can use for both before and after this patch? >>> >>> Mainline boots fine if I use console=ttyS1 or drop the console arg >>> altogether, but as we don't currently support different boot args per >>> tree, and we don't have the manpower to track this patch in all the >>> trees we test, we will have to switch to only boot testing mainline >>> from now on. >> Yes, I've seen the same in Fedora with that patch. >> >> > could you please describe the issue more in detail. > > Does u-boot or Linux hang? Does u-boot select the wrong UART? Is there a > pinmux conflict? Linux throws a kernel panic, "Warning: unable to open an initial console." > > Which u-boot version do you use? These are the 2 boot reports from KernelCI, there some LAVA debug in there but you can see the uboot version and boot commands used. Working boot https://storage.kernelci.org/mainline/master/v4.14-rc5-95-g1c9fec470b81/arm64/defconfig/lab-mhart/boot-bcm2837-rpi-3-b.html Failing boot https://storage.kernelci.org/mainline/master/v4.14-rc5-125-g9c323bff13f9/arm64/defconfig/lab-mhart/boot-bcm2837-rpi-3-b.html > > > Best regards > > Stefan > -- Matt Hart From mboxrd@z Thu Jan 1 00:00:00 1970 From: matt@mattface.org (Matt Hart) Date: Wed, 1 Nov 2017 13:06:35 +0000 Subject: [GIT PULL 1/2] bcm2835-dt-fixes-2017-10-06 In-Reply-To: <910a98ca-57f6-baca-73ac-f6c8c1ff04db@i2se.com> References: <20171006220504.7776-1-eric@anholt.net> <910a98ca-57f6-baca-73ac-f6c8c1ff04db@i2se.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 1 November 2017 at 12:05, Stefan Wahren wrote: > Hi Matt, hi Peter, > > Am 01.11.2017 um 10:37 schrieb Peter Robinson: >> On Tue, Oct 31, 2017 at 5:00 PM, Matt Hart wrote: >>> On 6 October 2017 at 23:14, Florian Fainelli wrote: >>>> On 10/06/2017 03:05 PM, Eric Anholt wrote: >>>>> Hi Florian. Here's a patch that's gone through a couple of revisions >>>>> on the list, that seriously fixes up the default serial behavior -- >>>>> previously, without the right config.txt/cmdline bits, you'd often end >>>>> up with a hang with no output before booting completed. It would be >>>>> great to get it into 4.14. >>>>> >>>>> The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: >>>>> >>>>> Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) >>>>> >>>>> are available in the git repository at: >>>>> >>>>> git://github.com/anholt/linux tags/bcm2835-dt-fixes-2017-10-06 >>>>> >>>>> for you to fetch changes up to f08f58a2bf68900a84e782b8c7ad701c0654173c: >>>>> >>>>> ARM: dts: bcm283x: Fix console path on RPi3 (2017-10-06 13:04:56 -0700) >>>>> >>>>> ---------------------------------------------------------------- >>>>> This pull request brings in a fix for default serial console setup on >>>>> RPi3, so it now comes up with no config.txt/cmdline.txt settings in >>>>> the firmware. >>>>> >>>>> ---------------------------------------------------------------- >>>> Merged, thanks Eric >>>> >>>> -- >>>> Florian >>> Hi all, >>> >>> I realise this patch has been in mainline for a more than a week, but >>> I've only recently had time to bisect broken rpi-3 boots in kernelci >>> and found f08f58a2bf68900a84e782b8c7ad701c0654173c as the cause. >>> >>> Kernelci boots the rpi3 using uboot, with console=ttyS0 in the command >>> line which now fails: >>> https://kernelci.org/boot/id/59f787f059b5147794ef1dcf/ >>> >>> Is there an alias I can use for both before and after this patch? >>> >>> Mainline boots fine if I use console=ttyS1 or drop the console arg >>> altogether, but as we don't currently support different boot args per >>> tree, and we don't have the manpower to track this patch in all the >>> trees we test, we will have to switch to only boot testing mainline >>> from now on. >> Yes, I've seen the same in Fedora with that patch. >> >> > could you please describe the issue more in detail. > > Does u-boot or Linux hang? Does u-boot select the wrong UART? Is there a > pinmux conflict? Linux throws a kernel panic, "Warning: unable to open an initial console." > > Which u-boot version do you use? These are the 2 boot reports from KernelCI, there some LAVA debug in there but you can see the uboot version and boot commands used. Working boot https://storage.kernelci.org/mainline/master/v4.14-rc5-95-g1c9fec470b81/arm64/defconfig/lab-mhart/boot-bcm2837-rpi-3-b.html Failing boot https://storage.kernelci.org/mainline/master/v4.14-rc5-125-g9c323bff13f9/arm64/defconfig/lab-mhart/boot-bcm2837-rpi-3-b.html > > > Best regards > > Stefan > -- Matt Hart