From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Oudinet Date: Tue, 24 Feb 2015 18:07:10 +0100 Subject: [Buildroot] [PATCH v6 02/16] package/pkg-rebar: new infrastructure In-Reply-To: <20150203102832.51cb4f7d@free-electrons.com> References: <1421055140-5092-1-git-send-email-johan.oudinet@gmail.com> <1421055140-5092-3-git-send-email-johan.oudinet@gmail.com> <20150203102832.51cb4f7d@free-electrons.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thomas, All, Sorry for the long delay before replying to this email. I forgot it in my list and went to holidays in the meantime. On Tue, Feb 3, 2015 at 10:28 AM, Thomas Petazzoni wrote: >> +# Directories to store rebar dependencies in. >> +# >> +# These directories actually only contain symbolic links to Erlang >> +# applications in either $(HOST_DIR) or $(STAGING_DIR). One needs >> +# them to avoid rebar complaining about missing dependencies, as this >> +# infrastructure tells rebar to NOT download dependencies during >> +# the build stage. >> +# >> +REBAR_HOST_DEPS_DIR = $(HOST_DIR)/usr/share/rebar/deps >> +REBAR_TARGET_DEPS_DIR = $(STAGING_DIR)/usr/share/rebar/deps > > Rather than having those paths, why don't we point directly rebar at > $(STAGING_DIR)/usr/lib/erlang/lib/ ? This directory already contains > - directory for each package, and we would only > have to create a symlink --> -. > > But maybe it's cleaner to have something completely separate, I don't know. > Indeed, this is to keep $(TARGET_DIR)/usr/lib/erlang/lib directory clean from unnecessary symlinks. I'm not even sure it won't break some erlang programs if we add symlinks there. At least, there is none in my Erlang installation. Maybe some Erlang guru can give its opinion on this? -- Johan