From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F86BC4360F for ; Wed, 20 Mar 2019 00:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CB652085A for ; Wed, 20 Mar 2019 00:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Bur//thX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727425AbfCTAHD (ORCPT ); Tue, 19 Mar 2019 20:07:03 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:35253 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727283AbfCTAHC (ORCPT ); Tue, 19 Mar 2019 20:07:02 -0400 Received: by mail-it1-f196.google.com with SMTP id w15so5786235itc.0 for ; Tue, 19 Mar 2019 17:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eXp5qzoLPE5k4y/K+1OpvTbOH6oNQxSHAXnNXH0YvjQ=; b=Bur//thXopzVgwZJB7yIAIDhmYXnRCW6LthfE+610t5jV9d54r7SkeAhSSh8y7m5Zi /VYoJUghb4zWk2ojIaQffbFmDWXT5+bSZxdnlF7xlaiuqSmcuXM7hfN8cGLJdRvmIci9 9clf/LGQ2TUf6AkWFIeRNei5APFL9r/bwC/QYUd3l50LdBZS9ZToLA6jD3+rtGvnqm4t Hvbd1dGMzUi904201WtqeTnm2oO2HTyGosAFtQKafrUe5JlbyCWgfcLxhCjEOItETDoJ fLwgwJu4UfNt1ZvkV5b94Nt2z/ESi1u4CI5ogvLA6g7WQlp0a6cLY4DS2b4oiX68xyV5 nG+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eXp5qzoLPE5k4y/K+1OpvTbOH6oNQxSHAXnNXH0YvjQ=; b=Kj/pKxBhIETHck14UQ7UW1RsnK7VvanL1dmkOsNm4s5jRkBfccoX0FVvecbCsCsjEq nLiatC+eUkoqfBqywV10V/dQ4+YjT6Ud8gcgMbkUacQb0B5TiTGxBMbBZJTGSm8tt4iI OQmh3UKMbAdlqFkpNnVYKyzea/9m4NfaDa9LXO6X7inM6cPoOti+sV9RT0p0nxazXDdY vdDUdER87TuTvexLEw7bKT/JRsAFksT+TZ0KJGZY/EVM/fr/G9plEyWmywcfreFWx9bu k1H1dDAn4U2YdGu6ci3MdkIXKL3pzafTah1w9Ry/WqsxrKEJrljQzRKnF75rp5UaF+HL nWSQ== X-Gm-Message-State: APjAAAWfi8q31hQ/ogPSXop8HuLXZwzC1wV28OLja5uLzgp7CPtCLfhO xLMNDbn6jCjk1NzMvFSseeCOHkIpLDTVnVM9spdUzQ== X-Google-Smtp-Source: APXvYqxACcBTRJSVb4DHcEzY2QbcyAKr+kyAJ4K2La3j+RkpHtiIIgkTpuc49OGxv/1+jAeKgj6GGDSbgMHi8Zacago= X-Received: by 2002:a24:3c53:: with SMTP id m80mr3376403ita.102.1553040421935; Tue, 19 Mar 2019 17:07:01 -0700 (PDT) MIME-Version: 1.0 References: <20190319235619.260832-1-surenb@google.com> <20190319235619.260832-2-surenb@google.com> <20190320110249.652ec153@canb.auug.org.au> In-Reply-To: <20190320110249.652ec153@canb.auug.org.au> From: Suren Baghdasaryan Date: Tue, 19 Mar 2019 17:06:50 -0700 Message-ID: Subject: Re: [PATCH v6 1/7] psi: introduce state_mask to represent stalled psi states To: Stephen Rothwell Cc: Greg Kroah-Hartman , Tejun Heo , lizefan@huawei.com, Johannes Weiner , axboe@kernel.dk, dennis@kernel.org, Dennis Zhou , Ingo Molnar , Peter Zijlstra , Andrew Morton , Jonathan Corbet , cgroups@vger.kernel.org, linux-mm , linux-doc@vger.kernel.org, LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2019 at 5:02 PM Stephen Rothwell wrote: > > Hi Suren, Hi Stephen, > On Tue, 19 Mar 2019 16:56:13 -0700 Suren Baghdasaryan wrote: > > > > The psi monitoring patches will need to determine the same states as > > record_times(). To avoid calculating them twice, maintain a state mask > > that can be consulted cheaply. Do this in a separate patch to keep the > > churn in the main feature patch at a minimum. > > > > This adds 4-byte state_mask member into psi_group_cpu struct which results > > in its first cacheline-aligned part becoming 52 bytes long. Add explicit > > values to enumeration element counters that affect psi_group_cpu struct > > size. > > > > Link: http://lkml.kernel.org/r/20190124211518.244221-4-surenb@google.com > > Signed-off-by: Suren Baghdasaryan > > Acked-by: Johannes Weiner > > Cc: Dennis Zhou > > Cc: Ingo Molnar > > Cc: Jens Axboe > > Cc: Li Zefan > > Cc: Peter Zijlstra > > Cc: Tejun Heo > > Signed-off-by: Andrew Morton > > Signed-off-by: Stephen Rothwell > > This last SOB line should not be here ... it is only there on the > original patch because I import Andrew's quilt series into linux-next. Sorry about that. This particular patch has not changed since then, that's why I kept all the lines there. Please let me know if I should remove it and re-post the patchset. Thanks, Suren. > -- > Cheers, > Stephen Rothwell > > -- > You received this message because you are subscribed to the Google Groups "kernel-team" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suren Baghdasaryan Subject: Re: [PATCH v6 1/7] psi: introduce state_mask to represent stalled psi states Date: Tue, 19 Mar 2019 17:06:50 -0700 Message-ID: References: <20190319235619.260832-1-surenb@google.com> <20190319235619.260832-2-surenb@google.com> <20190320110249.652ec153@canb.auug.org.au> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eXp5qzoLPE5k4y/K+1OpvTbOH6oNQxSHAXnNXH0YvjQ=; b=Bur//thXopzVgwZJB7yIAIDhmYXnRCW6LthfE+610t5jV9d54r7SkeAhSSh8y7m5Zi /VYoJUghb4zWk2ojIaQffbFmDWXT5+bSZxdnlF7xlaiuqSmcuXM7hfN8cGLJdRvmIci9 9clf/LGQ2TUf6AkWFIeRNei5APFL9r/bwC/QYUd3l50LdBZS9ZToLA6jD3+rtGvnqm4t Hvbd1dGMzUi904201WtqeTnm2oO2HTyGosAFtQKafrUe5JlbyCWgfcLxhCjEOItETDoJ fLwgwJu4UfNt1ZvkV5b94Nt2z/ESi1u4CI5ogvLA6g7WQlp0a6cLY4DS2b4oiX68xyV5 nG+w== In-Reply-To: <20190320110249.652ec153@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stephen Rothwell Cc: Greg Kroah-Hartman , Tejun Heo , lizefan@huawei.com, Johannes Weiner , axboe@kernel.dk, dennis@kernel.org, Dennis Zhou , Ingo Molnar , Peter Zijlstra , Andrew Morton , Jonathan Corbet , cgroups@vger.kernel.org, linux-mm , linux-doc@vger.kernel.org, LKML , kernel-team On Tue, Mar 19, 2019 at 5:02 PM Stephen Rothwell wrote: > > Hi Suren, Hi Stephen, > On Tue, 19 Mar 2019 16:56:13 -0700 Suren Baghdasaryan wrote: > > > > The psi monitoring patches will need to determine the same states as > > record_times(). To avoid calculating them twice, maintain a state mask > > that can be consulted cheaply. Do this in a separate patch to keep the > > churn in the main feature patch at a minimum. > > > > This adds 4-byte state_mask member into psi_group_cpu struct which results > > in its first cacheline-aligned part becoming 52 bytes long. Add explicit > > values to enumeration element counters that affect psi_group_cpu struct > > size. > > > > Link: http://lkml.kernel.org/r/20190124211518.244221-4-surenb@google.com > > Signed-off-by: Suren Baghdasaryan > > Acked-by: Johannes Weiner > > Cc: Dennis Zhou > > Cc: Ingo Molnar > > Cc: Jens Axboe > > Cc: Li Zefan > > Cc: Peter Zijlstra > > Cc: Tejun Heo > > Signed-off-by: Andrew Morton > > Signed-off-by: Stephen Rothwell > > This last SOB line should not be here ... it is only there on the > original patch because I import Andrew's quilt series into linux-next. Sorry about that. This particular patch has not changed since then, that's why I kept all the lines there. Please let me know if I should remove it and re-post the patchset. Thanks, Suren. > -- > Cheers, > Stephen Rothwell > > -- > You received this message because you are subscribed to the Google Groups "kernel-team" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.