From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C59DC636CA for ; Sun, 18 Jul 2021 21:26:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4414360E09 for ; Sun, 18 Jul 2021 21:26:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232613AbhGRV3B (ORCPT ); Sun, 18 Jul 2021 17:29:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbhGRV3A (ORCPT ); Sun, 18 Jul 2021 17:29:00 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9575C061762 for ; Sun, 18 Jul 2021 14:26:01 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id c16so17799754ybl.9 for ; Sun, 18 Jul 2021 14:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eGxqoewCd9mhFWgt/ehslfj46aucbxn1D+/d7qW9O88=; b=df57gXl4ZzkvkZyhsxlQQF7U9VmDfcRkVljcTPIjcrGf37NyTgxTFZj+G8Ml/mTcxY RWsy0tqZSs/6kHR/mBrtERPFADvucC9akxtOwz0tT6148Jcd17t8RO8z3HO2oq2tjUov +9vXOGMPkWXu7QOoq0jdSSZarSP4I+AKB6NbEwcpIo/Qz1hRh/qFwfp1UqcXA4ZlxZ+H HHRjqBSPiDlOVEWVdDP5CqreuQEUyppyddaR640otpripVPHT/1+VYieLA5Ojndsc22c xUN/nyK8EMwWKZbpOpXdrjfIYiAqT3jgGe/MyQ4uxM2svHfA5luxO3V/y1NbB0Ri9JRJ /yYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eGxqoewCd9mhFWgt/ehslfj46aucbxn1D+/d7qW9O88=; b=DkopysJX27Ivopc9pjTcr2MuyNE3ZevI7ZiuRG1z2r98dRDBD0QNzXm98834w7EI62 vA41KJk2fyCxeutiJ4N+Jt1gtlLkWyR6sdoUTeROJD+UktsVKuT9RsUssEGkW/5ylUpR PhUrGrBmx56sd2YllUWlIeXYKDMV1w+RKhqXugzCa3xDcTU5eN0QS8FLzGl3xPuIRI6h zOXSgJW9oj4XHp14rg4flHHZEEQYsbBzRaoJzFhSAbFjN0+/MwHU3ldM4Slx3NTHZUq9 cJ7W0XXCI3eAg0bJgfOOk8Vc1guGvghEN2ZfiKWY/DMzGCuMFztiSYe5Cj38PyLmpMea Cxeg== X-Gm-Message-State: AOAM530gth1acRMEpACqaI1AtVbKKgwOeZJnvc/IXwMwr7ikn/mB+TOM AQTY5+V5VEb67dW4wVBlZsEtDcRx6sy2gbhIN5qFeQ== X-Google-Smtp-Source: ABdhPJzG/WkV228ZnkTQT7/9F5qD3UkoOrEL3ZDcaj1Q5ZR1yH1Ha91RDJq+ac4aRtYMNYmL0XXBbhg3846E9AuIQPo= X-Received: by 2002:a25:83ca:: with SMTP id v10mr27596137ybm.84.1626643560918; Sun, 18 Jul 2021 14:26:00 -0700 (PDT) MIME-Version: 1.0 References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-2-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Sun, 18 Jul 2021 14:25:50 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config To: Matthew Wilcox Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , apopple@nvidia.com, Minchan Kim , Miaohe Lin , LKML , cgroups mailinglist , linux-mm , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 18, 2021 at 9:56 AM Matthew Wilcox wrote: > > On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote: > > @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg, > > } > > > > /** > > - * mem_cgroup_charge - charge a newly allocated page to a cgroup > > + * __mem_cgroup_charge - charge a newly allocated page to a cgroup > > * @page: page to charge > > * @mm: mm context of the victim > > * @gfp_mask: reclaim mode > > This patch conflicts with the folio work, so I'm just rebasing the > folio patches on top of this, and I think this part of the patch is a > mistake. We don't want to document the __mem_cgroup_charge() function. > That's an implementation detail. This patch should instead have moved the > kernel-doc to memcontrol.h and continued to document mem_cgroup_charge(). Ack. There was a v4 version of this patch: https://lore.kernel.org/patchwork/patch/1458907 which was picked up by Andrew already. If others agree that documentation should be moved into the header file then I'll gladly post another version. Or I can post a separate patch moving the documentation only. Whatever works best. Andrew, Michal, Johannes, WDYT? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC30C636C8 for ; Sun, 18 Jul 2021 21:26:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 522DE60FEA for ; Sun, 18 Jul 2021 21:26:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 522DE60FEA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D62588D00F5; Sun, 18 Jul 2021 17:26:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEB628D00EC; Sun, 18 Jul 2021 17:26:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3D6C8D00F5; Sun, 18 Jul 2021 17:26:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 888218D00EC for ; Sun, 18 Jul 2021 17:26:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2A07118186D52 for ; Sun, 18 Jul 2021 21:26:02 +0000 (UTC) X-FDA: 78376991364.12.C0C0AEB Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf24.hostedemail.com (Postfix) with ESMTP id D93D0B00009E for ; Sun, 18 Jul 2021 21:26:01 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id t186so24535528ybf.2 for ; Sun, 18 Jul 2021 14:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eGxqoewCd9mhFWgt/ehslfj46aucbxn1D+/d7qW9O88=; b=df57gXl4ZzkvkZyhsxlQQF7U9VmDfcRkVljcTPIjcrGf37NyTgxTFZj+G8Ml/mTcxY RWsy0tqZSs/6kHR/mBrtERPFADvucC9akxtOwz0tT6148Jcd17t8RO8z3HO2oq2tjUov +9vXOGMPkWXu7QOoq0jdSSZarSP4I+AKB6NbEwcpIo/Qz1hRh/qFwfp1UqcXA4ZlxZ+H HHRjqBSPiDlOVEWVdDP5CqreuQEUyppyddaR640otpripVPHT/1+VYieLA5Ojndsc22c xUN/nyK8EMwWKZbpOpXdrjfIYiAqT3jgGe/MyQ4uxM2svHfA5luxO3V/y1NbB0Ri9JRJ /yYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eGxqoewCd9mhFWgt/ehslfj46aucbxn1D+/d7qW9O88=; b=N9+qAWZxJ1/cqA/NDjON7Wehs2EvGl/N9mYiU0vmv76aMPZxJ9ZHVVXYYi/BEEVS1y y/Nb+nNkGDMDpiCrt8waUwjXvCSugP+QAJBGDqi8cxjP+bF9mrnLluHKpyOmTu8utPQ1 UKxl1d0rc/Oi01iCOb4WmlebO9Q/xUGedC/JXfFk76K73ai3Drkno/NCpV7SMYzLhupa uwkGULRW07RGbOgqepNxXNw1G+rH7TiqUZPkKsLF7KabyPhAk+HRZiQKethNt/oaRgly /qV17SmbuZPaRzBWt4MBBKvLiO8nS2boPx7t3GUewCAYpA6wsaoZeymk1vo5bZS3mkLH pUnQ== X-Gm-Message-State: AOAM530j40EmZwGS7cjhl/WkOM/IHGCoaxshUFgHW0CmXc3Cq6OdI+2A 7V9yIjPcjVCn7gjwicBek3ospNOYJ8LHXCYBd553Wg== X-Google-Smtp-Source: ABdhPJzG/WkV228ZnkTQT7/9F5qD3UkoOrEL3ZDcaj1Q5ZR1yH1Ha91RDJq+ac4aRtYMNYmL0XXBbhg3846E9AuIQPo= X-Received: by 2002:a25:83ca:: with SMTP id v10mr27596137ybm.84.1626643560918; Sun, 18 Jul 2021 14:26:00 -0700 (PDT) MIME-Version: 1.0 References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-2-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Sun, 18 Jul 2021 14:25:50 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config To: Matthew Wilcox Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , apopple@nvidia.com, Minchan Kim , Miaohe Lin , LKML , cgroups mailinglist , linux-mm , kernel-team Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=df57gXl4; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam05 X-Stat-Signature: 34jrpzizai3zmowuyks9p3su11t9cozu X-Rspamd-Queue-Id: D93D0B00009E X-HE-Tag: 1626643561-884075 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 18, 2021 at 9:56 AM Matthew Wilcox wrote: > > On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote: > > @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg, > > } > > > > /** > > - * mem_cgroup_charge - charge a newly allocated page to a cgroup > > + * __mem_cgroup_charge - charge a newly allocated page to a cgroup > > * @page: page to charge > > * @mm: mm context of the victim > > * @gfp_mask: reclaim mode > > This patch conflicts with the folio work, so I'm just rebasing the > folio patches on top of this, and I think this part of the patch is a > mistake. We don't want to document the __mem_cgroup_charge() function. > That's an implementation detail. This patch should instead have moved the > kernel-doc to memcontrol.h and continued to document mem_cgroup_charge(). Ack. There was a v4 version of this patch: https://lore.kernel.org/patchwork/patch/1458907 which was picked up by Andrew already. If others agree that documentation should be moved into the header file then I'll gladly post another version. Or I can post a separate patch moving the documentation only. Whatever works best. Andrew, Michal, Johannes, WDYT? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suren Baghdasaryan Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config Date: Sun, 18 Jul 2021 14:25:50 -0700 Message-ID: References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-2-surenb@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eGxqoewCd9mhFWgt/ehslfj46aucbxn1D+/d7qW9O88=; b=df57gXl4ZzkvkZyhsxlQQF7U9VmDfcRkVljcTPIjcrGf37NyTgxTFZj+G8Ml/mTcxY RWsy0tqZSs/6kHR/mBrtERPFADvucC9akxtOwz0tT6148Jcd17t8RO8z3HO2oq2tjUov +9vXOGMPkWXu7QOoq0jdSSZarSP4I+AKB6NbEwcpIo/Qz1hRh/qFwfp1UqcXA4ZlxZ+H HHRjqBSPiDlOVEWVdDP5CqreuQEUyppyddaR640otpripVPHT/1+VYieLA5Ojndsc22c xUN/nyK8EMwWKZbpOpXdrjfIYiAqT3jgGe/MyQ4uxM2svHfA5luxO3V/y1NbB0Ri9JRJ /yYw== In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , apopple@nvidia.com, Minchan Kim , Miaohe Lin , LKML , cgroups mailinglist , linux-mm , kernel-team On Sun, Jul 18, 2021 at 9:56 AM Matthew Wilcox wrote: > > On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote: > > @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg, > > } > > > > /** > > - * mem_cgroup_charge - charge a newly allocated page to a cgroup > > + * __mem_cgroup_charge - charge a newly allocated page to a cgroup > > * @page: page to charge > > * @mm: mm context of the victim > > * @gfp_mask: reclaim mode > > This patch conflicts with the folio work, so I'm just rebasing the > folio patches on top of this, and I think this part of the patch is a > mistake. We don't want to document the __mem_cgroup_charge() function. > That's an implementation detail. This patch should instead have moved the > kernel-doc to memcontrol.h and continued to document mem_cgroup_charge(). Ack. There was a v4 version of this patch: https://lore.kernel.org/patchwork/patch/1458907 which was picked up by Andrew already. If others agree that documentation should be moved into the header file then I'll gladly post another version. Or I can post a separate patch moving the documentation only. Whatever works best. Andrew, Michal, Johannes, WDYT?