From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D10BC4320A for ; Fri, 23 Jul 2021 01:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05A4F60EBD for ; Fri, 23 Jul 2021 01:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233053AbhGWAfg (ORCPT ); Thu, 22 Jul 2021 20:35:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232905AbhGWAff (ORCPT ); Thu, 22 Jul 2021 20:35:35 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 113E2C061757 for ; Thu, 22 Jul 2021 18:16:09 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id c204so7436944ybb.4 for ; Thu, 22 Jul 2021 18:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3GzZUiWRloPQrXBdUYorJDMZSlFJKnkE4RwHu5ZYLM4=; b=IAlCVu8/mqkfWitvqAfF6S/1PxmHsrL1hI3yjJtBfzQ89rf2bO8G3Vv4EmdUTjyCv4 vErCIaWL0RSz/07P0pjWzM0Szka8jRxHUncJUX/VcOsSXI5bqBfHCc9VrH8BuzHdCMxa xScBENnfqpq3t6Wz9djsWnyugd8bYwvHF00f+WSd7eXfSISchVbTd792koY6PtUhCMB8 F61QuaR2C7IkVoGlrIu/WkstgmvAzHIbXn9LQjmCyQAZCpNOgj78mN7vjhDzIP6ihwZt KIlL4qDOWPdRpnjLt4XbDSd5gL4XLGVADSaqIc3WQyVavvmEkIGrZSSo6+Gu+FqGME82 zryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3GzZUiWRloPQrXBdUYorJDMZSlFJKnkE4RwHu5ZYLM4=; b=tc0RIqbQm661cTxPnzqvK3t0JWXbtt0QAQ1QiWyZXNlAYUK4LHSc9NdKDedaSh0/Je iQhyixSBSrD4u9/mgbkb7sHwVwiQ0vNuc5hpFjuqLwRvyIycIt+KVRTe3xQNadqz+KO0 YSlvMV+tc56Qj9JIWoJ598rVgoUtq3Mm/AcpFprYa2bRHdlWYwMj3fXfMKWWlV1iUWBc LakCtaorxhNaVdGVskA/kwD2q6KdVJKKNZvY8HEmB0+2zbEbxP4A6V30FBYf7MBbR0Wr 2gYtBreEKP/3CHouQP9dC1TIKZZ/Lk+pAw2yL+aVwh/qKFQYVj//pyGy+9Cw+LZEDo88 mJaQ== X-Gm-Message-State: AOAM531yvZwEeSutckmhPi8zVXZIs8n4ku96lst0roThCGuBMZ1P8p7Y xvji4chkVzilLoWWhJSioR010jECxLGDneS6TRqi4Q== X-Google-Smtp-Source: ABdhPJyq45hMHallqmqyOyy6fSXBjwl/uWwFFwTNoBAyZ8V7mgCKBB69jXsoebr7Ozr+T0JmNGzVP/AhVgeCaqQB5Z0= X-Received: by 2002:a25:ba08:: with SMTP id t8mr3115977ybg.111.1627002968071; Thu, 22 Jul 2021 18:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20210718214134.2619099-1-surenb@google.com> <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> <20210720160707.2332738708948f7d865d67c1@linux-foundation.org> <0ee6775b-589c-3243-1c01-aafad5eecb73@redhat.com> <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 22 Jul 2021 18:15:57 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease To: Andrew Morton Cc: David Hildenbrand , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 1:59 PM Suren Baghdasaryan wrote: > > On Wed, Jul 21, 2021 at 1:51 PM Andrew Morton wrote: > > > > On Wed, 21 Jul 2021 13:19:35 -0700 Suren Baghdasaryan wrote: > > > > > > > This would not require moving other functions. > > > > > Would that be better than the current approach or the forward declaration? > > > > > > > > IMHO that could be an easy, possible alternative. > > > > > > Andrew, others? Should I follow this path instead? > > > > Whatever you prefer ;) > > I understand David's concern too well to ignore it, so I prefer to > follow this middle-ground approach if you don't mind :) v3 with the refactoring is posted at https://lore.kernel.org/patchwork/project/lkml/list/?series=509230 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF25C4338F for ; Fri, 23 Jul 2021 01:16:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2435160EBD for ; Fri, 23 Jul 2021 01:16:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2435160EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BB5B16B005D; Thu, 22 Jul 2021 21:16:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3D326B006C; Thu, 22 Jul 2021 21:16:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DEDC6B0070; Thu, 22 Jul 2021 21:16:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 8530B6B005D for ; Thu, 22 Jul 2021 21:16:09 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3474B22030 for ; Fri, 23 Jul 2021 01:16:09 +0000 (UTC) X-FDA: 78392086458.04.232A61D Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf28.hostedemail.com (Postfix) with ESMTP id ED366900AE9E for ; Fri, 23 Jul 2021 01:16:08 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id k184so11083741ybf.12 for ; Thu, 22 Jul 2021 18:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3GzZUiWRloPQrXBdUYorJDMZSlFJKnkE4RwHu5ZYLM4=; b=IAlCVu8/mqkfWitvqAfF6S/1PxmHsrL1hI3yjJtBfzQ89rf2bO8G3Vv4EmdUTjyCv4 vErCIaWL0RSz/07P0pjWzM0Szka8jRxHUncJUX/VcOsSXI5bqBfHCc9VrH8BuzHdCMxa xScBENnfqpq3t6Wz9djsWnyugd8bYwvHF00f+WSd7eXfSISchVbTd792koY6PtUhCMB8 F61QuaR2C7IkVoGlrIu/WkstgmvAzHIbXn9LQjmCyQAZCpNOgj78mN7vjhDzIP6ihwZt KIlL4qDOWPdRpnjLt4XbDSd5gL4XLGVADSaqIc3WQyVavvmEkIGrZSSo6+Gu+FqGME82 zryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3GzZUiWRloPQrXBdUYorJDMZSlFJKnkE4RwHu5ZYLM4=; b=mSCvTbAE2BtXpUWjPdIH75QT1yzLKdI64GPicsblBP9MkedbX5WdULbZtVRqGt/Sf5 uzy7jdfP27ffJP17ZQncw6EmBCUKwEUrP7BqRCn9MthS1zolt4E3q76M8rwcf8jWr8IZ ElshaWatXeoUdr02rfKl7cioqD2/KDiPhPkc4KDabZI3aX256NDlbCiqMVT/DO7javTI A1GuFnC3mHYTi0fdmR8bFw7NpZiqv6fXN+n9Rie0LPvvVWlqZA42kLs21tbmetXFAXy7 /XhEf7IASxfyzseVEN5JdY+vn1Pk3kB1XJZ/f8Qmf7u729fzGCTZ63tYycMWMR51Pozd B/CQ== X-Gm-Message-State: AOAM532VrjTT1T0n3k5z+yUpB15qBXeEhnAGd2smO3jOwgrFQVvsP0uu EwFXvoa9wGdbHBr5T6N4OJCO1qISjYZLUenxXPr4VQ== X-Google-Smtp-Source: ABdhPJyq45hMHallqmqyOyy6fSXBjwl/uWwFFwTNoBAyZ8V7mgCKBB69jXsoebr7Ozr+T0JmNGzVP/AhVgeCaqQB5Z0= X-Received: by 2002:a25:ba08:: with SMTP id t8mr3115977ybg.111.1627002968071; Thu, 22 Jul 2021 18:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20210718214134.2619099-1-surenb@google.com> <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> <20210720160707.2332738708948f7d865d67c1@linux-foundation.org> <0ee6775b-589c-3243-1c01-aafad5eecb73@redhat.com> <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 22 Jul 2021 18:15:57 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease To: Andrew Morton Cc: David Hildenbrand , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="IAlCVu8/"; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam05 X-Stat-Signature: zruju7g4qyaruafhn74a5g41jidzqoo5 X-Rspamd-Queue-Id: ED366900AE9E X-HE-Tag: 1627002968-275623 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 21, 2021 at 1:59 PM Suren Baghdasaryan wrote: > > On Wed, Jul 21, 2021 at 1:51 PM Andrew Morton wrote: > > > > On Wed, 21 Jul 2021 13:19:35 -0700 Suren Baghdasaryan wrote: > > > > > > > This would not require moving other functions. > > > > > Would that be better than the current approach or the forward declaration? > > > > > > > > IMHO that could be an easy, possible alternative. > > > > > > Andrew, others? Should I follow this path instead? > > > > Whatever you prefer ;) > > I understand David's concern too well to ignore it, so I prefer to > follow this middle-ground approach if you don't mind :) v3 with the refactoring is posted at https://lore.kernel.org/patchwork/project/lkml/list/?series=509230