From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8079C636C8 for ; Sun, 18 Jul 2021 21:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD0E561166 for ; Sun, 18 Jul 2021 21:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233247AbhGRVfP (ORCPT ); Sun, 18 Jul 2021 17:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232898AbhGRVfN (ORCPT ); Sun, 18 Jul 2021 17:35:13 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E68BC061762 for ; Sun, 18 Jul 2021 14:32:14 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id b13so24573187ybk.4 for ; Sun, 18 Jul 2021 14:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2+/+LhyG5jvyV2FwgkrvUngRXo+GiZNFji+6rwemUzs=; b=vedZyKz3lL38LRdICKgLFxrEXvjXGc5BgkO2T78tkSNG8sI2Hlk33sbY4W5Y63syJE mURxKSpo24wSQ9o/ud5y4QDgt6SvMpf9VVsh6F507XJUpmQHNL0dW9oxTms5nlK0xUSc PuHLZCQNZUwHfduWT20rlRZOCXMBJrXKRIYo8Mb7fDiylsOGnIrE0HgtfxVul6uQd/rV 1LG0LAQ4sJ9oJ6jQ9RuzMIK2dpGVBQhO5zFqDDnpLK9olnfgkR0dUTgG7hbqRmoeiac5 zKoaJ6wS4qh1aAk9zJR/Tn2YTD8GhmJhjazXSfsyDxBgXeizJ4jqLkfMgQDSenGJ6lCg SJlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2+/+LhyG5jvyV2FwgkrvUngRXo+GiZNFji+6rwemUzs=; b=XmaTbaVNKYIktUa7FreQi+SecnlKMa89oLvDv/q1AtnHUsZBArvKVaPY+Uzp2LLobm D2+D9WeplvOSXqFpvCPYVvyurW8T/1ZGCVGht7Khm9XxwJ7RBUNtNZy8p8T7vRByxBJk GH9RhbF9aQE6ku3MMN5A46MJan2Trvo9x+wIs7QZvtnGA8ZU+6Jlt5GGQPKPKeSKnlmr CL0QColg/8MxRm/iDH8WK7bz2IvqxoHLP0PgQ40l4P6LCwsEveNk6H7IILLz7817a9xR 3g0rOTh1M5w/TqNdus9QASi5Cchww4e1Vi/5gPHoLyKhgmtXooRstTYlr4BBNLMmOkhF 5HjA== X-Gm-Message-State: AOAM530C/gtcUYsKFzdjHhm60wHjXzVypRJpCyRrrv+rOeyOzuScf9I6 3BkLKmb+YxU/j8vKL0ASLY1Qo23h8CQWRZQec2oYmQ== X-Google-Smtp-Source: ABdhPJwcutQSQe7gkLcIvJWxIAQckzSBIZ4Ug/aclHp9CEPkdqSJ9KU5lsiYI1BnbeWezs1no9qujWoToRyP4xUylQw= X-Received: by 2002:a25:71c4:: with SMTP id m187mr26883038ybc.397.1626643933133; Sun, 18 Jul 2021 14:32:13 -0700 (PDT) MIME-Version: 1.0 References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-2-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Sun, 18 Jul 2021 14:32:02 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config To: Matthew Wilcox Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , apopple@nvidia.com, Minchan Kim , Miaohe Lin , LKML , cgroups mailinglist , linux-mm , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 18, 2021 at 2:30 PM Matthew Wilcox wrote: > > On Sun, Jul 18, 2021 at 02:25:50PM -0700, Suren Baghdasaryan wrote: > > On Sun, Jul 18, 2021 at 9:56 AM Matthew Wilcox wrote: > > > > > > On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote: > > > > @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg, > > > > } > > > > > > > > /** > > > > - * mem_cgroup_charge - charge a newly allocated page to a cgroup > > > > + * __mem_cgroup_charge - charge a newly allocated page to a cgroup > > > > * @page: page to charge > > > > * @mm: mm context of the victim > > > > * @gfp_mask: reclaim mode > > > > > > This patch conflicts with the folio work, so I'm just rebasing the > > > folio patches on top of this, and I think this part of the patch is a > > > mistake. We don't want to document the __mem_cgroup_charge() function. > > > That's an implementation detail. This patch should instead have moved the > > > kernel-doc to memcontrol.h and continued to document mem_cgroup_charge(). > > > > Ack. > > There was a v4 version of this patch: > > https://lore.kernel.org/patchwork/patch/1458907 which was picked up by > > Andrew already. If others agree that documentation should be moved > > into the header file then I'll gladly post another version. Or I can > > post a separate patch moving the documentation only. Whatever works > > best. Andrew, Michal, Johannes, WDYT? > > At this point, I've moved the documentation as part of the folio patch. > I'd rather not redo that patch again ... Ok. If you need me to redo anything please let me know. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2C4C636C8 for ; Sun, 18 Jul 2021 21:32:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5693E61166 for ; Sun, 18 Jul 2021 21:32:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5693E61166 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E44098D00F9; Sun, 18 Jul 2021 17:32:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF3FF8D00EC; Sun, 18 Jul 2021 17:32:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6D8F8D00F9; Sun, 18 Jul 2021 17:32:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id A10BE8D00EC for ; Sun, 18 Jul 2021 17:32:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4E59523E72 for ; Sun, 18 Jul 2021 21:32:14 +0000 (UTC) X-FDA: 78377006988.18.6FDC8E0 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf10.hostedemail.com (Postfix) with ESMTP id 0B3FA600199E for ; Sun, 18 Jul 2021 21:32:13 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id c16so17816634ybl.9 for ; Sun, 18 Jul 2021 14:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2+/+LhyG5jvyV2FwgkrvUngRXo+GiZNFji+6rwemUzs=; b=vedZyKz3lL38LRdICKgLFxrEXvjXGc5BgkO2T78tkSNG8sI2Hlk33sbY4W5Y63syJE mURxKSpo24wSQ9o/ud5y4QDgt6SvMpf9VVsh6F507XJUpmQHNL0dW9oxTms5nlK0xUSc PuHLZCQNZUwHfduWT20rlRZOCXMBJrXKRIYo8Mb7fDiylsOGnIrE0HgtfxVul6uQd/rV 1LG0LAQ4sJ9oJ6jQ9RuzMIK2dpGVBQhO5zFqDDnpLK9olnfgkR0dUTgG7hbqRmoeiac5 zKoaJ6wS4qh1aAk9zJR/Tn2YTD8GhmJhjazXSfsyDxBgXeizJ4jqLkfMgQDSenGJ6lCg SJlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2+/+LhyG5jvyV2FwgkrvUngRXo+GiZNFji+6rwemUzs=; b=KI7dMQR0HdqIO482vyFV21OVIYLwHI0PR69C2djkC8f4cFyWpgN6Kfed0e91h/IKzk FKLf80ou5W9N5d7eJBBDdOurLpJwIO4/WQAFF5tsHQiD69f8fg7Peir1rYFs8Hs1hJVl 5NnH0QtH2pRrKUiegCwpwf51rpIuB7utDkrvP3fkNmhQ1UYHKwwtx/qoUNxmbnmnyAb+ qL1/etIFTlGQtCIoE7qwSXadi2vDn2B4zytIO8F7vIwGgCP1Do1wmrJnZKqQSE+yHbuf cYp1E8bvZpxzzm0L/GdQZbrMT3G7kUWtPv9im8TAY+pzYj2QYM5dDHDz8GyDNBelUXFB ApFA== X-Gm-Message-State: AOAM530TlgOGXv7yPxfAtyyDbj58of2SOubBIBRJhthhlCkgzaZ+7jnZ sq6YhNSD+AZWQxbTRH3/cWm1pJ+6teWW0UwT9ergUA== X-Google-Smtp-Source: ABdhPJwcutQSQe7gkLcIvJWxIAQckzSBIZ4Ug/aclHp9CEPkdqSJ9KU5lsiYI1BnbeWezs1no9qujWoToRyP4xUylQw= X-Received: by 2002:a25:71c4:: with SMTP id m187mr26883038ybc.397.1626643933133; Sun, 18 Jul 2021 14:32:13 -0700 (PDT) MIME-Version: 1.0 References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-2-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Sun, 18 Jul 2021 14:32:02 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config To: Matthew Wilcox Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , apopple@nvidia.com, Minchan Kim , Miaohe Lin , LKML , cgroups mailinglist , linux-mm , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0B3FA600199E X-Stat-Signature: 4h5jfjposcsm8nmuzbwqcsg4mm8edba9 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=vedZyKz3; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1626643933-854763 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 18, 2021 at 2:30 PM Matthew Wilcox wrote: > > On Sun, Jul 18, 2021 at 02:25:50PM -0700, Suren Baghdasaryan wrote: > > On Sun, Jul 18, 2021 at 9:56 AM Matthew Wilcox wrote: > > > > > > On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote: > > > > @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg, > > > > } > > > > > > > > /** > > > > - * mem_cgroup_charge - charge a newly allocated page to a cgroup > > > > + * __mem_cgroup_charge - charge a newly allocated page to a cgroup > > > > * @page: page to charge > > > > * @mm: mm context of the victim > > > > * @gfp_mask: reclaim mode > > > > > > This patch conflicts with the folio work, so I'm just rebasing the > > > folio patches on top of this, and I think this part of the patch is a > > > mistake. We don't want to document the __mem_cgroup_charge() function. > > > That's an implementation detail. This patch should instead have moved the > > > kernel-doc to memcontrol.h and continued to document mem_cgroup_charge(). > > > > Ack. > > There was a v4 version of this patch: > > https://lore.kernel.org/patchwork/patch/1458907 which was picked up by > > Andrew already. If others agree that documentation should be moved > > into the header file then I'll gladly post another version. Or I can > > post a separate patch moving the documentation only. Whatever works > > best. Andrew, Michal, Johannes, WDYT? > > At this point, I've moved the documentation as part of the folio patch. > I'd rather not redo that patch again ... Ok. If you need me to redo anything please let me know. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suren Baghdasaryan Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config Date: Sun, 18 Jul 2021 14:32:02 -0700 Message-ID: References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-2-surenb@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2+/+LhyG5jvyV2FwgkrvUngRXo+GiZNFji+6rwemUzs=; b=vedZyKz3lL38LRdICKgLFxrEXvjXGc5BgkO2T78tkSNG8sI2Hlk33sbY4W5Y63syJE mURxKSpo24wSQ9o/ud5y4QDgt6SvMpf9VVsh6F507XJUpmQHNL0dW9oxTms5nlK0xUSc PuHLZCQNZUwHfduWT20rlRZOCXMBJrXKRIYo8Mb7fDiylsOGnIrE0HgtfxVul6uQd/rV 1LG0LAQ4sJ9oJ6jQ9RuzMIK2dpGVBQhO5zFqDDnpLK9olnfgkR0dUTgG7hbqRmoeiac5 zKoaJ6wS4qh1aAk9zJR/Tn2YTD8GhmJhjazXSfsyDxBgXeizJ4jqLkfMgQDSenGJ6lCg SJlQ== In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , apopple-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, Minchan Kim , Miaohe Lin , LKML , cgroups mailinglist , linux-mm , kernel-team On Sun, Jul 18, 2021 at 2:30 PM Matthew Wilcox wrote: > > On Sun, Jul 18, 2021 at 02:25:50PM -0700, Suren Baghdasaryan wrote: > > On Sun, Jul 18, 2021 at 9:56 AM Matthew Wilcox wrote: > > > > > > On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote: > > > > @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg, > > > > } > > > > > > > > /** > > > > - * mem_cgroup_charge - charge a newly allocated page to a cgroup > > > > + * __mem_cgroup_charge - charge a newly allocated page to a cgroup > > > > * @page: page to charge > > > > * @mm: mm context of the victim > > > > * @gfp_mask: reclaim mode > > > > > > This patch conflicts with the folio work, so I'm just rebasing the > > > folio patches on top of this, and I think this part of the patch is a > > > mistake. We don't want to document the __mem_cgroup_charge() function. > > > That's an implementation detail. This patch should instead have moved the > > > kernel-doc to memcontrol.h and continued to document mem_cgroup_charge(). > > > > Ack. > > There was a v4 version of this patch: > > https://lore.kernel.org/patchwork/patch/1458907 which was picked up by > > Andrew already. If others agree that documentation should be moved > > into the header file then I'll gladly post another version. Or I can > > post a separate patch moving the documentation only. Whatever works > > best. Andrew, Michal, Johannes, WDYT? > > At this point, I've moved the documentation as part of the folio patch. > I'd rather not redo that patch again ... Ok. If you need me to redo anything please let me know.