From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Abraham Subject: Re: [PATCH v5 6/6] spi: s3c64xx: add device tree support Date: Fri, 13 Jul 2012 17:08:21 +0530 Message-ID: References: <1342021265-11212-1-git-send-email-thomas.abraham@linaro.org> <1342021265-11212-7-git-send-email-thomas.abraham@linaro.org> <4FFF51EE.4080609@samsung.com> <117c01cd60ea$90f76ac0$b2e64040$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <117c01cd60ea$90f76ac0$b2e64040$%kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Kukjin Kim Cc: spi-devel-general@lists.sourceforge.net, devicetree-discuss@lists.ozlabs.org, broonie@opensource.wolfsonmicro.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rob.herring@calxeda.com, grant.likely@secretlab.ca, jaswinder.singh@linaro.org List-Id: devicetree@vger.kernel.org On 13 July 2012 16:58, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> On 13 July 2012 04:08, Kukjin Kim wrote: >> > Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems occur >> > following build error with s3c6400_defconfig. >> > >> > drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_get_dmares': >> > drivers/spi/spi-s3c64xx.c:1098: error: 'DMACH_DT_PROP' undeclared (first >> use >> > in this function) >> > drivers/spi/spi-s3c64xx.c:1098: error: (Each undeclared identifier is >> > reported only once >> > drivers/spi/spi-s3c64xx.c:1098: error: for each function it appears in.) >> > make[3]: *** [drivers/spi/spi-s3c64xx.o] Error 1 >> > make[2]: *** [drivers/spi] Error 2 >> > >> >> Dear Mr. Kim, >> >> Thanks for considering these patches to be merged via your tree. For >> the build break you mentioned above, there was a patch submitted some >> time back to handle this. The link to that patch is: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2012- >> June/102627.html. >> Could you please apply this patch also to your tree. >> > Sure, it looks good to me, will apply that then this series will be rebased > on top of that. There are six more patches that enable spi device tree support for Exynos4 and Exynos5 platforms. Could you consider to apply those patches as well. The link to those patches is: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg10851.html. Thanks, Thomas. From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.abraham@linaro.org (Thomas Abraham) Date: Fri, 13 Jul 2012 17:08:21 +0530 Subject: [PATCH v5 6/6] spi: s3c64xx: add device tree support In-Reply-To: <117c01cd60ea$90f76ac0$b2e64040$%kim@samsung.com> References: <1342021265-11212-1-git-send-email-thomas.abraham@linaro.org> <1342021265-11212-7-git-send-email-thomas.abraham@linaro.org> <4FFF51EE.4080609@samsung.com> <117c01cd60ea$90f76ac0$b2e64040$%kim@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13 July 2012 16:58, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> On 13 July 2012 04:08, Kukjin Kim wrote: >> > Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems occur >> > following build error with s3c6400_defconfig. >> > >> > drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_get_dmares': >> > drivers/spi/spi-s3c64xx.c:1098: error: 'DMACH_DT_PROP' undeclared (first >> use >> > in this function) >> > drivers/spi/spi-s3c64xx.c:1098: error: (Each undeclared identifier is >> > reported only once >> > drivers/spi/spi-s3c64xx.c:1098: error: for each function it appears in.) >> > make[3]: *** [drivers/spi/spi-s3c64xx.o] Error 1 >> > make[2]: *** [drivers/spi] Error 2 >> > >> >> Dear Mr. Kim, >> >> Thanks for considering these patches to be merged via your tree. For >> the build break you mentioned above, there was a patch submitted some >> time back to handle this. The link to that patch is: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2012- >> June/102627.html. >> Could you please apply this patch also to your tree. >> > Sure, it looks good to me, will apply that then this series will be rebased > on top of that. There are six more patches that enable spi device tree support for Exynos4 and Exynos5 platforms. Could you consider to apply those patches as well. The link to those patches is: http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg10851.html. Thanks, Thomas.