From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: aurelien.chabot@gmail.com Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 43e6f722 for ; Tue, 23 Jan 2018 01:48:39 +0000 (UTC) Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 1e1f0ce1 for ; Tue, 23 Jan 2018 01:48:39 +0000 (UTC) Received: by mail-wr0-f177.google.com with SMTP id 100so10755183wrb.7 for ; Mon, 22 Jan 2018 17:52:41 -0800 (PST) MIME-Version: 1.0 References: <20171107043817.9050-1-aurelien@chabot.fr> <68455df5-a429-09aa-308d-fc3615557530@hall-andersen.dk> In-Reply-To: From: =?UTF-8?Q?Aur=C3=A9lien_Chabot?= Date: Tue, 23 Jan 2018 01:52:30 +0000 Message-ID: Subject: Re: WireGuard root-less support for android To: Mathias Hall-Andersen Content-Type: multipart/alternative; boundary="089e082fa35c4b6493056367cdf8" Cc: wireguard@lists.zx2c4.com List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --089e082fa35c4b6493056367cdf8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Mathias, Did you had thought about the support of wireguard-go for android? I'll be happy to rebase the work I did before on wireguard-go to get that a new go. Aur=C3=A9lien On Thu, Nov 9, 2017 at 8:50 AM Aur=C3=A9lien Chabot wr= ote: > The GetUDPConn is used to forward the socket id to the Java layer. The > android API allow to protect the socket from being route to the VPN, maki= ng > the job of using the VPN as default route easy. > > About the close, good to know I am not missing something. I might spit th= e > patch then, so the bug fix doesn't get stuck with the rest. > > Aur=C3=A9lien > > On Thu, Nov 9, 2017, 04:48 Mathias Hall-Andersen > wrote: > >> Hi Aur=C3=A9lien >> >> Thanks for contributing to the wireguard-go project. >> >> I never anticipated for the implementation to be used as a library. >> This means that I either have to: >> >> 1. Settle for an API and reconsider what is exported and not. >> 2. Give no guarantees about API stability >> >> Providing the functionality as a library might be the cleanest solution >> in this case. >> One option is to have an internal package and a small exported API. >> >> Is the GetUDPConn only used to wait for the device to bind? >> >> The missing device.tun.device.Close() is indeed a bug. >> >> I will look more at your patches during the weekend, >> Thanks once again. >> >> Mathias >> > --089e082fa35c4b6493056367cdf8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Mathias,

Did you had thought about t= he support of wireguard-go for android?
I'll be happy to reba= se the work I did before on wireguard-go to get that a new go.

Aur=C3=A9lien

On Thu, Nov 9, 2017 at 8:50 AM Aur= =C3=A9lien Chabot <aurelien@chabot.fr> wrote:
The GetUDPConn is used to forward the socket id to the Jav= a layer. The android API allow to protect the socket from being route to th= e VPN, making the job of using the VPN as default route easy.

About the close, good to know I am not missing something. I = might spit the patch then, so the bug fix doesn't get stuck with the re= st.

Aur=C3=A9lien


On Thu, Nov 9, 2017, 04:48 = Mathias Hall-Andersen <mathias@hall-andersen.dk> wrote:
Hi Aur=C3=A9lien

Thanks for contributing to the wireguard-go project.

I never anticipated for the implementation to be used as a library.
This means that I either have to:

1. Settle for an API and reconsider what is exported and not.
2. Give no guarantees about API stability

Providing the functionality as a library might be the cleanest solution
in this case.
One option is to have an internal package and a small exported API.

Is the GetUDPConn only used to wait for the device to bind?

The missing device.tun.device.Close() is indeed a bug.

I will look more at your patches during the weekend,
Thanks once again.

Mathias
--089e082fa35c4b6493056367cdf8--