All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Dmitry Tunin <hanipouspilot@gmail.com>,
	Josh Boyer <jwboyer@fedoraproject.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Aaron Lu <aaron.lu@intel.com>
Subject: Re: [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA to enable, brightness keys
Date: Thu, 18 Dec 2014 13:09:24 -0500	[thread overview]
Message-ID: <CAJvTdKnejv9cKPW9sbnLswfBsWZCA1OU2os7iud9tKoq7CW+jw@mail.gmail.com> (raw)
In-Reply-To: <20141218145054.GA7745@srcf.ucam.org>

NAK on addoing this acpi_osi= quirk to upstream Linux.

The reason is that problem is being actively debugged.
Quirks in upstream Linux are for when we give up.

Sure, it is perfectly okay for individual users to invoke it.
It is even fine for a distro to check in this workaround if they care
about that box working *now*
and they are not concerned about side effects.

But the real fix is in development, and checking workarounds with
possible other side-effects
into up-stream Linux is just a distraction from getting it right for
not just this machine,
but other machines w/ the same issue.

thanks,
Len Brown, Intel Open Source Technology Center

ps. lots of people are mis-using acpi_osi= in debugging, please consult
Documentation/kernel-parameters.txt for a detailed description of how
this cmdline option works.  Note, in particular, that acpi_osi=XYZ by itself
will _add_ XYZ to the list of recognized strings.  If that string is
already built
into Linux (eg. "Windows 2012"), then adding it again has no effect.

  reply	other threads:[~2014-12-18 18:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 12:16 [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA to enable, brightness keys Dmitry Tunin
2014-12-18 12:19 ` [PATCH 2/2] acpi: Add "acpi_osi=" for ASUS UX302LA " Dmitry Tunin
2014-12-18 13:25 ` [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA " Josh Boyer
2014-12-18 13:27   ` Matthew Garrett
2014-12-18 13:28   ` Dmitry Tunin
2014-12-18 13:28     ` Dmitry Tunin
2014-12-18 13:40   ` Dmitry Tunin
2014-12-18 13:57     ` Matthew Garrett
2014-12-18 14:03       ` Dmitry Tunin
2014-12-18 14:03         ` Dmitry Tunin
2014-12-18 14:04       ` Dmitry Tunin
2014-12-18 14:04         ` Dmitry Tunin
2014-12-18 14:09         ` Matthew Garrett
2014-12-18 14:22           ` Dmitry Tunin
2014-12-18 14:22             ` Dmitry Tunin
2014-12-18 14:26             ` Matthew Garrett
2014-12-18 14:34               ` Dmitry Tunin
2014-12-18 14:36                 ` Matthew Garrett
2014-12-18 14:40                   ` Dmitry Tunin
2014-12-18 14:43                     ` Matthew Garrett
2014-12-18 14:50                       ` Matthew Garrett
2014-12-18 18:09                         ` Len Brown [this message]
2014-12-18 18:20                           ` Dmitry Tunin
2014-12-18 20:04                         ` Matthew Garrett
2014-12-18 21:20                           ` Dmitry Tunin
2014-12-18 14:06       ` Dmitry Tunin
2014-12-18 14:06         ` Dmitry Tunin
2014-12-19  1:46   ` Aaron Lu
2014-12-19  3:23     ` Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJvTdKnejv9cKPW9sbnLswfBsWZCA1OU2os7iud9tKoq7CW+jw@mail.gmail.com \
    --to=lenb@kernel.org \
    --cc=aaron.lu@intel.com \
    --cc=hanipouspilot@gmail.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.