From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1765794AbcINV7d (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 17:59:33 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:33842 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756664AbcINV7c (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 17:59:32 -0400
MIME-Version: 1.0
In-Reply-To: <1473887291-18384-2-git-send-email-khuey@kylehuey.com>
References: <1473887291-18384-1-git-send-email-khuey@kylehuey.com> <1473887291-18384-2-git-send-email-khuey@kylehuey.com>
From: Dmitry Safonov <0x7f454c46@gmail.com>
Date: Thu, 15 Sep 2016 00:59:09 +0300
Message-ID: <CAJwJo6ae-OjJEjyzgqVDkwhjtAnK=DzEDpaCPSgFThpmyF4LWQ@mail.gmail.com>
Subject: Re: [RESEND][PATCH v2 1/3] syscalls,x86 Expose arch_prctl on x86-32.
To: Kyle Huey <me@kylehuey.com>
Cc: "Robert O'Callahan" <robert@ocallahan.org>,
        linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Milosz Tanski <milosz@adfin.com>,
        "Dmitry V. Levin" <ldv@altlinux.org>,
        David Howells <dhowells@redhat.com>, Zach Brown <zab@redhat.com>,
        Eric B Munson <emunson@akamai.com>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Slaby <jslaby@suse.cz>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Borislav Petkov <bp@alien8.de>, Dmitry Vyukov <dvyukov@google.com>,
        Dmitry Safonov <dsafonov@virtuozzo.com>,
        Mateusz Guzik <mguzik@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-09-15 0:08 GMT+03:00 Kyle Huey <me@kylehuey.com>:
> Signed-off-by: Kyle Huey <khuey@kylehuey.com>
> ---
>  arch/x86/entry/syscalls/syscall_32.tbl |  1 +
>  arch/x86/kernel/process.c              | 80 ++++++++++++++++++++++++++++++++++
>  arch/x86/kernel/process_64.c           | 66 ----------------------------
>  3 files changed, 81 insertions(+), 66 deletions(-)
>
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl
> index f848572..3b6965b 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -386,3 +386,4 @@
>  377    i386    copy_file_range         sys_copy_file_range
>  378    i386    preadv2                 sys_preadv2                     compat_sys_preadv2
>  379    i386    pwritev2                sys_pwritev2                    compat_sys_pwritev2
> +380    i386    arch_prctl              sys_arch_prctl

Why not define it as other 32-bit syscalls with compat_sys_ prefix
with the help of COMPAT_SYSCALL_DEFINE() macro?
Then you could omit code moving, drop is_32 helper.
I miss something obvious?

-- 
             Dmitry