All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sonic Zhang <sonic.adi@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
	Michael Hennerich <michael.hennerich@analog.com>,
	adi-buildroot-devel@lists.sourceforge.net,
	Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH v2 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function
Date: Wed, 4 Feb 2015 14:31:53 +0800	[thread overview]
Message-ID: <CAJxxZ0MDjTuA0erb2ORvN3MdoWT41mEXcWRW=gBXZfDf6oWJkg@mail.gmail.com> (raw)
In-Reply-To: <20150204012423.GD23942@dtor-ws>

Hi Dmitry,

On Wed, Feb 4, 2015 at 9:24 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Jan 14, 2015 at 04:54:14PM +0800, Sonic Zhang wrote:
>> From: Sonic Zhang <sonic.zhang@analog.com>
>>
>> - use readw and writew to access rotary MMRs
>> - remap rotary register physical address into kernel space in probe
>>
>> v2-changes:
>> - replace kzalloc with devm_kzalloc
>> - replace request_irq with devm_request_irq
>> - remove memory free and irq free from the device remove function
>
> This needs to be split in 2 as these are 2 separate changes - using
> generic IO accessors and converting to use managed resources.
>
> By the way, you can also use devm_input_allocate_device() and not need
> free/unregister it.
>

OK. I will separate this patch and send out new ones.

Thanks,

Sonic

  reply	other threads:[~2015-02-04  6:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  8:54 [PATCH v2 1/3] bfin_rotary: move rotary platform header definition to linux platform_data head path Sonic Zhang
2015-01-14  8:54 ` [PATCH v2 2/3] bfin_rotary: Move peripheral pinmux definition into platform data Sonic Zhang
2015-02-04  1:22   ` Dmitry Torokhov
2015-02-04  6:28     ` Sonic Zhang
2015-01-14  8:54 ` [PATCH v2 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function Sonic Zhang
2015-01-22  6:26   ` Sonic Zhang
2015-01-29  9:35   ` Sonic Zhang
2015-02-04  1:24   ` Dmitry Torokhov
2015-02-04  6:31     ` Sonic Zhang [this message]
2015-02-04  7:23     ` Sonic Zhang
2015-01-22  6:25 ` [PATCH v2 1/3] bfin_rotary: move rotary platform header definition to linux platform_data head path Sonic Zhang
2015-01-29  9:35 ` Sonic Zhang
2015-02-02  6:52 ` Sonic Zhang
2015-02-04  1:20 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJxxZ0MDjTuA0erb2ORvN3MdoWT41mEXcWRW=gBXZfDf6oWJkg@mail.gmail.com' \
    --to=sonic.adi@gmail.com \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=sonic.zhang@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.