From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197AbbDTVQj (ORCPT ); Mon, 20 Apr 2015 17:16:39 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35211 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbbDTVQg (ORCPT ); Mon, 20 Apr 2015 17:16:36 -0400 MIME-Version: 1.0 In-Reply-To: <20150418111622.GD26185@sirena.org.uk> References: <1429134141-17924-1-git-send-email-cernekee@chromium.org> <20150418111622.GD26185@sirena.org.uk> From: Kevin Cernekee Date: Mon, 20 Apr 2015 14:16:15 -0700 Message-ID: Subject: Re: [PATCH 1/3] ASoC: tas571x: Add DT binding document To: Mark Brown Cc: Liam Girdwood , dgreid@chromium.org, Andrew Bresticker , Olof Johansson , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 18, 2015 at 4:16 AM, Mark Brown wrote: > On Wed, Apr 15, 2015 at 02:42:19PM -0700, Kevin Cernekee wrote: > >> +- VDD-supply: regulator phandle for the AVDD/DVDD/HP_VDD supply > > This is clearly not correct - if there are three separate physical > supplies there should be three separate regulators requested. They may > all resolve to one physical regulator on the board you are working with > but that might not be true on other boards. In the "simplified diagram," TI shows a single AVDD/DVDD/HP_VDD supply: http://www.ti.com/lit/ds/symlink/tas5717.pdf#2 Page 20 also suggests the use of a single 3.3V supply for AVDD/DVDD/HP_VDD. But this combines a number of separate pins. On 5711 we have dedicated pins for: PVDD_A PVDD_B PVDD_C PVDD_D AVDD DVDD On 5717 we have dedicated pins for: PVDD_AB PVDD_CD AVDD DVDD HPVDD I didn't see anything in the datasheet suggesting it is OK to have different voltages or power states on the various supply pins (other than the special voltage on PVDD). I can add as many regulator entries as appropriate. What do you recommend? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Cernekee Subject: Re: [PATCH 1/3] ASoC: tas571x: Add DT binding document Date: Mon, 20 Apr 2015 14:16:15 -0700 Message-ID: References: <1429134141-17924-1-git-send-email-cernekee@chromium.org> <20150418111622.GD26185@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150418111622.GD26185-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Liam Girdwood , dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Andrew Bresticker , Olof Johansson , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Sat, Apr 18, 2015 at 4:16 AM, Mark Brown wrote: > On Wed, Apr 15, 2015 at 02:42:19PM -0700, Kevin Cernekee wrote: > >> +- VDD-supply: regulator phandle for the AVDD/DVDD/HP_VDD supply > > This is clearly not correct - if there are three separate physical > supplies there should be three separate regulators requested. They may > all resolve to one physical regulator on the board you are working with > but that might not be true on other boards. In the "simplified diagram," TI shows a single AVDD/DVDD/HP_VDD supply: http://www.ti.com/lit/ds/symlink/tas5717.pdf#2 Page 20 also suggests the use of a single 3.3V supply for AVDD/DVDD/HP_VDD. But this combines a number of separate pins. On 5711 we have dedicated pins for: PVDD_A PVDD_B PVDD_C PVDD_D AVDD DVDD On 5717 we have dedicated pins for: PVDD_AB PVDD_CD AVDD DVDD HPVDD I didn't see anything in the datasheet suggesting it is OK to have different voltages or power states on the various supply pins (other than the special voltage on PVDD). I can add as many regulator entries as appropriate. What do you recommend? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html