All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juhee Kang <claudiajkang@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <simon.horman@corigine.com>,
	netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, skhan@linuxfoundation.org
Subject: Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
Date: Wed, 28 Sep 2022 23:57:47 +0900	[thread overview]
Message-ID: <CAK+SQuS-PHYDjRcDf0gmX4ot8pKDoK9G00EzwKkX=o6Jh_fXQA@mail.gmail.com> (raw)
In-Reply-To: <20220926104506.559c183d@kernel.org>

Hi Jakub,

On Tue, Sep 27, 2022 at 2:45 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 26 Sep 2022 10:04:44 -0700 Jakub Kicinski wrote:
> > On Mon, 26 Sep 2022 17:29:39 +0900 Juhee Kang wrote:
> > > I will send a patch by applying netdev_registered() helper function by
> > > directory.
> >
> > Please hold off doing that. My preference would be to remove
> > netdev_unregistering(), this is all low-gain churn.
> > IMHO the helpers don't add much to readability and increase
> > the number of random helpers programmer must be aware of.
> > Let me check with other netdev maintainers and get back to you.
>
> I got hold of Paolo and he concurred. Let's remove
> netdev_unregistering() instead. Thanks!

Thank you for your review!
I will send the next version which includes removing netdev_unregistering()
as soon as possible.

Best regards,
Juhee

      reply	other threads:[~2022-09-28 14:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 16:09 [PATCH net-next 1/3] net: use netdev_unregistering instead of open code Juhee Kang
2022-09-23 16:09 ` [PATCH net-next 2/3] ethtool: " Juhee Kang
2022-09-26  7:45   ` Simon Horman
2022-09-23 16:09 ` [PATCH net-next 3/3] nfp: abm: " Juhee Kang
2022-09-26  7:48   ` Simon Horman
2022-09-26  7:44 ` [PATCH net-next 1/3] net: " Simon Horman
2022-09-26  8:05   ` Juhee Kang
2022-09-26  8:19     ` Simon Horman
2022-09-26  8:25       ` Juhee Kang
2022-09-26  8:27         ` Simon Horman
2022-09-26  8:29           ` Juhee Kang
2022-09-26 17:04             ` Jakub Kicinski
2022-09-26 17:45               ` Jakub Kicinski
2022-09-28 14:57                 ` Juhee Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK+SQuS-PHYDjRcDf0gmX4ot8pKDoK9G00EzwKkX=o6Jh_fXQA@mail.gmail.com' \
    --to=claudiajkang@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=simon.horman@corigine.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.