From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hurley Subject: Re: [PATCH net-next 8/8] nfp: flower: compute link aggregation action Date: Thu, 24 May 2018 18:36:50 +0100 Message-ID: References: <20180524022255.18548-1-jakub.kicinski@netronome.com> <20180524022255.18548-9-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Jakub Kicinski , David Miller , Linux Netdev List , oss-drivers@netronome.com To: Or Gerlitz Return-path: Received: from mail-io0-f194.google.com ([209.85.223.194]:34303 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965756AbeEXRgv (ORCPT ); Thu, 24 May 2018 13:36:51 -0400 Received: by mail-io0-f194.google.com with SMTP id p124-v6so3289198iod.1 for ; Thu, 24 May 2018 10:36:51 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, May 24, 2018 at 6:09 PM, Or Gerlitz wrote: > On Thu, May 24, 2018 at 5:22 AM, Jakub Kicinski > wrote: >> From: John Hurley >> >> If the egress device of an offloaded rule is a LAG port, then encode the >> output port to the NFP with a LAG identifier and the offloaded group ID. >> >> A prelag action is also offloaded which must be the first action of the >> series (although may appear after other pre-actions - e.g. tunnels). This >> causes the FW to check that it has the necessary information to output to >> the requested LAG port. If it does not, the packet is sent to the kernel >> before any other actions are applied to it. > > Offload decision typically also looks if both devices have the same > switchdev ID. > > In your case, do both reprs gets the same switchdev ID automatically when being > put into the same team/bond instance? I wasn't sure to see here > changes for that matter Hi Or, Yes, you are correct. We essentially substituted the switchdev ID check for a repr app check. So an app runs per card and spawns the reprs for that card - each repr has a backpointer to its creating app. When deciding if we can offload a bond, we ensure that all bond ports are reprs and belong to the same app and so same card/switchdev_id.