From: Alexander Aring <aahringo@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christine Caulfield <ccaulfie@redhat.com>,
David Teigland <teigland@redhat.com>,
"Reported-by : Randy Dunlap" <rdunlap@infradead.org>,
cluster-devel@redhat.com,
Network Development <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: dlm: Protect IPV6 field access by CONFIG_IPV6
Date: Thu, 18 Nov 2021 09:52:57 -0500 [thread overview]
Message-ID: <CAK-6q+gQCzJeV5VbCJUbg1dt=4nPvgBAOP5cPmLchmnro1pQ_A@mail.gmail.com> (raw)
In-Reply-To: <20211118082355.983825-1-geert@linux-m68k.org>
Hi,
On Thu, Nov 18, 2021 at 3:26 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> If CONFIG_IPV6=n:
>
> In file included from fs/dlm/lowcomms.c:46:
> fs/dlm/lowcomms.c: In function ‘lowcomms_error_report’:
> ./include/net/sock.h:386:34: error: ‘struct sock_common’ has no member named ‘skc_v6_daddr’; did you mean ‘skc_daddr’?
> 386 | #define sk_v6_daddr __sk_common.skc_v6_daddr
> | ^~~~~~~~~~~~
> ./include/linux/printk.h:422:19: note: in expansion of macro ‘sk_v6_daddr’
> 422 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/printk.h:450:26: note: in expansion of macro ‘printk_index_wrap’
> 450 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:644:3: note: in expansion of macro ‘printk’
> 644 | printk(fmt, ##__VA_ARGS__); \
> | ^~~~~~
> fs/dlm/lowcomms.c:612:3: note: in expansion of macro ‘printk_ratelimited’
> 612 | printk_ratelimited(KERN_ERR "dlm: node %d: socket error "
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by protecting the code that accesses IPV6-only fields by a
> check for CONFIG_IPV6.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 4c3d90570bcc2b33 ("fs: dlm: don't call kernel_getpeername() in error_report()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
Thanks, but the issue has already been fixed in the same way [0].
- Alex
[0] https://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git/commit/?h=next&id=1b9beda83e27a0c2cd75d1cb743c297c7b36c844
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fs: dlm: Protect IPV6 field access by CONFIG_IPV6
Date: Thu, 18 Nov 2021 09:52:57 -0500 [thread overview]
Message-ID: <CAK-6q+gQCzJeV5VbCJUbg1dt=4nPvgBAOP5cPmLchmnro1pQ_A@mail.gmail.com> (raw)
In-Reply-To: <20211118082355.983825-1-geert@linux-m68k.org>
Hi,
On Thu, Nov 18, 2021 at 3:26 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> If CONFIG_IPV6=n:
>
> In file included from fs/dlm/lowcomms.c:46:
> fs/dlm/lowcomms.c: In function ?lowcomms_error_report?:
> ./include/net/sock.h:386:34: error: ?struct sock_common? has no member named ?skc_v6_daddr?; did you mean ?skc_daddr??
> 386 | #define sk_v6_daddr __sk_common.skc_v6_daddr
> | ^~~~~~~~~~~~
> ./include/linux/printk.h:422:19: note: in expansion of macro ?sk_v6_daddr?
> 422 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/printk.h:450:26: note: in expansion of macro ?printk_index_wrap?
> 450 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:644:3: note: in expansion of macro ?printk?
> 644 | printk(fmt, ##__VA_ARGS__); \
> | ^~~~~~
> fs/dlm/lowcomms.c:612:3: note: in expansion of macro ?printk_ratelimited?
> 612 | printk_ratelimited(KERN_ERR "dlm: node %d: socket error "
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by protecting the code that accesses IPV6-only fields by a
> check for CONFIG_IPV6.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 4c3d90570bcc2b33 ("fs: dlm: don't call kernel_getpeername() in error_report()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
Thanks, but the issue has already been fixed in the same way [0].
- Alex
[0] https://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git/commit/?h=next&id=1b9beda83e27a0c2cd75d1cb743c297c7b36c844
next prev parent reply other threads:[~2021-11-18 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 8:23 [PATCH] fs: dlm: Protect IPV6 field access by CONFIG_IPV6 Geert Uytterhoeven
2021-11-18 8:23 ` [Cluster-devel] " Geert Uytterhoeven
2021-11-18 14:52 ` Alexander Aring [this message]
2021-11-18 14:52 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK-6q+gQCzJeV5VbCJUbg1dt=4nPvgBAOP5cPmLchmnro1pQ_A@mail.gmail.com' \
--to=aahringo@redhat.com \
--cc=ccaulfie@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.