[Cluster-devel] [PATCHv4 dlm/next 4/8] fs: dlm: add functionality to re-transmit a message

From: Alexander Ahring Oder Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCHv4 dlm/next 4/8] fs: dlm: add functionality to re-transmit a message
Date: Wed, 21 Apr 2021 10:45:32 -0400	[thread overview]
Message-ID: <CAK-6q+htp6o-vnukUu7nu9uXF93zA9TZ0EhQwYrsCzV1rrcLqw@mail.gmail.com> (raw)
In-Reply-To: <20210409144859.48385-5-aahringo@redhat.com>

Hi,

On Fri, Apr 9, 2021 at 10:49 AM Alexander Aring <aahringo@redhat.com> wrote:
...
>  }
>
> +void dlm_lowcomms_resend_buffer(void *mh)
> +{
> +       struct dlm_msg *msg = mh;
> +       void *mh_new;
> +       char *ppc;
> +
> +       mh_new = dlm_lowcomms_new_buffer_con(msg->entry->con, msg->len,
> +                                            GFP_NOFS, &ppc, NULL, NULL);

This should be GFP_ATOMIC, because we later call this function while
rcu lock is held.

I am worried about the con lookup here, but I think it's fine so far
we call this function inside some workqueue which should synchronize
the free of "con" here. However I will fix that srcu usage later to be
more correct...

- Alex