From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Eddy_Petri=C8=99or?= <eddy.petrisor@gmail.com>
Date: Mon, 4 Apr 2016 17:22:40 +0300
Subject: [U-Boot] [PATCH 1/2] serial: Introduce linflex uart support
In-Reply-To: <CAEUhbmX==Zxz8GpR+yX6i_TByGRRn85Zs2qgPrjXc5iJ_+JHdQ@mail.gmail.com>
References: <1459642206-20101-1-git-send-email-eddy.petrisor@gmail.com>
 <CAEUhbmX==Zxz8GpR+yX6i_TByGRRn85Zs2qgPrjXc5iJ_+JHdQ@mail.gmail.com>
Message-ID: <CAK0XTWebQrwqCVKb-s12Ta3ou+xqVpbmy2V26Rj13CTHFRBN2g@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

(- Eric, he left the company a little after he contributed to the linflex
driver, so he's email is no longer valid)

Pe 4 apr. 2016 6:22 a.m., "Bin Meng" <bmeng.cn@gmail.com> a scris:
>
> On Sun, Apr 3, 2016 at 8:10 AM, Eddy Petri?or <eddy.petrisor@gmail.com>
wrote:
> > From: Stoica Cosmin-Stefan <cosminstefan.stoica@freescale.com>
> >
> > The Linflex module is integrated on some NXP automotive SoCs part of
the former
> > Freescale portfolio, like S32V234, an
[..]

> > +static void linflex_serial_putc(const char c)
> > +{
> > +       if (c == '\n')
> > +               serial_putc('\r');
>
> Please remove this \n \r handling.

I will and retest, but without it we saw in the past the console not
behaving correctly.

[..]

> > --
>
> You should really start creating DM serial driver. Non-DM serial
> driver is not going to be accepted.

I see. Does that imply also SPL support? Our current vendor branch has no
SPL support and we had no real need for it. On the other hand it is
entirely possible I am misunderstanding what/if the SPL would benefit us.

Eddy