From: Andrei Gherzan <andrei@gherzan.ro>
To: John Madieu <j.madieu@expemb.com>
Cc: Yocto Project <yocto@yoctoproject.org>
Subject: Re: [meta-raspberrypi][PATCH 4/4] qtbase bbappend: cleanned recipe
Date: Mon, 11 Jan 2016 14:49:45 +0100 [thread overview]
Message-ID: <CAK18fxG9EkNONhESoZsKtbY8DexAKNKTy6nWyAoLEejsQbRdVg@mail.gmail.com> (raw)
In-Reply-To: <1452480913-15282-3-git-send-email-j.madieu@expemb.com>
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
Hi John,
On Mon, Jan 11, 2016 at 3:55 AM, John Madieu <j.madieu@expemb.com> wrote:
> Signed-off-by: John Madieu <j.madieu@expemb.com>
> ---
> qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> b/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> index ac158a9..8b77bfa 100644
> --- a/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> +++ b/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> @@ -1,12 +1,12 @@
>
>
I can't follow these patches. Can you squash them to include cleanups and
so on and have clean patches sent? As well, can you send them tagged as v2
so I can easily see them?
> do_configure_prepend_rpi() {
> -
> +
> sed -i 's!load(qt_config)!!' ${S}/mkspecs/linux-oe-g++/qmake.conf
> if ! grep -q '^EGLFS_' ${S}/mkspecs/linux-oe-g++/qmake.conf; then
> cat >> ${S}/mkspecs/linux-oe-g++/qmake.conf <<EOF
> QMAKE_INCDIR_EGL = \$\$[QT_SYSROOT]${includedir}/interface/vcos/pthreads
> \$\$[QT_SYSROOT]${includedir}/interface/vmcs_host/linux
> -QMAKE_INCDIR_OPENGL_ES2 = \$\${QMAKE_INCDIR_EGL}
> -QMAKE_LIBS_EGL = -lEGL -lGLESv2
> +QMAKE_INCDIR_OPENGL_ES2 = \$\${QMAKE_INCDIR_EGL}
> +QMAKE_LIBS_EGL = -lEGL -lGLESv2
> EOF
>
> if [ -d
> ${S}/src/plugins/platforms/eglfs/deviceintegration/eglfs_brcm ]; then
> @@ -27,8 +27,3 @@ load(qt_config)
>
> EOF
> }
> -
> -
> -
> -
> -
> --
> 1.9.1
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
[-- Attachment #2: Type: text/html, Size: 2461 bytes --]
next prev parent reply other threads:[~2016-01-11 13:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 0:44 [meta-raspberrypi][PATCH] qt5: fixed raspberrypi support John Madieu
2016-01-10 18:40 ` Andrei Gherzan
2016-01-11 2:01 ` [meta-raspberrypi][PATCH 2/2] layer.conf: avoid to force users to add the qt5 layer because of qtbase bbappend John Madieu
2016-01-11 2:08 ` Andrei Gherzan
2016-01-11 2:55 ` [meta-raspberrypi][PATCH 2/4] qt5base: moved the bbappend to a suitable path John Madieu
2016-01-11 2:55 ` [meta-raspberrypi][PATCH 3/4] layer.conf: avoid to force users to add the qt5 layer because of qtbase bbappend John Madieu
2016-01-11 2:55 ` [meta-raspberrypi][PATCH 4/4] qtbase bbappend: cleanned recipe John Madieu
2016-01-11 13:49 ` Andrei Gherzan [this message]
2016-01-11 14:21 ` john madieu
2016-01-11 14:40 ` [meta-raspberrypi][PATCH v2 1/2] qt5: fixed raspberrypi support John Madieu
2016-01-11 14:40 ` [meta-raspberrypi][PATCH v2 2/2] layer.conf: avoid to force users to add the qt5 layer because of qtbase bbappend John Madieu
2016-01-11 15:03 ` [meta-raspberrypi][PATCH 4/4] qtbase bbappend: cleanned recipe Andrei Gherzan
2016-01-11 15:46 ` [meta-raspberrypi][PATCH v2 1/2] qt5: fixed raspberrypi support John Madieu
2016-01-11 15:46 ` [meta-raspberrypi][PATCH v2 2/2] layer.conf: avoid to force users to add the qt5 layer because of qtbase bbappend John Madieu
2016-01-11 20:34 ` [meta-raspberrypi][PATCH v2 1/2] qt5: fixed raspberrypi support Andrei Gherzan
2016-01-12 1:55 ` john madieu
2016-01-12 14:22 ` [meta-raspberrypi][PATCH v3 " John Madieu
2016-01-12 14:22 ` [meta-raspberrypi][PATCH v3 2/2] layer.conf: avoid to force users to add the qt5 layer because of qtbase bbappend John Madieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK18fxG9EkNONhESoZsKtbY8DexAKNKTy6nWyAoLEejsQbRdVg@mail.gmail.com \
--to=andrei@gherzan.ro \
--cc=j.madieu@expemb.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.