From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751796AbbAKXG0 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 11 Jan 2015 18:06:26 -0500
Received: from mail-qa0-f49.google.com ([209.85.216.49]:44573 "EHLO
	mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750852AbbAKXGZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 11 Jan 2015 18:06:25 -0500
MIME-Version: 1.0
In-Reply-To: <20150111105436.GA19421@pd.tnic>
References: <1420927210-19738-1-git-send-email-dvlasenk@redhat.com>
 <1420927210-19738-4-git-send-email-dvlasenk@redhat.com> <CA+55aFx54dhF7mU6NUTuCW2gP2XQt55XG-a3iDttSmijmdzbyw@mail.gmail.com>
 <CAK1hOcNgnZcF5fZjSSMr+RQQWLGBSjitErd4gj7JxgTMZPGTzQ@mail.gmail.com>
 <20150110224120.GJ12218@pd.tnic> <CAK1hOcMU0kV1M8dk-iOnTJuY3xtE+tmqqgzTxXnzzuDR2EOuLg@mail.gmail.com>
 <20150111105436.GA19421@pd.tnic>
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Mon, 12 Jan 2015 00:06:04 +0100
Message-ID: <CAK1hOcNr==AWteYy1Q7wGA6i5qCWZPQbnX1MJ3zZFEKD543zOQ@mail.gmail.com>
Subject: Re: [PATCH 3/4] x86: open-code register save/restore in
 trace_hardirqs thunks
To: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Oleg Nesterov <oleg@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Frederic Weisbecker <fweisbec@gmail.com>, X86 ML <x86@kernel.org>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 11, 2015 at 11:54 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Sun, Jan 11, 2015 at 04:33:58AM +0100, Denys Vlasenko wrote:
>> I understand Andy's post.
>> My question is, what about places like this?
>>
>> > .macro op_safe_regs op
>> > ENTRY(\op\()_safe_regs)
>> >         CFI_STARTPROC
>> >         pushl_cfi %ebx
>> >         pushl_cfi %ebp
>> >         pushl_cfi %esi
>> >         pushl_cfi %edi
>>
>> Do we need to convert it to use macros which also do
>> "CFI_REL_OFFSET reg, 0" thingy, or not?
>> In either case: why?
>
> What is different at those places to not use the CFI annotations?

Okay, sending a patch which _probably_ does the right thing...