From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C267C433E0 for ; Thu, 11 Mar 2021 19:01:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55F8264FA6 for ; Thu, 11 Mar 2021 19:01:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55F8264FA6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKQYR-0005zf-9P for qemu-devel@archiver.kernel.org; Thu, 11 Mar 2021 14:01:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKQVs-00048n-8M for qemu-devel@nongnu.org; Thu, 11 Mar 2021 13:58:24 -0500 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]:34383) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKQVq-0003XE-EK for qemu-devel@nongnu.org; Thu, 11 Mar 2021 13:58:24 -0500 Received: by mail-qt1-x836.google.com with SMTP id c6so1947644qtc.1 for ; Thu, 11 Mar 2021 10:58:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c6ge1U3DfXS7QFpowJsAl87wYaACjboeO+Y+QhWbSt4=; b=fgjmdQ4PlfuwnwnYhOote8pC4Tv2X10qg+qC7rrTi18Vye2isCPyh2I9h+n+hkrTd8 /Fmf9S609awET+zkU3G8y4M2CGxiV6tduyO7Fwl9nqPrdEnh5O/B37UYWfJWlhnwpHTe 2o6bX8xdofNo/NpGk+vzHf5NipLEjSTo1lsbDS47kdkw9mu1Zava7GJZh9ks5zkMEcSo mePbk5nFUDAsJP2JmB2c+zr6pvpQcu2vngWaW1Of4dm3gem1nqUKYiFkBs5lAItIZ315 j3RhbB4XEnIZgzcuE/DlI/4PpW/LkgopBs7GrjZHLOxap6bV9Nsq9QKJ831IyZ6fZHQD EJjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c6ge1U3DfXS7QFpowJsAl87wYaACjboeO+Y+QhWbSt4=; b=SEdNOJjddtWrWIhc3KQ/1JVmi4HiBrIq9tq8SlXSxltQLldz1Mn6whQ0uneqbylsOt xDt2cPCgfmus0kAgpKJh4Br2+q6HUZ5WzuS9by+anPVbjXSm1V/fXuswYFkTiwBhBwWt tyouy7HOLr28UpT7HdqbZmUkJ5gjFzj+r0z01CjarPnq3UuRuHizINa5F5J5AOVYaKCX GB/j0oc/cJJ53q1YuuR8B/Q9ly0jFcuINjFDMji2a/xQqWD2uwx1Dkj6Njm473gR9Sc+ VyMGQSsC24Fpt7szoccI3b9+5lrXqEqsf5mCURrzm8vLzd1lSn/x9Bem9RQd5LvNyC7R WpBw== X-Gm-Message-State: AOAM5303fUnAuBRNXP7RQkFfR2jlHVFWQuCdGPGgyLBeWmFIjdEj6rC5 j400TlwNRmpgQtgzr6mokb3nwPp+hJF89tcbjgA= X-Google-Smtp-Source: ABdhPJyOzUYmTvvJSksVtUqlZDH1EIQzInTZNgpiQ31dfh9S10tEo51STU8Q4unb0s+rDESxPkrHWZG6d4mnzt2pd/Y= X-Received: by 2002:ac8:71d2:: with SMTP id i18mr8662226qtp.371.1615489100809; Thu, 11 Mar 2021 10:58:20 -0800 (PST) MIME-Version: 1.0 References: <20210311135539.10206-1-niteesh.gs@gmail.com> In-Reply-To: <20210311135539.10206-1-niteesh.gs@gmail.com> From: Michael Rolnik Date: Thu, 11 Mar 2021 20:57:44 +0200 Message-ID: Subject: Re: [PATCH 0/3] AVR GPIO Emulation and Arduino D13 LED To: G S Niteesh Babu Content-Type: multipart/alternative; boundary="000000000000fe08da05bd475dc6" Received-SPF: pass client-ip=2607:f8b0:4864:20::836; envelope-from=mrolnik@gmail.com; helo=mail-qt1-x836.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , QEMU Developers , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000fe08da05bd475dc6 Content-Type: text/plain; charset="UTF-8" Reviewed-by: Michael Rolnik On Thu, Mar 11, 2021 at 3:55 PM G S Niteesh Babu wrote: > Hello, > > The following series of the patches add a basic AVR GPIO emulation > to QEMU. The AVR GPIO emulation patch was originally written by > Heecheol Yang and was posted on the mailing list around 5 months ago. > I am re-publishing the patch with some bug fixes along with my own > patch, Adding the D13 onboard LED. > > G S Niteesh Babu (2): > hw/gpio/avr_gpio.c: add tracing for read and writes > avr/arduino: Add D13 LED > > Heecheol Yang (1): > hw/avr: Add limited support for avr gpio registers > > hw/avr/Kconfig | 2 + > hw/avr/arduino.c | 15 ++++ > hw/avr/atmega.c | 7 +- > hw/avr/atmega.h | 2 + > hw/gpio/Kconfig | 3 + > hw/gpio/avr_gpio.c | 148 +++++++++++++++++++++++++++++++++++++ > hw/gpio/meson.build | 1 + > hw/gpio/trace-events | 6 ++ > include/hw/gpio/avr_gpio.h | 53 +++++++++++++ > 9 files changed, 235 insertions(+), 2 deletions(-) > create mode 100644 hw/gpio/avr_gpio.c > create mode 100644 include/hw/gpio/avr_gpio.h > > -- > 2.17.1 > > -- Best Regards, Michael Rolnik --000000000000fe08da05bd475dc6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>

On Thu, Mar 11, 2021 at 3:55 PM G S Nit= eesh Babu <niteesh.gs@gmail.com<= /a>> wrote:
H= ello,

The following series of the patches add a basic AVR GPIO emulation
to QEMU. The AVR GPIO emulation patch was originally written by
Heecheol Yang and was posted on the mailing list around 5 months ago.
I am re-publishing the patch with some bug fixes along with my own
patch, Adding the D13 onboard LED.

G S Niteesh Babu (2):
=C2=A0 hw/gpio/avr_gpio.c: add tracing for read and writes
=C2=A0 avr/arduino: Add D13 LED

Heecheol Yang (1):
=C2=A0 hw/avr: Add limited support for avr gpio registers

=C2=A0hw/avr/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0= =C2=A02 +
=C2=A0hw/avr/arduino.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 15 += +++
=C2=A0hw/avr/atmega.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2= =A07 +-
=C2=A0hw/avr/atmega.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2= =A02 +
=C2=A0hw/gpio/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2= =A03 +
=C2=A0hw/gpio/avr_gpio.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 148 +++++++++++= ++++++++++++++++++++++++++
=C2=A0hw/gpio/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 +
=C2=A0hw/gpio/trace-events=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A06 ++
=C2=A0include/hw/gpio/avr_gpio.h |=C2=A0 53 +++++++++++++
=C2=A09 files changed, 235 insertions(+), 2 deletions(-)
=C2=A0create mode 100644 hw/gpio/avr_gpio.c
=C2=A0create mode 100644 include/hw/gpio/avr_gpio.h

--
2.17.1



--
Best Regards,
Michael Rolnik
--000000000000fe08da05bd475dc6--