[Buildroot] [PATCH 0/2] Add host acpica support

[Buildroot] [PATCH 0/2] Add host acpica support

[Alistair Francis]

Add support for buildling the acpica package for the host.

This fixes the Xen build issue when iasl is missing.
Reported here:
http://autobuild.buildroot.net/results/afa/afa199864d6b546fe759bb582a9c10702ea7fa78/

Alistair Francis (2):
  package: acpica: Add host buildling support
  package: xen: Depend on the host-acpica package

 package/acpica/acpica.mk | 12 ++++++++++++
 package/xen/xen.mk       |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)

-- 
2.11.0

[Buildroot] [PATCH 1/2] package: acpica: Add host buildling support

[Alistair Francis]

Add support to build the ACPICA package for the host. This is useful for
the iasl command which is required to build some packaged, including Xen
tools

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
 package/acpica/acpica.mk | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
index 37e4941a6..96d0dad2b 100644
--- a/package/acpica/acpica.mk
+++ b/package/acpica/acpica.mk
@@ -11,6 +11,11 @@ ACPICA_LICENSE = BSD-3-Clause or GPL-2.0
 ACPICA_LICENSE_FILES = source/include/acpi.h
 ACPICA_DEPENDENCIES = host-bison host-flex
 
+define HOST_ACPICA_BUILD_CMDS
+	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		all
+endef
+
 define ACPICA_BUILD_CMDS
 	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
 		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \
@@ -23,4 +28,11 @@ define ACPICA_INSTALL_TARGET_CMDS
 		INSTALLFLAGS=-m755 install
 endef
 
+define HOST_ACPICA_INSTALL_CMDS
+	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		DESTDIR="$(HOST_DIR)" \
+		INSTALLFLAGS=-m755 install
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))
-- 
2.11.0

[Buildroot] [PATCH 2/2] package: xen: Depend on the host-acpica package

[Alistair Francis]

Add a dependency on the host ACPICA package as Xen tools require iasl to
build.

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
 package/xen/xen.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/xen/xen.mk b/package/xen/xen.mk
index 89c09f872..79c511ac5 100644
--- a/package/xen/xen.mk
+++ b/package/xen/xen.mk
@@ -8,7 +8,7 @@ XEN_VERSION = 4.8.1
 XEN_SITE = http://bits.xensource.com/oss-xen/release/$(XEN_VERSION)
 XEN_LICENSE = GPL-2.0
 XEN_LICENSE_FILES = COPYING
-XEN_DEPENDENCIES = host-python
+XEN_DEPENDENCIES = host-python host-acpica
 
 # Calculate XEN_ARCH
 ifeq ($(ARCH),aarch64)
-- 
2.11.0

[Buildroot] [PATCH 1/2] package: acpica: Add host buildling support

[Erico Nunes]

On Wed, May 24, 2017 at 10:30 PM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> Add support to build the ACPICA package for the host. This is useful for
> the iasl command which is required to build some packaged, including Xen
> tools
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>

Acked-by: Erico Nunes <nunes.erico@gmail.com>

[Buildroot] [PATCH 2/2] package: xen: Depend on the host-acpica package

[Erico Nunes]

On Wed, May 24, 2017 at 10:30 PM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> Add a dependency on the host ACPICA package as Xen tools require iasl to
> build.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>

Acked-by: Erico Nunes <nunes.erico@gmail.com>

[Buildroot] [PATCH 1/2] package: acpica: Add host buildling support

[Thomas Petazzoni]

Hello,

Commit titles should have prefixes that look like:

	acpica:

or:

	package/acpica:

and not:

	package: acpica:

Yes, that's a silly convention, but conventions are always silly :)

On Wed, 24 May 2017 13:30:29 -0700, Alistair Francis wrote:
> Add support to build the ACPICA package for the host. This is useful for
> the iasl command which is required to build some packaged, including Xen
> tools

This should have reference the autobuilder issue that it helps fixing
(even if it's only part of the fix).

> +define HOST_ACPICA_BUILD_CMDS
> +	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		all
> +endef

Weird that you put the host build command before the target build
command, and then the host install command *after* the target install
command. So I've reordered this.

> +
>  define ACPICA_BUILD_CMDS
>  	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>  		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \
> @@ -23,4 +28,11 @@ define ACPICA_INSTALL_TARGET_CMDS
>  		INSTALLFLAGS=-m755 install
>  endef
>  
> +define HOST_ACPICA_INSTALL_CMDS
> +	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		DESTDIR="$(HOST_DIR)" \

DESTDIR="$(HOST_DIR)" is wrong, so I've replaced with
PREFIX="$(HOST_DIR)/usr". See
https://stackoverflow.com/questions/11307465/destdir-and-prefix-of-make
for a quick explanation about the difference.

Applied to master with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] package: xen: Depend on the host-acpica package

[Thomas Petazzoni]

Hello,

Same comment on the commit title: use "package/xen: " as a prefix.

On Wed, 24 May 2017 13:30:30 -0700, Alistair Francis wrote:
> Add a dependency on the host ACPICA package as Xen tools require iasl to
> build.

Lacks a reference to the autobuilder issue being fixed. I know you have
it in the cover letter, but this is not the place where it is useful:
the cover letter contents don't get committed/preserved anywhere. While
the commit log becomes part of the Git history. So we want to have the
autobuilder reference as part of the commit log.

>  XEN_LICENSE_FILES = COPYING
> -XEN_DEPENDENCIES = host-python
> +XEN_DEPENDENCIES = host-python host-acpica

Alphabetic ordering not respected.

I've fixed those issues and applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com