From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Wu Subject: Re: [PATCH/RFC v10 01/19] leds: Add LED Flash class extension to the LED subsystem Date: Mon, 26 Jan 2015 15:02:02 -0800 Message-ID: References: <1420816989-1808-1-git-send-email-j.anaszewski@samsung.com> <1420816989-1808-2-git-send-email-j.anaszewski@samsung.com> <20150109173707.GB18076@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ie0-f170.google.com ([209.85.223.170]:36693 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756624AbbAZXCX (ORCPT ); Mon, 26 Jan 2015 18:02:23 -0500 In-Reply-To: <20150109173707.GB18076@amd> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Pavel Machek Cc: Jacek Anaszewski , Linux LED Subsystem , "linux-media@vger.kernel.org" , lkml , "devicetree@vger.kernel.org" , Kyungmin Park , b.zolnierkie@samsung.com, "rpurdie@rpsys.net" , Sakari Ailus , Sylwester Nawrocki On Fri, Jan 9, 2015 at 9:37 AM, Pavel Machek wrote: > On Fri 2015-01-09 16:22:51, Jacek Anaszewski wrote: >> Some LED devices support two operation modes - torch and flash. >> This patch provides support for flash LED devices in the LED subsystem >> by introducing new sysfs attributes and kernel internal interface. >> The attributes being introduced are: flash_brightness, flash_strobe, >> flash_timeout, max_flash_timeout, max_flash_brightness, flash_fault, >> flash_sync_strobe and available_sync_leds. All the flash related >> features are placed in a separate module. >> >> The modifications aim to be compatible with V4L2 framework requirements >> related to the flash devices management. The design assumes that V4L2 >> sub-device can take of the LED class device control and communicate >> with it through the kernel internal interface. When V4L2 Flash sub-device >> file is opened, the LED class device sysfs interface is made >> unavailable. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by: Kyungmin Park >> Cc: Bryan Wu >> Cc: Richard Purdie > > Acked-by: Pavel Machek > Applied to my tree. Thanks for pushing this. -Bryan