From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuo-Jung Su <dantesu@gmail.com>
Date: Tue, 9 Jul 2013 09:42:01 +0800
Subject: [U-Boot] [PATCH v6 03/12] nand: add Faraday FTNANDC021 NAND
 controller support
In-Reply-To: <1373327963.8183.186@snotra>
References: <1372909244-25211-4-git-send-email-dantesu@gmail.com>
	<1373327963.8183.186@snotra>
Message-ID: <CAK65tU57_JSBYuzFxXLyr_9i5DfdopY=yq9kRUxhYP44woQZ8A@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

2013/7/9 Scott Wood <scottwood@freescale.com>:
> On 07/03/2013 10:40:35 PM, Kuo-Jung Su wrote:
>>
>> +#ifndef __ARMEB__
>> +               put_unaligned_le32(readl(&regs->dr), buf + off);
>> +#else
>> +               put_unaligned_be32(readl(&regs->dr), buf + off);
>> +#endif
>
>
> Can't you just use plain put_unaligned()?  Be sure to cast buf + off to a
> 32-bit pointer.
>

Ummm...  I think it'll be better to replace put_unaligned() with memcpy(),
just like what your suggested before.

So that we don't even have to worry about this endian issue and pointer cast.

> Also, when you *do* need to have an if/else, use positive logic -- ifdef
> rather than ifndef, with the if/else swapped.
>

Got it, thanks

--
Best wishes,
Kuo-Jung Su