From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuo-Jung Su Date: Mon, 22 Apr 2013 10:52:26 +0800 Subject: [U-Boot] [PATCH v2 04/12] i2c: add Faraday FTI2C010 I2C controller support In-Reply-To: <20130418105429.D4AA420019A@gemini.denx.de> References: <1366277139-29728-1-git-send-email-dantesu@gmail.com> <1364540788-13943-2-git-send-email-dantesu@gmail.com> <1366277139-29728-5-git-send-email-dantesu@gmail.com> <20130418105429.D4AA420019A@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-5-git-send-email-dantesu@gmail.com> you wrote: > ... >> +#define I2C_READ(r) le32_to_cpu(readl(r)) >> +#define I2C_WRITE(v, r) writel(cpu_to_le32(v), r) > > Please drop these macros and use the real functions instead. > > Got it, thanks > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de > Little known fact about Middle Earth: The Hobbits had a very sophi- > sticated computer network! It was a Tolkien Ring... -- Best wishes, Kuo-Jung Su