From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuo-Jung Su Date: Thu, 9 May 2013 09:45:13 +0800 Subject: [U-Boot] [PATCH v4] nand: add Faraday FTNANDC021 NAND controller support In-Reply-To: <1368060185.3398.65@snotra> References: <1367908391-12137-1-git-send-email-dantesu@gmail.com> <1368060185.3398.65@snotra> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 2013/5/9 Scott Wood : > On 05/07/2013 01:33:11 AM, Kuo-Jung Su wrote: >> >> From: Kuo-Jung Su >> >> Faraday FTNANDC021 is a integrated NAND flash controller. >> It use a build-in command table to abstract the underlying >> NAND flash control logic. >> >> For example: >> >> Issuing a command 0x10 to FTNANDC021 would result in >> a page write + a read status operation. >> >> Signed-off-by: Kuo-Jung Su >> CC: Scott Wood > > > Looks mostly OK, just a couple nits: > > >> diff --git a/README b/README >> index 0d37d56..883182d 100644 >> --- a/README >> +++ b/README >> @@ -3879,6 +3879,10 @@ Low Level (hardware related) configuration options: >> - drivers/mtd/nand/ndfc.c >> - drivers/mtd/nand/mxc_nand.c >> >> +- CONFIG_SYS_FTNANDC021_TIMING >> + Defined to tell the FTNANDC021 controller that the NAND >> chip is >> + using customized timing parameters. > > > This makes it sound like a boolean option, but it's actually an array -- > would be nice to mention what's actually expected. > > Got it, thanks >> + if (mtd->writesize >= 4096) { > Got it, thanks > > Whitespace > > -Scott -- Best wishes, Kuo-Jung Su