From: Yuchung Cheng <ycheng@google.com>
To: Kenneth Klette Jonassen <kennetkl@ifi.uio.no>
Cc: netdev <netdev@vger.kernel.org>, Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH net-next] tcp: use SACK RTTs for CC
Date: Fri, 30 Jan 2015 09:47:36 -0800 [thread overview]
Message-ID: <CAK6E8=cRcBUr=H62WHzBetBgLBoV4hPC3ZFNwTZJN4EBTeiSmw@mail.gmail.com> (raw)
In-Reply-To: <CAK6E8=c6uAeAMvRfdxYNcqBLWmFTywbpvaqmzf7XmajkGSNqeg@mail.gmail.com>
On Fri, Jan 30, 2015 at 9:21 AM, Yuchung Cheng <ycheng@google.com> wrote:
> On Thu, Jan 29, 2015 at 11:08 AM, Kenneth Klette Jonassen
> <kennetkl@ifi.uio.no> wrote:
>> Current behavior only passes RTTs from sequentially acked data to CC.
>>
>> If sender gets a combined ACK for segment 1 and SACK for segment 3, then the
>> computed RTT for CC is the time between sending segment 1 and receiving SACK
>> for segment 3.
> since segment 3 is sent after segment 1, sack_rtt_us <= ca_seq_rtt so
> taking a min is not necessary?
ah i didn't notice you are taking a min_t of ulong for invalid
sack_rtt_us now i get it.
>
>>
>> Pass the minimum computed RTT from any acked data to CC, i.e. time between
>> sending segment 3 and receiving SACK for segment 3.
>>
>> Signed-off-by: Kenneth Klette Jonassen <kennetkl@ifi.uio.no>
>> ---
>> net/ipv4/tcp_input.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
>> index 71fb37c..ed11931 100644
>> --- a/net/ipv4/tcp_input.c
>> +++ b/net/ipv4/tcp_input.c
>> @@ -3183,8 +3183,10 @@ static int tcp_clean_rtx_queue(struct sock *sk, int prior_fackets,
>>
>> tp->fackets_out -= min(pkts_acked, tp->fackets_out);
>>
>> - if (ca_ops->pkts_acked)
>> - ca_ops->pkts_acked(sk, pkts_acked, ca_seq_rtt_us);
>> + if (ca_ops->pkts_acked) {
>> + long rtt_us = min_t(ulong, ca_seq_rtt_us, sack_rtt_us);
>> + ca_ops->pkts_acked(sk, pkts_acked, rtt_us);
>> + }
>>
>> } else if (skb && rtt_update && sack_rtt_us >= 0 &&
>> sack_rtt_us > skb_mstamp_us_delta(&now, &skb->skb_mstamp)) {
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-30 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 19:08 [PATCH net-next] tcp: use SACK RTTs for CC Kenneth Klette Jonassen
2015-01-30 17:21 ` Yuchung Cheng
2015-01-30 17:47 ` Yuchung Cheng [this message]
2015-02-01 1:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK6E8=cRcBUr=H62WHzBetBgLBoV4hPC3ZFNwTZJN4EBTeiSmw@mail.gmail.com' \
--to=ycheng@google.com \
--cc=kennetkl@ifi.uio.no \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.