From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Subject: Re: [PATCH v2 06/17] kbuild: enable building KUnit Date: Fri, 10 May 2019 12:03:57 +0900 Message-ID: References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-7-brendanhiggins@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190501230126.229218-7-brendanhiggins@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Brendan Higgins Cc: Frank Rowand , Greg Kroah-Hartman , Kees Cook , kieran.bingham@ideasonboard.com, "Luis R. Rodriguez" , Rob Herring , Stephen Boyd , "Cc: Shuah Khan" , DTML , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com List-Id: linux-nvdimm@lists.01.org On Thu, May 2, 2019 at 8:03 AM Brendan Higgins wrote: > > Add KUnit to root Kconfig and Makefile allowing it to actually be built. > > Signed-off-by: Brendan Higgins You need to make sure to not break git-bisect'abililty. With this commit, I see build error. CC kunit/test.o kunit/test.c:11:10: fatal error: os.h: No such file or directory #include ^~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.build;279: kunit/test.o] Error 1 make: *** [Makefile;1763: kunit/] Error 2 > --- > Kconfig | 2 ++ > Makefile | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index 48a80beab6853..10428501edb78 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > + > +source "kunit/Kconfig" > diff --git a/Makefile b/Makefile > index 2b99679148dc7..77368f498d84c 100644 > --- a/Makefile > +++ b/Makefile > @@ -969,7 +969,7 @@ endif > PHONY += prepare0 > > ifeq ($(KBUILD_EXTMOD),) > -core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ > +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/ > > vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ > $(core-y) $(core-m) $(drivers-y) $(drivers-m) \ > -- > 2.21.0.593.g511ec345e18-goog > -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5303AC04AB3 for ; Fri, 10 May 2019 03:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2268A2182B for ; Fri, 10 May 2019 03:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="jupzuktq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727067AbfEJDEq (ORCPT ); Thu, 9 May 2019 23:04:46 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:48677 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726842AbfEJDEp (ORCPT ); Thu, 9 May 2019 23:04:45 -0400 X-Greylist: delayed 42282 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 May 2019 23:04:43 EDT Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (authenticated) by conssluserg-03.nifty.com with ESMTP id x4A34XGX005393; Fri, 10 May 2019 12:04:34 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com x4A34XGX005393 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557457474; bh=DYJ0GRwyv9LQw+wYut+AKlESUHW5OcD/mZsMQ0v23g4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jupzuktqIfQz0vJS1GaSpRqu2LQlIojIZ6l/TI0jmjH+y1VkJRBs89e7uRAv6B1Ef uHXWjQCyh3QM1FLLkbOfmNDmcIDMv3Oq/FlPK1nJiwjkiN5C9tudnBuh0F8evz5qm8 ZorME1HYwlKxsObBT8LwUNg5l1Fi86fQ7ffUtVkUvXf1TvrufFpYms99rIymu6dL/K hIlycbAJXfNN986oEc9iUdGhQ9gZ5CSC7yKV9BeU183dZd8/MJ0EQhq+4AgJe2J6jP TyF0SLqvX8D3dQhEIQDaNOjnh/QC3NF0r7D48IC/P5jvWFHuMVUbINwaFq0DbE19/a SQYZWBc5p+oIQ== X-Nifty-SrcIP: [209.85.221.172] Received: by mail-vk1-f172.google.com with SMTP id r195so1138772vke.0; Thu, 09 May 2019 20:04:34 -0700 (PDT) X-Gm-Message-State: APjAAAXPoLeBAjMKgvMs+7lHCRTpm9Hq0dTQmmpAFWkoH4tUhr5WR/3F J7W+aIcHDbWUKKSwAH8vslzCIpnSnNqVTr2rDMc= X-Google-Smtp-Source: APXvYqy2m1+g4N+7CIk2iyVkz9i+viWE9nsO8OqKDhs3ADzAs5NWYmvIdraov4KIA0ibHwe/v+Jg8QmbzOy0PS2UyFc= X-Received: by 2002:a1f:d585:: with SMTP id m127mr3859437vkg.34.1557457473272; Thu, 09 May 2019 20:04:33 -0700 (PDT) MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-7-brendanhiggins@google.com> In-Reply-To: <20190501230126.229218-7-brendanhiggins@google.com> From: Masahiro Yamada Date: Fri, 10 May 2019 12:03:57 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 06/17] kbuild: enable building KUnit To: Brendan Higgins Cc: Frank Rowand , Greg Kroah-Hartman , Kees Cook , kieran.bingham@ideasonboard.com, "Luis R. Rodriguez" , Rob Herring , Stephen Boyd , "Cc: Shuah Khan" , DTML , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim Bird , amir73il@gmail.com, Dan Carpenter , Dan Williams , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Richard Weinberger , rientjes@google.com, Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 2, 2019 at 8:03 AM Brendan Higgins wrote: > > Add KUnit to root Kconfig and Makefile allowing it to actually be built. > > Signed-off-by: Brendan Higgins You need to make sure to not break git-bisect'abililty. With this commit, I see build error. CC kunit/test.o kunit/test.c:11:10: fatal error: os.h: No such file or directory #include ^~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.build;279: kunit/test.o] Error 1 make: *** [Makefile;1763: kunit/] Error 2 > --- > Kconfig | 2 ++ > Makefile | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index 48a80beab6853..10428501edb78 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > + > +source "kunit/Kconfig" > diff --git a/Makefile b/Makefile > index 2b99679148dc7..77368f498d84c 100644 > --- a/Makefile > +++ b/Makefile > @@ -969,7 +969,7 @@ endif > PHONY += prepare0 > > ifeq ($(KBUILD_EXTMOD),) > -core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ > +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/ > > vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ > $(core-y) $(core-m) $(drivers-y) $(drivers-m) \ > -- > 2.21.0.593.g511ec345e18-goog > -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro at socionext.com (Masahiro Yamada) Date: Fri, 10 May 2019 12:03:57 +0900 Subject: [PATCH v2 06/17] kbuild: enable building KUnit In-Reply-To: <20190501230126.229218-7-brendanhiggins@google.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-7-brendanhiggins@google.com> Message-ID: On Thu, May 2, 2019 at 8:03 AM Brendan Higgins wrote: > > Add KUnit to root Kconfig and Makefile allowing it to actually be built. > > Signed-off-by: Brendan Higgins You need to make sure to not break git-bisect'abililty. With this commit, I see build error. CC kunit/test.o kunit/test.c:11:10: fatal error: os.h: No such file or directory #include ^~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.build;279: kunit/test.o] Error 1 make: *** [Makefile;1763: kunit/] Error 2 > --- > Kconfig | 2 ++ > Makefile | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index 48a80beab6853..10428501edb78 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > + > +source "kunit/Kconfig" > diff --git a/Makefile b/Makefile > index 2b99679148dc7..77368f498d84c 100644 > --- a/Makefile > +++ b/Makefile > @@ -969,7 +969,7 @@ endif > PHONY += prepare0 > > ifeq ($(KBUILD_EXTMOD),) > -core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ > +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/ > > vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ > $(core-y) $(core-m) $(drivers-y) $(drivers-m) \ > -- > 2.21.0.593.g511ec345e18-goog > -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro@socionext.com (Masahiro Yamada) Date: Fri, 10 May 2019 12:03:57 +0900 Subject: [PATCH v2 06/17] kbuild: enable building KUnit In-Reply-To: <20190501230126.229218-7-brendanhiggins@google.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-7-brendanhiggins@google.com> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190510030357.SkIA-uwna1xJAL8RsPJ00ogJE_HQxTlrwSOWfetHcpQ@z> On Thu, May 2, 2019 at 8:03 AM Brendan Higgins wrote: > > Add KUnit to root Kconfig and Makefile allowing it to actually be built. > > Signed-off-by: Brendan Higgins You need to make sure to not break git-bisect'abililty. With this commit, I see build error. CC kunit/test.o kunit/test.c:11:10: fatal error: os.h: No such file or directory #include ^~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.build;279: kunit/test.o] Error 1 make: *** [Makefile;1763: kunit/] Error 2 > --- > Kconfig | 2 ++ > Makefile | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index 48a80beab6853..10428501edb78 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > + > +source "kunit/Kconfig" > diff --git a/Makefile b/Makefile > index 2b99679148dc7..77368f498d84c 100644 > --- a/Makefile > +++ b/Makefile > @@ -969,7 +969,7 @@ endif > PHONY += prepare0 > > ifeq ($(KBUILD_EXTMOD),) > -core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ > +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/ > > vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ > $(core-y) $(core-m) $(drivers-y) $(drivers-m) \ > -- > 2.21.0.593.g511ec345e18-goog > -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-03.nifty.com ([210.131.2.82]:48677 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726842AbfEJDEp (ORCPT ); Thu, 9 May 2019 23:04:45 -0400 MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-7-brendanhiggins@google.com> In-Reply-To: <20190501230126.229218-7-brendanhiggins@google.com> From: Masahiro Yamada Date: Fri, 10 May 2019 12:03:57 +0900 Message-ID: Subject: Re: [PATCH v2 06/17] kbuild: enable building KUnit Content-Type: text/plain; charset="UTF-8" Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Brendan Higgins Cc: Frank Rowand , Greg Kroah-Hartman , Kees Cook , kieran.bingham@ideasonboard.com, "Luis R. Rodriguez" , Rob Herring , Stephen Boyd , "Cc: Shuah Khan" , DTML , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim Bird , amir73il@gmail.com, Dan Carpenter , Dan Williams , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Richard Weinberger , rientjes@google.com, Steven Rostedt , wfg@linux.intel.com On Thu, May 2, 2019 at 8:03 AM Brendan Higgins wrote: > > Add KUnit to root Kconfig and Makefile allowing it to actually be built. > > Signed-off-by: Brendan Higgins You need to make sure to not break git-bisect'abililty. With this commit, I see build error. CC kunit/test.o kunit/test.c:11:10: fatal error: os.h: No such file or directory #include ^~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.build;279: kunit/test.o] Error 1 make: *** [Makefile;1763: kunit/] Error 2 > --- > Kconfig | 2 ++ > Makefile | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index 48a80beab6853..10428501edb78 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > + > +source "kunit/Kconfig" > diff --git a/Makefile b/Makefile > index 2b99679148dc7..77368f498d84c 100644 > --- a/Makefile > +++ b/Makefile > @@ -969,7 +969,7 @@ endif > PHONY += prepare0 > > ifeq ($(KBUILD_EXTMOD),) > -core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ > +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/ > > vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ > $(core-y) $(core-m) $(drivers-y) $(drivers-m) \ > -- > 2.21.0.593.g511ec345e18-goog > -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-06.nifty.com ([210.131.2.91]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOvq5-0002il-Jy for linux-um@lists.infradead.org; Fri, 10 May 2019 03:04:51 +0000 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (authenticated) by conssluserg-06.nifty.com with ESMTP id x4A34XfP008479 for ; Fri, 10 May 2019 12:04:34 +0900 Received: by mail-vk1-f170.google.com with SMTP id h127so1119235vkd.12 for ; Thu, 09 May 2019 20:04:34 -0700 (PDT) MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-7-brendanhiggins@google.com> In-Reply-To: <20190501230126.229218-7-brendanhiggins@google.com> From: Masahiro Yamada Date: Fri, 10 May 2019 12:03:57 +0900 Message-ID: Subject: Re: [PATCH v2 06/17] kbuild: enable building KUnit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: Petr Mladek , "open list:DOCUMENTATION" , amir73il@gmail.com, dri-devel , Alexander.Levin@microsoft.com, Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , "Cc: Shuah Khan" , Rob Herring , linux-nvdimm@lists.01.org, Frank Rowand , Knut Omang , kieran.bingham@ideasonboard.com, wfg@linux.intel.com, Joel Stanley , rientjes@google.com, Jeff Dike , Dan Carpenter , DTML , Linux Kbuild mailing list , Tim Bird , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Richard Weinberger , Stephen Boyd , Greg Kroah-Hartman , Linux Kernel Mailing List , "Luis R. Rodriguez" , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Logan Gunthorpe , Kevin Hilman On Thu, May 2, 2019 at 8:03 AM Brendan Higgins wrote: > > Add KUnit to root Kconfig and Makefile allowing it to actually be built. > > Signed-off-by: Brendan Higgins You need to make sure to not break git-bisect'abililty. With this commit, I see build error. CC kunit/test.o kunit/test.c:11:10: fatal error: os.h: No such file or directory #include ^~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.build;279: kunit/test.o] Error 1 make: *** [Makefile;1763: kunit/] Error 2 > --- > Kconfig | 2 ++ > Makefile | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index 48a80beab6853..10428501edb78 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > + > +source "kunit/Kconfig" > diff --git a/Makefile b/Makefile > index 2b99679148dc7..77368f498d84c 100644 > --- a/Makefile > +++ b/Makefile > @@ -969,7 +969,7 @@ endif > PHONY += prepare0 > > ifeq ($(KBUILD_EXTMOD),) > -core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ > +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/ > > vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ > $(core-y) $(core-m) $(drivers-y) $(drivers-m) \ > -- > 2.21.0.593.g511ec345e18-goog > -- Best Regards Masahiro Yamada _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um