From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Subject: Re: [PATCH 3/3] kbuild: clean up *.dtb and *.dtb.S patterns from top-level Makefile Date: Tue, 31 Oct 2017 01:32:15 +0900 Message-ID: References: <1509377627-11362-1-git-send-email-yamada.masahiro@socionext.com> <1509377627-11362-4-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org To: Rob Herring Cc: Linux Kbuild mailing list , Mark Rutland , Pantelis Antoniou , "devicetree@vger.kernel.org" , Matthias Kaehlcke , Josh Poimboeuf List-Id: devicetree@vger.kernel.org Hi Rob, 2017-10-31 0:53 GMT+09:00 Rob Herring : > On Mon, Oct 30, 2017 at 10:33 AM, Masahiro Yamada > wrote: >> We need to add "clean-files" in Makfiles to clean up DT blobs, but we >> often miss to do so. >> >> Since there are no source files that end with .dtb or .dtb.S, so we >> can clean-up those files from the top-level Makefile. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index 63a4c0e..c577c63 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1544,7 +1544,7 @@ clean: $(clean-dirs) >> $(call cmd,rmfiles) >> @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \ >> \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ >> - -o -name '*.ko.*' \ >> + -o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \ > > With this we can remove all the occurrences in the kernel: > > $ git grep 'clean.*dtb' > > Otherwise, the series looks good to me. I'm happy to apply it if the > kbuild folks don't. > > Rob Yes, please. Thanks! -- Best Regards Masahiro Yamada