From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755009AbdCGNJi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 08:09:38 -0500
Received: from condef-05.nifty.com ([202.248.20.70]:61251 "EHLO
        condef-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751274AbdCGNJ3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 08:09:29 -0500
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com v27D34Ou012075
X-Nifty-SrcIP: [74.125.82.173]
MIME-Version: 1.0
In-Reply-To: <20170307124034.59b5b763@bbrezillon>
References: <1488885839-18470-1-git-send-email-yamada.masahiro@socionext.com> <20170307124034.59b5b763@bbrezillon>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Tue, 7 Mar 2017 22:03:03 +0900
X-Gmail-Original-Message-ID: <CAK7LNAQ8GrGEKGArRC2+xh_JDuFjrd-wQG3kKu80-GMuXRvvBA@mail.gmail.com>
Message-ID: <CAK7LNAQ8GrGEKGArRC2+xh_JDuFjrd-wQG3kKu80-GMuXRvvBA@mail.gmail.com>
Subject: Re: [PATCH] mtd: nand: fix write accessor sanity checks
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-mtd@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Marek Vasut <marek.vasut@gmail.com>,
        Brian Norris <computersforpeace@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,


2017-03-07 20:40 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> On Tue,  7 Mar 2017 20:23:59 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
>> If the higher level accessor chip->write_page() is implemented,
>> ecc->write_page() and ecc->write_page_raw() are not required.
>
> I'm about to remove the chip->write_page() hook [1], I hope you're not
> planning to use it.
>
> [1]https://patchwork.ozlabs.org/patch/729966/
>

In fact, I was wondering if I should use chip->write_page()
for denali.c  (then I noticed this broken accessor checks).
After all, I decided to not (ab)use chip->write_page(), though.

Anyway, it is good that I am sure about this now.

Thanks!

-- 
Best Regards
Masahiro Yamada