From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbeEQNfR (ORCPT ); Thu, 17 May 2018 09:35:17 -0400 Received: from conssluserg-02.nifty.com ([210.131.2.81]:40519 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbeEQNfF (ORCPT ); Thu, 17 May 2018 09:35:05 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com w4HDYqJ1013350 X-Nifty-SrcIP: [209.85.213.48] X-Google-Smtp-Source: AB8JxZpBXQs10z60akdxA+aBw7xMP5JTJ6FUX6760FllSUxgZUTOiKxsnvj8n2k1ZhwFeQePRGyU/28xizHSpJlJ1AU= MIME-Version: 1.0 In-Reply-To: <20180516055136.6F4EAA095A@unicorn.suse.cz> References: <20180516055136.6F4EAA095A@unicorn.suse.cz> From: Masahiro Yamada Date: Thu, 17 May 2018 22:34:12 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Makefile: disable PIE before testing asm goto To: Michal Kubecek Cc: Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Peter Zijlstra , Andreas Faerber Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-05-16 14:51 GMT+09:00 Michal Kubecek : > Since commit e501ce957a78 ("x86: Force asm-goto"), aarch64 build on > distributions which enable PIE by default (e.g. openSUSE Tumbleweed) does > not detect support for asm goto correctly. The problem is that ARM specific > part of scripts/gcc-goto.sh fails with PIE even with recent gcc versions. > Moving the asm goto detection up in Makefile put it before the place where > we disable PIE. As a result, kernel is built without jump label support. > > Move the lines disabling PIE before the asm goto test to make it work. > > Fixes: e501ce957a78 ("x86: Force asm-goto") > Reported-by: Andreas Faerber > Signed-off-by: Michal Kubecek > --- Applied to linux-kbuild/fixes. Thanks! -- Best Regards Masahiro Yamada