From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA830C433DB for ; Fri, 12 Feb 2021 03:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83FE964D8F for ; Fri, 12 Feb 2021 03:09:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230031AbhBLDJA (ORCPT ); Thu, 11 Feb 2021 22:09:00 -0500 Received: from conssluserg-05.nifty.com ([210.131.2.90]:61173 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbhBLDIy (ORCPT ); Thu, 11 Feb 2021 22:08:54 -0500 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 11C37d0w009910; Fri, 12 Feb 2021 12:07:39 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 11C37d0w009910 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1613099260; bh=I5mK3G+CjJ+ik2u7vLdWvYhGKvVsmh00OZqq6nOWAfo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=oyrj/HrlI42UvZ/W4/qK01nOaTO1jKZ+Gj5Kwj/VE1NJ13/IXuJ2oniIoCC4t3Fpy fD0fJ12sl0e/dNaFQ4QdjNgUq8agIlZKJsD3UFveynhKajmvsu+8biPfBeuFeCDdH3 hlTfyqy3Dzn413PNssEmhneLlehzw5s8h0RceZbyEcNtE7JF+BwE3lWuBgOHg4xlL9 1YUEZNSVmC8gMLfCb6YkHQxrm2nJSGvf35q9yl2Y/dA3jd1nv7X7//XEnp82+ynwro 2NPTUhovCbmXsDBlQDO2aKFLlCpryxI+uxYXHU0k2AX0ul30u7QzHctKXznSOZzxy+ UnZvMEz518kXg== X-Nifty-SrcIP: [209.85.210.180] Received: by mail-pf1-f180.google.com with SMTP id c11so4963782pfp.10; Thu, 11 Feb 2021 19:07:39 -0800 (PST) X-Gm-Message-State: AOAM5335C91fISp+5UC7w9984s+yOBl7aahfMv91TFO5wxPStJ8gYyjr sz4Dmyx/Q0VEk2LrkkHo6JKNGk/9XHmeTOwdQJA= X-Google-Smtp-Source: ABdhPJx8OiSoNeZ/dmRG1leCMKTZJ1WHVjWadinf3/HxClDg13CKEIq42sKUnmjPj6qz2ebltPfCHfzmGNkzOzRQJVI= X-Received: by 2002:a62:2f07:0:b029:1bb:5f75:f985 with SMTP id v7-20020a622f070000b02901bb5f75f985mr993540pfv.76.1613099258850; Thu, 11 Feb 2021 19:07:38 -0800 (PST) MIME-Version: 1.0 References: <44dad578df8a848fc378cd358f03b071f44c9a5b.1612955268.git.viresh.kumar@linaro.org> In-Reply-To: From: Masahiro Yamada Date: Fri, 12 Feb 2021 12:07:00 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V7 1/3] kbuild: Add generic rule to apply fdtoverlay To: Rob Herring Cc: Viresh Kumar , Frank Rowand , Pantelis Antoniou , Michal Marek , Vincent Guittot , linux-arm-kernel , Linux Kernel Mailing List , Anmar Oueja , Bill Mills , David Gibson , DTML , Linux Kbuild mailing list , Geert Uytterhoeven , Michal Simek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2021 at 5:05 AM Rob Herring wrote: > > On Thu, Feb 11, 2021 at 12:28 PM Masahiro Yamada wrote: > > > > On Wed, Feb 10, 2021 at 8:13 PM Viresh Kumar wrote: > > > > > > From: Rob Herring > > > > > > Add a generic rule to apply fdtoverlay in Makefile.lib, so every > > > platform doesn't need to carry the complex rule. > > > > > > The platform's Makefile only needs to have this now: > > > > > > DTC_FLAGS_foo_base += -@ > > > foo-dtbs := foo_base.dtb foo_overlay1.dtbo foo_overlay2.dtbo > > > overlay-y := foo.dtb > > > > > > Please reuse dtb-y instead of introducing the new > > overlay-y syntax, that is, > > > > foo-dtbs := foo_base.dtb foo_overlay1.dtbo foo_overlay2.dtbo > > dtb-y := foo.dtb > > That's what I had, but I believe Viresh changed this because we don't > want to run schema checks on foo.dtb (as foo.dts doesn't exist). > However, we should be able to filter those out using something similar > to technique used for multi-used-y and real-obj-y. We just need to > drop composite entries when creating the .dt.yaml list. Yes, I think this will work. BTW, I do not know how to use overlay. Do we apply overlay in the build time? If so, I do not know what the benefit of overlay is. Or is this just for build testing? I just thought this was done in the boot time, for example, in U-Boot or something. -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC78C433DB for ; Fri, 12 Feb 2021 03:09:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDB1064D8F for ; Fri, 12 Feb 2021 03:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDB1064D8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R3N+f3n8OQGGndC/h44WSuuavTsB7/C7WnULvMYIPBQ=; b=uEpwksvXS3GfqYioRnQ8GqxyB SfFWFuPiZ+dQq+bNlM9LA1QxD9nNp5R/b8opKUooYSsZhG/ssHT+eULsjaRR9Btve05812WHMXrib inK3eKFzcPaGs362Q11wFb3+t/xocsKNx9hGPABF9wpLyG9VUFQICAZXf4XJd0Yfaw8AfRiB5K6MJ V+nA23JXSGjl+qKskDCZDKyTuxqMQsgob81eUfcAfRsFTpDGGZCSBLRjVmKS6mnE69TW1t/N94VRC TJPILJOlETjVObdb66OvtgN6i7ZEgEFcoFleKZ+14p7pudi2T7joQzpzl+2J+xpthSV0D3GDLGYGF iuJU1ttOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAOoP-0005ao-UZ; Fri, 12 Feb 2021 03:08:05 +0000 Received: from conssluserg-04.nifty.com ([210.131.2.83]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAOoI-0005ZD-Q5 for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 03:08:04 +0000 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 11C37dRr004216 for ; Fri, 12 Feb 2021 12:07:39 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 11C37dRr004216 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1613099259; bh=I5mK3G+CjJ+ik2u7vLdWvYhGKvVsmh00OZqq6nOWAfo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=U3J6rzjbZF8l44vkKrATaE0qezpR8MFR62TM0LZOUbJ7vuE/1zaggR0EwT8wWWnAF rqTcWMKaPu0Cx6W/Ik/el301aqG6pboVCpROn/dBSrY7HOdgYKUiVVuQFdl0eAZxVP Di2WKftCbWb8t2r0WLXTn9NV4TbAbqPaW6Nl15SZF5OqHalPDQBjBpx+rTPqhRu0hJ Gpf4eejQfW4/eiio3SkTqcaZsv19ar9XA5nvFp68t9RNajnml5oG+jL0mcFlgdSJ2W /xxZCSJjPCeC+uWzyFGWSLKPUTWPQPZDT//oyINkwuPxYZc52AI7NkF1/KhHXmkfVv sm9i+PFqhAYCQ== X-Nifty-SrcIP: [209.85.210.172] Received: by mail-pf1-f172.google.com with SMTP id d26so4980915pfn.5 for ; Thu, 11 Feb 2021 19:07:39 -0800 (PST) X-Gm-Message-State: AOAM5320HESBFsjDCCch40Nlhoscy8hnCkyHEIwyAEc587XHMDaBltid Ft3DHjC5MCwhOvuidgI52c0Svutg+G6b9pLNM/w= X-Google-Smtp-Source: ABdhPJx8OiSoNeZ/dmRG1leCMKTZJ1WHVjWadinf3/HxClDg13CKEIq42sKUnmjPj6qz2ebltPfCHfzmGNkzOzRQJVI= X-Received: by 2002:a62:2f07:0:b029:1bb:5f75:f985 with SMTP id v7-20020a622f070000b02901bb5f75f985mr993540pfv.76.1613099258850; Thu, 11 Feb 2021 19:07:38 -0800 (PST) MIME-Version: 1.0 References: <44dad578df8a848fc378cd358f03b071f44c9a5b.1612955268.git.viresh.kumar@linaro.org> In-Reply-To: From: Masahiro Yamada Date: Fri, 12 Feb 2021 12:07:00 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V7 1/3] kbuild: Add generic rule to apply fdtoverlay To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_220759_311585_4C64DA6D X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Michal Marek , Vincent Guittot , Linux Kbuild mailing list , Viresh Kumar , Bill Mills , Pantelis Antoniou , Linux Kernel Mailing List , Michal Simek , Anmar Oueja , Geert Uytterhoeven , Frank Rowand , linux-arm-kernel , David Gibson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 12, 2021 at 5:05 AM Rob Herring wrote: > > On Thu, Feb 11, 2021 at 12:28 PM Masahiro Yamada wrote: > > > > On Wed, Feb 10, 2021 at 8:13 PM Viresh Kumar wrote: > > > > > > From: Rob Herring > > > > > > Add a generic rule to apply fdtoverlay in Makefile.lib, so every > > > platform doesn't need to carry the complex rule. > > > > > > The platform's Makefile only needs to have this now: > > > > > > DTC_FLAGS_foo_base += -@ > > > foo-dtbs := foo_base.dtb foo_overlay1.dtbo foo_overlay2.dtbo > > > overlay-y := foo.dtb > > > > > > Please reuse dtb-y instead of introducing the new > > overlay-y syntax, that is, > > > > foo-dtbs := foo_base.dtb foo_overlay1.dtbo foo_overlay2.dtbo > > dtb-y := foo.dtb > > That's what I had, but I believe Viresh changed this because we don't > want to run schema checks on foo.dtb (as foo.dts doesn't exist). > However, we should be able to filter those out using something similar > to technique used for multi-used-y and real-obj-y. We just need to > drop composite entries when creating the .dt.yaml list. Yes, I think this will work. BTW, I do not know how to use overlay. Do we apply overlay in the build time? If so, I do not know what the benefit of overlay is. Or is this just for build testing? I just thought this was done in the boot time, for example, in U-Boot or something. -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel