From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Wed, 31 Jan 2018 01:23:19 +0900 Subject: [U-Boot] [PATCH] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set In-Reply-To: <20180130152313.28099-1-abrodkin@synopsys.com> References: <20180130152313.28099-1-abrodkin@synopsys.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 2018-01-31 0:23 GMT+09:00 Alexey Brodkin : > CONFIG_SYS_TEXT_BASE must be set anyways and then it is used in many > places in the same Makefile without any checks so there's no point in > keeping this check araound just in one place. > > Signed-off-by: Alexey Brodkin > Cc: Tom Rini > --- > Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Makefile b/Makefile > index ab3453dcebdc..6f15612b4d07 100644 > --- a/Makefile > +++ b/Makefile > @@ -820,9 +820,7 @@ LDFLAGS_u-boot += $(LDFLAGS_FINAL) > # Avoid 'Not enough room for program headers' error on binutils 2.28 onwards. > LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker) > > -ifneq ($(CONFIG_SYS_TEXT_BASE),) > LDFLAGS_u-boot += -Ttext $(CONFIG_SYS_TEXT_BASE) > -endif Please feel free to include historical reason: This ifneq conditional was added for Blackfin because it did not use CONFIG_SYS_TEXT_BASE. See. https://github.com/u-boot/u-boot/blob/v2017.03/arch/blackfin/config.mk#L67 Then Blackfin is gone, so should be OK. Acked-by: Masahiro Yamada > # Normally we fill empty space with 0xff > quiet_cmd_objcopy = OBJCOPY $@ > -- > 2.14.3 > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot -- Best Regards Masahiro Yamada