From mboxrd@z Thu Jan  1 00:00:00 1970
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Fri, 8 May 2015 12:30:39 +0900
Subject: [U-Boot] [PATCH v1 3/4] autoboot.c: Move config options to
	Kconfig
In-Reply-To: <CAPnjgZ2wDiY1KXftDWJKi+2DXO61QwGR4p_uj65iHEAi13e2Dw@mail.gmail.com>
References: <1431000847-22183-1-git-send-email-sr@denx.de>
 <1431000847-22183-4-git-send-email-sr@denx.de>
 <CAPnjgZ2wDiY1KXftDWJKi+2DXO61QwGR4p_uj65iHEAi13e2Dw@mail.gmail.com>
Message-ID: <CAK7LNAQd-4mZZc+Vzku65gBcRwzOpNnmgtjdBUq2NcHAet8mMA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefan,

2015-05-08 8:51 GMT+09:00 Simon Glass <sjg@chromium.org>:
> Hi Stefan,
>
> On 7 May 2015 at 06:13, Stefan Roese <sr@denx.de> wrote:
>> This patch moves the following config options to Kconfig:
>>
>> CONFIG_AUTOBOOT_KEYED
>> CONFIG_AUTOBOOT_PROMPT
>> CONFIG_AUTOBOOT_DELAY_STR
>> CONFIG_AUTOBOOT_STOP_STR
>> AUTOBOOT_KEYED_CTRLC
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Simon Glass <sjg@chromium.org>


Thanks for working on a task requiring much effort.


I am just wondering if we need not move the prompt messages verbatim to Kconfig.

I know CONFIG_AUTOBOOT_PROMPT provides us the best flexibility,
but the messages are most likely "autoboot in %d seconds" or "Press ...".

Can we put the message directly into common/autoboot.c like this?

 #ifdef CONFIG_SHOW_AUTOBOOT_PROMPT
        printf("Autoboot in %d seconds\n", CONFIG_BOOTDELAY);
        printf("Press %c to abort in %d seconds\n", CONFIG_AUTOBOOT_STOP_STR);
 #endif


I think I am missing some things here:
  - Those boards that require a password do not want to show it
  - We need to convert " " to user-visible "<SPACE>" if
CONFIG_AUTOBOOT_STOP_STP == " "


Any ideas?


-- 
Best Regards
Masahiro Yamada