From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Subject: Re: [PATCH] kbuild: modpost: Warn about references from rodata to __init text Date: Wed, 19 Jul 2017 03:38:57 +0900 Message-ID: References: <20170630225822.25349-1-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170630225822.25349-1-sboyd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: Michal Marek , Linux Kernel Mailing List , linux-arm-msm , linux-arm-kernel , Linux Kbuild mailing list , Rob Clark , Bjorn Andersson List-Id: linux-arm-msm@vger.kernel.org 2017-07-01 7:58 GMT+09:00 Stephen Boyd : > If we have a structure that's marked const it will be placed > into the .rodata section but it could reference an init section > function. Include the read only data section in the check we have > for read/write data sections referencing init sections so we can > find this class of problems. This exposes quite a few places > where const marked structures are referencing __init functions and > __init data that we were previously ignoring. > > Cc: Rob Clark > Cc: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- > > Making this change leads to quite a few other errors even on the > multi_v7_defconfig for ARM[1]. I still need to do a build of the > allmodconfig to see how many other errors there, but it seems to > be quite a few. I suppose those will need to be fixed before we can > merge this? > > [1] https://www.irccloud.com/pastebin/zzqfWGQY/ Applied to linux-kbuild/misc. Thanks! Now people will notice the warnings in linux-next, and will start fixing drivers. We still have plenty of time until the next merge windows. :-) -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro@socionext.com (Masahiro Yamada) Date: Wed, 19 Jul 2017 03:38:57 +0900 Subject: [PATCH] kbuild: modpost: Warn about references from rodata to __init text In-Reply-To: <20170630225822.25349-1-sboyd@codeaurora.org> References: <20170630225822.25349-1-sboyd@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017-07-01 7:58 GMT+09:00 Stephen Boyd : > If we have a structure that's marked const it will be placed > into the .rodata section but it could reference an init section > function. Include the read only data section in the check we have > for read/write data sections referencing init sections so we can > find this class of problems. This exposes quite a few places > where const marked structures are referencing __init functions and > __init data that we were previously ignoring. > > Cc: Rob Clark > Cc: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- > > Making this change leads to quite a few other errors even on the > multi_v7_defconfig for ARM[1]. I still need to do a build of the > allmodconfig to see how many other errors there, but it seems to > be quite a few. I suppose those will need to be fixed before we can > merge this? > > [1] https://www.irccloud.com/pastebin/zzqfWGQY/ Applied to linux-kbuild/misc. Thanks! Now people will notice the warnings in linux-next, and will start fixing drivers. We still have plenty of time until the next merge windows. :-) -- Best Regards Masahiro Yamada