From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbeDLJJy (ORCPT ); Thu, 12 Apr 2018 05:09:54 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:42667 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbeDLJJx (ORCPT ); Thu, 12 Apr 2018 05:09:53 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com w3C99d7g003906 X-Nifty-SrcIP: [209.85.213.48] X-Google-Smtp-Source: AIpwx49aDnz9FylNd88LZm7GzJOISvLS+BHIi6Xq7NR+v7YTLYiuu32SbEaSXQyzJvnMaFr8EVH/ILDZB7K9vQPzTz4= MIME-Version: 1.0 In-Reply-To: <20180412082157.GB4002@localhost.localdomain> References: <20180411211543.7923-1-d-gerlach@ti.com> <20180412082157.GB4002@localhost.localdomain> From: Masahiro Yamada Date: Thu, 12 Apr 2018 18:08:58 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: omap2: Fix build when using split object directories To: Anders Roxell Cc: Dave Gerlach , Linux Kernel Mailing List , Tony Lindgren , Russell King - ARM Linux , Santosh Shilimkar , linux-arm-kernel , Linux-OMAP , Linux Kbuild mailing list , Michal Marek Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-04-12 17:21 GMT+09:00 Anders Roxell : > On 2018-04-11 16:15, Dave Gerlach wrote: >> The sleep33xx and sleep43xx files should not depend on a header file >> generated in drivers/memory. Remove this dependency and instead allow >> both drivers/memory and arch/arm/mach-omap2 to generate all macros >> needed in headers local to their own paths. >> >> This fixes an issue where the build fail will when using O= to set a >> split object directory and arch/arm/mach-omap2 is built before >> drivers/memory with the following error: >> >> .../drivers/memory/emif-asm-offsets.c:1:0: fatal error: can't open drivers/memory/emif-asm-offsets.s for writing: No such file or directory >> compilation terminated. >> >> Fixes: 41d9d44d7258 ("ARM: OMAP2+: pm33xx-core: Add platform code needed for PM") >> Acked-by: Tony Lindgren >> Reviewed-by: Masahiro Yamada >> Signed-off-by: Dave Gerlach > > Tested-by: Anders Roxell > > Maybe we can remove drivers/memory/Makefile.asm-offsets and move those > changes into drivers/memory/Makefile ? Agree! -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro@socionext.com (Masahiro Yamada) Date: Thu, 12 Apr 2018 18:08:58 +0900 Subject: [PATCH] ARM: omap2: Fix build when using split object directories In-Reply-To: <20180412082157.GB4002@localhost.localdomain> References: <20180411211543.7923-1-d-gerlach@ti.com> <20180412082157.GB4002@localhost.localdomain> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2018-04-12 17:21 GMT+09:00 Anders Roxell : > On 2018-04-11 16:15, Dave Gerlach wrote: >> The sleep33xx and sleep43xx files should not depend on a header file >> generated in drivers/memory. Remove this dependency and instead allow >> both drivers/memory and arch/arm/mach-omap2 to generate all macros >> needed in headers local to their own paths. >> >> This fixes an issue where the build fail will when using O= to set a >> split object directory and arch/arm/mach-omap2 is built before >> drivers/memory with the following error: >> >> .../drivers/memory/emif-asm-offsets.c:1:0: fatal error: can't open drivers/memory/emif-asm-offsets.s for writing: No such file or directory >> compilation terminated. >> >> Fixes: 41d9d44d7258 ("ARM: OMAP2+: pm33xx-core: Add platform code needed for PM") >> Acked-by: Tony Lindgren >> Reviewed-by: Masahiro Yamada >> Signed-off-by: Dave Gerlach > > Tested-by: Anders Roxell > > Maybe we can remove drivers/memory/Makefile.asm-offsets and move those > changes into drivers/memory/Makefile ? Agree! -- Best Regards Masahiro Yamada