From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbdLEA7u (ORCPT ); Mon, 4 Dec 2017 19:59:50 -0500 Received: from conssluserg-02.nifty.com ([210.131.2.81]:25322 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbdLEA7s (ORCPT ); Mon, 4 Dec 2017 19:59:48 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com vB50xZSr014887 X-Nifty-SrcIP: [209.85.217.175] X-Google-Smtp-Source: AGs4zMbps+BXCcN3/KtT2WwW45/+p1vyXC1cW8NyMijmUaC0hLMReaBx4WD1w3lyFimbMJQ1FRoAQTsntzA1kXotySI= MIME-Version: 1.0 In-Reply-To: <20171204182027.2k5uw5og65h6ac7w@sirena.org.uk> References: <20171122114321.29196-1-suzuki.katsuhiro@socionext.com> <20171122114321.29196-5-suzuki.katsuhiro@socionext.com> <20171204182027.2k5uw5og65h6ac7w@sirena.org.uk> From: Masahiro Yamada Date: Tue, 5 Dec 2017 09:58:54 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/8] ASoC: uniphier: add support for UniPhier EVEA codec To: Mark Brown Cc: Katsuhiro Suzuki , alsa-devel@alsa-project.org, Rob Herring , devicetree@vger.kernel.org, Masami Hiramatsu , Jassi Brar , linux-arm-kernel , Linux Kernel Mailing List , Thomas Gleixner , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +CC Greg-KH +CC Thomas Gleixner 2017-12-05 3:20 GMT+09:00 Mark Brown : > On Wed, Nov 22, 2017 at 08:43:17PM +0900, Katsuhiro Suzuki wrote: > >> +++ b/sound/soc/uniphier/evea.c >> @@ -0,0 +1,567 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Socionext UniPhier EVEA ADC/DAC codec driver. >> + * >> + * Copyright (c) 2016-2017 Socionext Inc. > > Make the entire comment a C++ comment, don't mix and match like this - > it's ugly. Otherwise this looks good so I'll apply it, please send a > followup patch fixing this (and I guess the same thing will apply to > other files). Indeed ugly, but I think this is intentional to make the SPDX line stand out. Linus suggested this as far as I understood from the following: https://patchwork.kernel.org/patch/10016201/ If you use C++ comment style for the entire block, it will not stand out. -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro@socionext.com (Masahiro Yamada) Date: Tue, 5 Dec 2017 09:58:54 +0900 Subject: [PATCH 4/8] ASoC: uniphier: add support for UniPhier EVEA codec In-Reply-To: <20171204182027.2k5uw5og65h6ac7w@sirena.org.uk> References: <20171122114321.29196-1-suzuki.katsuhiro@socionext.com> <20171122114321.29196-5-suzuki.katsuhiro@socionext.com> <20171204182027.2k5uw5og65h6ac7w@sirena.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org +CC Greg-KH +CC Thomas Gleixner 2017-12-05 3:20 GMT+09:00 Mark Brown : > On Wed, Nov 22, 2017 at 08:43:17PM +0900, Katsuhiro Suzuki wrote: > >> +++ b/sound/soc/uniphier/evea.c >> @@ -0,0 +1,567 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Socionext UniPhier EVEA ADC/DAC codec driver. >> + * >> + * Copyright (c) 2016-2017 Socionext Inc. > > Make the entire comment a C++ comment, don't mix and match like this - > it's ugly. Otherwise this looks good so I'll apply it, please send a > followup patch fixing this (and I guess the same thing will apply to > other files). Indeed ugly, but I think this is intentional to make the SPDX line stand out. Linus suggested this as far as I understood from the following: https://patchwork.kernel.org/patch/10016201/ If you use C++ comment style for the entire block, it will not stand out. -- Best Regards Masahiro Yamada