* [PATCH] .gitignore: Add compilation database files
@ 2019-07-21 8:54 Toru Komatsu
2019-07-22 19:25 ` Nick Desaulniers
2019-07-23 15:33 ` Masahiro Yamada
0 siblings, 2 replies; 6+ messages in thread
From: Toru Komatsu @ 2019-07-21 8:54 UTC (permalink / raw)
To: linux-kernel; +Cc: yamada.masahiro, clang-built-linux, Toru Komatsu
This file is used by clangd to use language server protocol.
It can be generated at each compile using scripts/gen_compile_commands.py.
Therefore it is different depending on the environment and should be
ignored.
Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 8f5422cba6e2..025d887f64f1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -142,3 +142,6 @@ x509.genkey
# Kdevelop4
*.kdev4
+
+# Clang's compilation database files
+/compile_commands.json
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] .gitignore: Add compilation database files
2019-07-21 8:54 [PATCH] .gitignore: Add compilation database files Toru Komatsu
@ 2019-07-22 19:25 ` Nick Desaulniers
2019-07-23 15:33 ` Masahiro Yamada
1 sibling, 0 replies; 6+ messages in thread
From: Nick Desaulniers @ 2019-07-22 19:25 UTC (permalink / raw)
To: Toru Komatsu; +Cc: LKML, Masahiro Yamada, clang-built-linux, Tom Roeder
On Sun, Jul 21, 2019 at 1:54 AM Toru Komatsu <k0ma@utam0k.jp> wrote:
>
> This file is used by clangd to use language server protocol.
> It can be generated at each compile using scripts/gen_compile_commands.py.
> Therefore it is different depending on the environment and should be
> ignored.
>
> Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 8f5422cba6e2..025d887f64f1 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -142,3 +142,6 @@ x509.genkey
>
> # Kdevelop4
> *.kdev4
> +
> +# Clang's compilation database files
> +/compile_commands.json
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Also, if you're doing anything exciting with compile_commands.json,
I'd love to know. We're using it for static analyses.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] .gitignore: Add compilation database files
2019-07-21 8:54 [PATCH] .gitignore: Add compilation database files Toru Komatsu
2019-07-22 19:25 ` Nick Desaulniers
@ 2019-07-23 15:33 ` Masahiro Yamada
2019-07-23 16:28 ` Toru Komatsu
1 sibling, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2019-07-23 15:33 UTC (permalink / raw)
To: Toru Komatsu; +Cc: Linux Kernel Mailing List, clang-built-linux
Just a nit.
The patch title is:
.gitignore: Add compilation database "files"
Maybe, should it be singular?
On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <k0ma@utam0k.jp> wrote:
>
> This file is used by clangd to use language server protocol.
> It can be generated at each compile using scripts/gen_compile_commands.py.
> Therefore it is different depending on the environment and should be
> ignored.
>
> Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 8f5422cba6e2..025d887f64f1 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -142,3 +142,6 @@ x509.genkey
>
> # Kdevelop4
> *.kdev4
> +
> +# Clang's compilation database files
> +/compile_commands.json
> --
> 2.17.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] .gitignore: Add compilation database files
2019-07-23 15:33 ` Masahiro Yamada
@ 2019-07-23 16:28 ` Toru Komatsu
2019-07-23 16:36 ` Masahiro Yamada
2019-07-23 19:46 ` Nick Desaulniers
0 siblings, 2 replies; 6+ messages in thread
From: Toru Komatsu @ 2019-07-23 16:28 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Linux Kernel Mailing List, clang-built-linux
On 07/24, Masahiro Yamada wrote:
> Just a nit.
>
> The patch title is:
> .gitignore: Add compilation database "files"
>
> Maybe, should it be singular?
>
>
> On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <k0ma@utam0k.jp> wrote:
> >
> > This file is used by clangd to use language server protocol.
> > It can be generated at each compile using scripts/gen_compile_commands.py.
> > Therefore it is different depending on the environment and should be
> > ignored.
> >
> > Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> > ---
> > .gitignore | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 8f5422cba6e2..025d887f64f1 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -142,3 +142,6 @@ x509.genkey
> >
> > # Kdevelop4
> > *.kdev4
> > +
> > +# Clang's compilation database files
> > +/compile_commands.json
> > --
> > 2.17.1
> >
>
>
> --
> Best Regards
> Masahiro Yamada
--
Thanks for your review.
Sorry, this point which you pointed out is my mistake.
It is should be "file".
I'm begginer because this patch is my first time,
What should I do next?
> Thanks,
> ~Toru Komatsu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] .gitignore: Add compilation database files
2019-07-23 16:28 ` Toru Komatsu
@ 2019-07-23 16:36 ` Masahiro Yamada
2019-07-23 19:46 ` Nick Desaulniers
1 sibling, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2019-07-23 16:36 UTC (permalink / raw)
To: Toru Komatsu; +Cc: Linux Kernel Mailing List, clang-built-linux
On Wed, Jul 24, 2019 at 1:28 AM Toru Komatsu <k0ma@utam0k.jp> wrote:
>
> On 07/24, Masahiro Yamada wrote:
> > Just a nit.
> >
> > The patch title is:
> > .gitignore: Add compilation database "files"
> >
> > Maybe, should it be singular?
> >
> >
> > On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <k0ma@utam0k.jp> wrote:
> > >
> > > This file is used by clangd to use language server protocol.
> > > It can be generated at each compile using scripts/gen_compile_commands.py.
> > > Therefore it is different depending on the environment and should be
> > > ignored.
> > >
> > > Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> > > ---
> > > .gitignore | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/.gitignore b/.gitignore
> > > index 8f5422cba6e2..025d887f64f1 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -142,3 +142,6 @@ x509.genkey
> > >
> > > # Kdevelop4
> > > *.kdev4
> > > +
> > > +# Clang's compilation database files
> > > +/compile_commands.json
> > > --
> > > 2.17.1
> > >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
>
> --
>
> Thanks for your review.
>
> Sorry, this point which you pointed out is my mistake.
> It is should be "file".
>
> I'm begginer because this patch is my first time,
> What should I do next?
This patch is trivial enough.
I will change "files" -> "file"
(patch subject and code),
then I will apply it.
Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] .gitignore: Add compilation database files
2019-07-23 16:28 ` Toru Komatsu
2019-07-23 16:36 ` Masahiro Yamada
@ 2019-07-23 19:46 ` Nick Desaulniers
1 sibling, 0 replies; 6+ messages in thread
From: Nick Desaulniers @ 2019-07-23 19:46 UTC (permalink / raw)
To: Toru Komatsu
Cc: Masahiro Yamada, Linux Kernel Mailing List, clang-built-linux
On Tue, Jul 23, 2019 at 9:28 AM Toru Komatsu <k0ma@utam0k.jp> wrote:
> I'm begginer because this patch is my first time,
> What should I do next?
https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/
TL;DR
<edit file>
$ git commit <file> --amend
$ git format-patch -v2
<resend>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-23 19:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21 8:54 [PATCH] .gitignore: Add compilation database files Toru Komatsu
2019-07-22 19:25 ` Nick Desaulniers
2019-07-23 15:33 ` Masahiro Yamada
2019-07-23 16:28 ` Toru Komatsu
2019-07-23 16:36 ` Masahiro Yamada
2019-07-23 19:46 ` Nick Desaulniers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.