All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	debian-kernel <debian-kernel@lists.debian.org>
Subject: Re: [PATCH v2] kbuild: Do not use hyphen in exported variable name
Date: Sun, 20 Aug 2017 21:55:01 +0900	[thread overview]
Message-ID: <CAK7LNARU=mLDYD+kU7K_+cKLOmN4zpb1ybM650igAJ=JDqPz4Q@mail.gmail.com> (raw)
In-Reply-To: <20170819213002.GI18698@decadent.org.uk>

2017-08-20 6:30 GMT+09:00 Ben Hutchings <ben@decadent.org.uk>:
> This definition in Makefile.dtbinst:
>
>     export dtbinst-root ?= $(obj)
>
> should define and export dtbinst-root when handling the root dts
> directory, and do nothing in the subdirectories.  However some shells,
> including dash, will not pass through environment variables whose name
> includes a hyphen.  Usually GNU make does not use a shell to recurse,
> but if e.g. $(srctree) contains '~' it will use a shell here.
>
> Rename the variable to dtbinst_root.
>
> References: https://bugs.debian.org/833561
> Fixes: 323a028d39cdi ("dts, kbuild: Implement support for dtb vendor subdirs")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> v2: Revised the commit message to explain exactly how the hyphenated
> variable can be lost.
>

Thanks for figuring out the root cause!

Applied to linux-kbuild/fixes.

-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2017-08-20 12:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 21:30 [PATCH v2] kbuild: Do not use hyphen in exported variable name Ben Hutchings
2017-08-20 12:55 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNARU=mLDYD+kU7K_+cKLOmN4zpb1ybM650igAJ=JDqPz4Q@mail.gmail.com' \
    --to=yamada.masahiro@socionext.com \
    --cc=ben@decadent.org.uk \
    --cc=debian-kernel@lists.debian.org \
    --cc=linux-kbuild@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.