All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/11] Convert CONFIG_ARCH_EARLY_INIT_R to Kconfig
Date: Tue, 24 Jan 2017 11:36:11 +0900	[thread overview]
Message-ID: <CAK7LNAR_+iJ_Ypuxin1QJF0YkTrwjM8Pbs=3v05gp=RnEFJ+cQ@mail.gmail.com> (raw)
In-Reply-To: <20170123203127.19240-4-sjg@chromium.org>

Hi Simon, Tom.

2017-01-24 5:31 GMT+09:00 Simon Glass <sjg@chromium.org>:
> This converts the following to Kconfig:
>    CONFIG_ARCH_EARLY_INIT_R
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  arch/Kconfig                                |  1 +
>  arch/arc/include/asm/config.h               |  1 -
>  arch/arm/Kconfig                            |  1 +
>  arch/arm/cpu/armv8/fsl-layerscape/Kconfig   |  4 ++++
>  common/Kconfig                              | 13 +++++++++++++
>  configs/bayleybay_defconfig                 |  1 +
>  configs/cougarcanyon2_defconfig             |  1 +
>  configs/dfi-bt700-q7x-151_defconfig         |  1 +
>  configs/efi-x86_defconfig                   |  1 +
>  configs/minnowmax_defconfig                 |  1 +
>  configs/mvebu_db-88f3720_defconfig          |  1 +
>  configs/mvebu_db-88f7040_defconfig          |  1 +
>  configs/mvebu_db-88f8040_defconfig          |  1 +
>  configs/qemu-x86_efi_payload32_defconfig    |  1 +
>  configs/qemu-x86_efi_payload64_defconfig    |  1 +
>  configs/rut_defconfig                       |  1 +
>  configs/theadorable-x86-dfi-bt700_defconfig |  1 +

I have some questions

[1] Is this a user-configurable symbol?

You use "select" in some places, but add it in defconfig in others.

This is controlling whether arch_early_init_r() is
called from common/board_r.c or not, right?

Does it make sense to skip the init function
if users want to?

Maybe, Tom will end up with converting all of them
to "select" like this?
 http://patchwork.ozlabs.org/patch/718315/


[2] How painful is it to use __weak function
instead of CONFIG_ARCH_EARLY_INIT_R


[3] We have board_early_init_r() for board-specific
init procedure.
From its function name, I thought arch_early_init_r() is
called for arch-specific (ARC, ARM, x86) init.
In fact, it is not.
ARC is good.  For ARM, x86, it is abused for board specific init.

For example,

board/siemens/rut/board.c

int arch_early_init_r(void)
{
      enable_lcd();
      return 0;
}

This is apparently board_init, not arch_init.






-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2017-01-24  2:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 20:31 [U-Boot] [PATCH 00/11] Move some init sequence options to Kconfig Simon Glass
2017-01-23 20:31 ` [U-Boot] [PATCH 01/11] configs: Resync with savedefconfig Simon Glass
2017-01-23 20:31 ` [U-Boot] [PATCH 02/11] config: Drop CONFIG_ARCH_DMA_PIO_WORDS Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot,02/11] " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 03/11] Convert CONFIG_ARCH_EARLY_INIT_R to Kconfig Simon Glass
2017-01-24  2:36   ` Masahiro Yamada [this message]
2017-01-24  3:30     ` Tom Rini
2017-01-26  3:00   ` [U-Boot] [U-Boot, " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 04/11] Convert CONFIG_BOARD_EARLY_INIT_F " Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot, " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 05/11] Convert CONFIG_ARCH_MISC_INIT " Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot, " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 06/11] powerpc: Drop probecpu() in favour of arch_cpu_init() Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot, " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 07/11] powerpc: Drop CONFIG_SYS_ALLOC_DPRAM Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot,07/11] " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 08/11] Drop CONFIG_WINBOND_83C553 Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot,08/11] " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 09/11] Drop the static inline print_cpuinfo() Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot,09/11] " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 10/11] Drop prt_mpc5xxx_clks() in favour of print_cpuinfo() Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot, " Tom Rini
2017-01-23 20:31 ` [U-Boot] [PATCH 11/11] Drop CONFIG_CMD_DOC Simon Glass
2017-01-26  3:00   ` [U-Boot] [U-Boot,11/11] " Tom Rini
2017-01-24  3:25 ` [U-Boot] [PATCH 00/11] Move some init sequence options to Kconfig Tom Rini
2017-02-06 15:32   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNAR_+iJ_Ypuxin1QJF0YkTrwjM8Pbs=3v05gp=RnEFJ+cQ@mail.gmail.com' \
    --to=yamada.masahiro@socionext.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.