From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FC7C3A5A9 for ; Wed, 4 Sep 2019 10:10:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D564323402 for ; Wed, 4 Sep 2019 10:10:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="tc1bbOw3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbfIDKKb (ORCPT ); Wed, 4 Sep 2019 06:10:31 -0400 Received: from condef-06.nifty.com ([202.248.20.71]:26967 "EHLO condef-06.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbfIDKK1 (ORCPT ); Wed, 4 Sep 2019 06:10:27 -0400 X-Greylist: delayed 630 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 Sep 2019 06:10:24 EDT Received: from conssluserg-01.nifty.com ([10.126.8.80])by condef-06.nifty.com with ESMTP id x849sG6A013584; Wed, 4 Sep 2019 18:54:16 +0900 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) (authenticated) by conssluserg-01.nifty.com with ESMTP id x849s15r014209; Wed, 4 Sep 2019 18:54:02 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com x849s15r014209 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1567590842; bh=JhR6cBZJXNkOmtdDQlpAlb7TvbwSunLjm1s429y9/Dc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tc1bbOw3q/fS5ESOlY4iWeAPsZZbollJrad1rcRIqARjafvBEG1L+szF2i0iuxMPB mOBSwDvJaIEqaWWvI4fc6KCfVZmuntO3U2gMm3dqAkrSqBaw/bvizI0nuadnKyZvnO 5jc7G4eWKcJKuQ0II/T4Dt4hm1RTHUdzJjVYIMcMjswkke/fj42M15xAKAGss/rgeZ rAYuC5BI98+uj8cX5/KKvSlspeH/HHZAi5RMDOr1tPaRHs1rnmqW1VvJU+o8tHBVuL ZLWc80VaCc+CZHnbxjGOZ1QD+qhaOp/tHcj+4s9tZ2Aeq8luTur+sSSRLm4Af1XGmD 52vqUUmANWokw== X-Nifty-SrcIP: [209.85.217.44] Received: by mail-vs1-f44.google.com with SMTP id b11so7831266vsq.2; Wed, 04 Sep 2019 02:54:02 -0700 (PDT) X-Gm-Message-State: APjAAAUznz7Try3leflUU5c/Vx/rXl8QBV4J9bSMyq+DyL3kdeyE8jvn Tt2HyLBB+VNuIMseXHs25POLE86V2iMbfSy3zcI= X-Google-Smtp-Source: APXvYqy7454Jcx92pI3RMqpwk+6S0ib6S9rkr/phvwsE/qgfXtGRn0kQpTfE9reHZl23eQ23thoWq0SUB2mqidzWvw0= X-Received: by 2002:a67:fd97:: with SMTP id k23mr21110513vsq.179.1567590841199; Wed, 04 Sep 2019 02:54:01 -0700 (PDT) MIME-Version: 1.0 References: <20180716122125.175792-1-maco@android.com> <20190903150638.242049-1-maennich@google.com> <20190903150638.242049-9-maennich@google.com> In-Reply-To: <20190903150638.242049-9-maennich@google.com> From: Masahiro Yamada Date: Wed, 4 Sep 2019 18:53:25 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 08/12] scripts: Coccinelle script for namespace dependencies. To: Matthias Maennich Cc: Linux Kernel Mailing List , "Cc: Android Kernel" , Arnd Bergmann , Greg Kroah-Hartman , Jessica Yu , "Joel Fernandes (Google)" , Lucas De Marchi , maco@android.com, sspatil@google.com, Will Deacon , Linux Kbuild mailing list , linux-modules@vger.kernel.org, linux-usb , usb-storage@lists.one-eyed-alien.net, linux-watchdog@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-modules@vger.kernel.org Precedence: bulk List-ID: On Wed, Sep 4, 2019 at 12:07 AM Matthias Maennich wrote: > > A script that uses the '.ns_deps' files generated by modpost to > automatically add the required symbol namespace dependencies to each > module. > > Usage: > 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define > DEFAULT_SYMBOL_NAMESPACE > 2) Run 'make' (or 'make modules') and get warnings about modules not > importing that namespace. > 3) Run 'make nsdeps' to automatically add required import statements > to said modules. > > This makes it easer for subsystem maintainers to introduce and maintain > symbol namespaces into their codebase. > > Co-developed-by: Martijn Coenen > Signed-off-by: Martijn Coenen > Acked-by: Julia Lawall > Reviewed-by: Greg Kroah-Hartman > Signed-off-by: Matthias Maennich Without any correct dependency, this does not work. $ make clean; make nsdeps cat: modules.order: No such file or directory cat: ./modules.order: No such file or directory I do not see any point in the Makefile changes. -- Best Regards Masahiro Yamada