Re: linux-next: build failure after merge of the kbuild tree

From: Masahiro Yamada <masahiroy@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nicolas Pitre <nico@fluxnic.net>
Subject: Re: linux-next: build failure after merge of the kbuild tree
Date: Wed, 11 Mar 2020 13:22:37 +0900	[thread overview]
Message-ID: <CAK7LNARmD5AaHmgpSk4Z8+NPd0kwSrVQnnx27vPci19KJ0+DPA@mail.gmail.com> (raw)
In-Reply-To: <20200311095319.30e14ac0@canb.auug.org.au>

Stephen,

On Wed, Mar 11, 2020 at 7:53 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> x86_64-linux-gnu-ld: net/core/devlink.o: in function `devlink_trap_report':
> (.text+0x4e7e): undefined reference to `net_dm_hw_report'
>
> Caused by commit
>
>   af20db858358 ("kconfig: allow symbols implied by y to become m")
>
> At least, reverting that commit (and commit
>
>   d590d0a6e6fe ("kconfig: make 'imply' obey the direct dependency"))
>
> allows the build to work.
>
> Advice, please.  Does someone need to audit all the uses of "imply"?


The following patch should fix the build error.


index 2ab668461463..f68bc373544a 100644

--- a/include/net/drop_monitor.h
+++ b/include/net/drop_monitor.h
@@ -19,7 +19,7 @@ struct net_dm_hw_metadata {
        struct net_device *input_dev;
 };

-#if IS_ENABLED(CONFIG_NET_DROP_MONITOR)
+#if IS_REACHABLE(CONFIG_NET_DROP_MONITOR)
 void net_dm_hw_report(struct sk_buff *skb,
                      const struct net_dm_hw_metadata *hw_metadata);
 #else




I will propose this fix-up in the net ML.



-- 
Best Regards
Masahiro Yamada
