From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BBC0C4BA1F for ; Wed, 26 Feb 2020 17:48:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F00920801 for ; Wed, 26 Feb 2020 17:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582739287; bh=fgXXmcy3p6J7HeRs7qw3qjSVUrD3Xh/4pPXjxkI9B/4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QV04PPUBKjZPDf8rstnUWrhlcYU7xXyZCG7Oe7XtawqdwXjUWk2wnlnsjZ/EioLI7 XRE0bL8eTWubOLc/3AbuWGVuMhyHv6MxL4Dm3p4fIxv58BIEfcspiODQaJ5Ea0wj0G X2BPTeGyXzD5YsqVHeo+LzgywcankwNOOohjz0F0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726996AbgBZRsF (ORCPT ); Wed, 26 Feb 2020 12:48:05 -0500 Received: from conssluserg-03.nifty.com ([210.131.2.82]:59514 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726920AbgBZRsF (ORCPT ); Wed, 26 Feb 2020 12:48:05 -0500 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 01QHlrqU018829; Thu, 27 Feb 2020 02:47:54 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 01QHlrqU018829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1582739274; bh=SDaslj3im9eGGF3GWkYw29Ie5s/mrO4oXtYg61NAUmg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TSAmf5YiR59vvSP5hW7HsQsk+UuON9lPxv8ggMkzklgJ60ttDBLTs80cPREFkVoCo aC1SepTe/mFTxqWwQLcwBJmWJq0OZBh0S4OfNZDiHAiQy9nJLm/LN8+IggTn0ZYTZn fKeUAF/4aYs2AQyohWL1Nb/AwLTqqnz5oub1NMBC1omVGHBSFRc424t6vRqtfgdlKt nEIsb0Ono4KNO6VBNmXA2k/CihTCFh6915uvoiak1KmfzgsYZFV4wkcVNfGjHIGrqe sdumET83GL/sPurNTyUFRx+59OsexvWo8vnYUqRw9c3disajhKarkba2tEMjv2GgHq bjGD44GtVm7LA== X-Nifty-SrcIP: [209.85.221.170] Received: by mail-vk1-f170.google.com with SMTP id i4so1044069vkc.3; Wed, 26 Feb 2020 09:47:54 -0800 (PST) X-Gm-Message-State: APjAAAVx71To1e0Pf6srG/mo5oE/3umRyVGvwn72FaEC1JpabV1lPHAK RnRJzC7Dm8rP7qnSlBiwB1fZVoDWB2rUrgUylFE= X-Google-Smtp-Source: APXvYqzpehfk2yzFqtjIzlN57l6KrpJIDEr5QVAEBgcdOrwuouWmBqXYwTpOOjVHS2Vp3P09dydm2ACynKUaaC2vXyk= X-Received: by 2002:a1f:6344:: with SMTP id x65mr231703vkb.26.1582739273088; Wed, 26 Feb 2020 09:47:53 -0800 (PST) MIME-Version: 1.0 References: <20200222190435.11767-1-masahiroy@kernel.org> <20200224225253.GA27948@bogus> In-Reply-To: From: Masahiro Yamada Date: Thu, 27 Feb 2020 02:47:16 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/5] kbuild: fix DT binding schema rule to detect command line changes To: Rob Herring Cc: Linux Kbuild mailing list , DTML , Michal Marek , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2020 at 1:32 PM Masahiro Yamada wrote: > > Hi Rob, > > On Tue, Feb 25, 2020 at 7:52 AM Rob Herring wrote: > > > > On Sun, Feb 23, 2020 at 04:04:31AM +0900, Masahiro Yamada wrote: > > > This if_change_rule is not working; it cannot detect any command line > > > changes. > > > > > > The reason is because cmd-check in scripts/Kbuild.include compares > > > $(cmd_$@) and $(cmd_$1), but cmd_dtc_dt_yaml does not exist here. > > > > > > For if_change_rule to work properly, the stem part of cmd_* and rule_* > > > must match. Because this cmd_and_fixdep invokes cmd_dtc, this rule must > > > be named rule_dtc. > > > > > > Fixes: 4f0e3a57d6eb ("kbuild: Add support for DT binding schema checks") > > > Signed-off-by: Masahiro Yamada > > > --- > > > > > > scripts/Makefile.lib | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > For the series, > > > > Acked-by: Rob Herring > > > > I'm assuming you will take these? If not, I can in the DT tree. > > Yes, I will queue these to kbuild tree. > > Applied with Rob's Ack. -- Best Regards Masahiro Yamada